From patchwork Wed Aug 14 12:15:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11093847 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 597BC13B1 for ; Wed, 14 Aug 2019 12:20:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45A1E28769 for ; Wed, 14 Aug 2019 12:20:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 398D12877B; Wed, 14 Aug 2019 12:20:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D835428769 for ; Wed, 14 Aug 2019 12:20:29 +0000 (UTC) Received: from localhost ([::1]:60076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxsGT-0004GS-58 for patchwork-qemu-devel@patchwork.kernel.org; Wed, 14 Aug 2019 08:20:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42695) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxsC4-0000FF-Q9 for qemu-devel@nongnu.org; Wed, 14 Aug 2019 08:15:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxsC3-0001gt-Ae for qemu-devel@nongnu.org; Wed, 14 Aug 2019 08:15:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32918) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hxsBr-0001cK-1T; Wed, 14 Aug 2019 08:15:45 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3FD2D300BEA8; Wed, 14 Aug 2019 12:15:41 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-203.brq.redhat.com [10.40.204.203]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B9EFB83093; Wed, 14 Aug 2019 12:15:37 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: "Richard W . M . Jones" , qemu-devel@nongnu.org, Pino Toscano Date: Wed, 14 Aug 2019 14:15:24 +0200 Message-Id: <20190814121527.17876-2-philmd@redhat.com> In-Reply-To: <20190814121527.17876-1-philmd@redhat.com> References: <20190814121527.17876-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 14 Aug 2019 12:15:41 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC PATCH 1/4] configure: Improve libssh check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, =?utf-8?q?Alex_Ben?= =?utf-8?q?n=C3=A9e?= , Max Reitz , =?utf-8?b?5ZGo5paH6Z2S?= <1151451036@qq.com>, =?utf-8?q?Philippe_Mathieu-Da?= =?utf-8?q?ud=C3=A9?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP The libssh pkg-config is not complete, the libraries required to link with libssh are not returned. For example on Ubuntu 18.04: $ dpkg -l|fgrep libssh ii libssh-4:arm64 0.8.0~20170825.94fa1e38-1ubuntu0.2 arm64 tiny C SSH library (OpenSSL flavor) ii libssh-dev 0.8.0~20170825.94fa1e38-1ubuntu0.2 arm64 tiny C SSH library. Development files (OpenSSL flavor) $ pkg-config libssh --libs -lssh Since the ./configure script tries to link an object to figure if libssh is available, it fails: $ cat config.log [...] cc -pthread -I/usr/include/glib-2.0 [...] -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -m64 -static -g -lssh /usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu/libssh.a(dh.c.o): In function `ssh_crypto_init': (.text+0x1a9): undefined reference to `BN_new' (.text+0x1c2): undefined reference to `BN_set_word' (.text+0x1c7): undefined reference to `BN_new' (.text+0x1e7): undefined reference to `BN_bin2bn' (.text+0x1ec): undefined reference to `BN_new' (.text+0x20c): undefined reference to `BN_bin2bn' (.text+0x218): undefined reference to `OPENSSL_init_crypto' [...] collect2: error: ld returned 1 exit status To bypass this check, simply compile an object using libssh headers. Signed-off-by: Philippe Mathieu-Daudé --- Should we check for libcrypto? $ pkg-config --libs libssh openssl -lssh -lssl -lcrypto --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 714e7fb6a1..1d5c07de1f 100755 --- a/configure +++ b/configure @@ -3951,7 +3951,7 @@ if test "$libssh" = "yes"; then #include int main(void) { return ssh_get_server_publickey(NULL, NULL); } EOF - if compile_prog "$libssh_cflags" "$libssh_libs"; then + if compile_object "$libssh_cflags"; then libssh_cflags="-DHAVE_LIBSSH_0_8 $libssh_cflags" fi fi