diff mbox series

[PULL,6/9] tests/libqtest: Remove unused function hmp()

Message ID 20190815175922.3475-7-thuth@redhat.com (mailing list archive)
State New, archived
Headers show
Series [PULL,1/9] qtest: Rename qtest.c:qtest_init() | expand

Commit Message

Thomas Huth Aug. 15, 2019, 5:59 p.m. UTC 
No test is using hmp() anymore, and since this function uses the disliked
global_qtest variable, we should also make sure that nobody adds new code
with this function again. qtest_hmp() should be used instead.

Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20190813093047.27948-4-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/libqtest.c | 11 -----------
 tests/libqtest.h | 10 ----------
 2 files changed, 21 deletions(-)
diff mbox series

Patch

diff --git a/tests/libqtest.c b/tests/libqtest.c
index 3c5c3f49d8..3e9245d4c9 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -1130,17 +1130,6 @@  void qmp_assert_success(const char *fmt, ...)
     qobject_unref(response);
 }
 
-char *hmp(const char *fmt, ...)
-{
-    va_list ap;
-    char *ret;
-
-    va_start(ap, fmt);
-    ret = qtest_vhmp(global_qtest, fmt, ap);
-    va_end(ap);
-    return ret;
-}
-
 bool qtest_big_endian(QTestState *s)
 {
     return s->big_endian;
diff --git a/tests/libqtest.h b/tests/libqtest.h
index cadf1d4a03..0009b65791 100644
--- a/tests/libqtest.h
+++ b/tests/libqtest.h
@@ -687,16 +687,6 @@  static inline void qmp_eventwait(const char *event)
     return qtest_qmp_eventwait(global_qtest, event);
 }
 
-/**
- * hmp:
- * @fmt...: HMP command to send to QEMU, formats arguments like sprintf().
- *
- * Send HMP command to QEMU via QMP's human-monitor-command.
- *
- * Returns: the command's output.  The caller should g_free() it.
- */
-char *hmp(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
-
 /**
  * get_irq:
  * @num: Interrupt to observe.