| Message ID | 20190902092932.20200-1-clg@kaod.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ppc/pnv: fix "bmc" node name in DT | expand |
On Mon, Sep 02, 2019 at 11:29:32AM +0200, Cédric Le Goater wrote: > Fixes the dtc output : > > ERROR (node_name_chars): //bmc: Bad character '/' in node name > Warning (avoid_unnecessary_addr_size): /bmc: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > Signed-off-by: Cédric Le Goater <clg@kaod.org> Applied to ppc-for-4.2, thanks. > --- > hw/ppc/pnv_bmc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c > index e5eb6e5a70da..dc5e918cb79e 100644 > --- a/hw/ppc/pnv_bmc.c > +++ b/hw/ppc/pnv_bmc.c > @@ -77,13 +77,10 @@ void pnv_dt_bmc_sensors(IPMIBmc *bmc, void *fdt) > const struct ipmi_sdr_compact *sdr; > uint16_t nextrec; > > - offset = fdt_add_subnode(fdt, 0, "/bmc"); > + offset = fdt_add_subnode(fdt, 0, "bmc"); > _FDT(offset); > > _FDT((fdt_setprop_string(fdt, offset, "name", "bmc"))); > - _FDT((fdt_setprop_cell(fdt, offset, "#address-cells", 0x1))); > - _FDT((fdt_setprop_cell(fdt, offset, "#size-cells", 0x0))); > - > offset = fdt_add_subnode(fdt, offset, "sensors"); > _FDT(offset); >
diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c index e5eb6e5a70da..dc5e918cb79e 100644 --- a/hw/ppc/pnv_bmc.c +++ b/hw/ppc/pnv_bmc.c @@ -77,13 +77,10 @@ void pnv_dt_bmc_sensors(IPMIBmc *bmc, void *fdt) const struct ipmi_sdr_compact *sdr; uint16_t nextrec; - offset = fdt_add_subnode(fdt, 0, "/bmc"); + offset = fdt_add_subnode(fdt, 0, "bmc"); _FDT(offset); _FDT((fdt_setprop_string(fdt, offset, "name", "bmc"))); - _FDT((fdt_setprop_cell(fdt, offset, "#address-cells", 0x1))); - _FDT((fdt_setprop_cell(fdt, offset, "#size-cells", 0x0))); - offset = fdt_add_subnode(fdt, offset, "sensors"); _FDT(offset);
Fixes the dtc output : ERROR (node_name_chars): //bmc: Bad character '/' in node name Warning (avoid_unnecessary_addr_size): /bmc: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property Signed-off-by: Cédric Le Goater <clg@kaod.org> --- hw/ppc/pnv_bmc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)