| Message ID | 20190916154847.28936-12-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw: Split RTC devices from hw/timer/ to hw/rtc/ | expand |
On 16/09/2019 17:48, Philippe Mathieu-Daudé wrote: > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> I suppose the removal of the header files in "aspeed_rtc.h" is OK. Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > hw/rtc/Makefile.objs | 1 + > hw/{timer => rtc}/aspeed_rtc.c | 2 +- > hw/rtc/trace-events | 4 ++++ > hw/timer/Makefile.objs | 2 +- > hw/timer/trace-events | 4 ---- > include/hw/arm/aspeed_soc.h | 2 +- > include/hw/{timer => rtc}/aspeed_rtc.h | 3 --- > 7 files changed, 8 insertions(+), 10 deletions(-) > rename hw/{timer => rtc}/aspeed_rtc.c (99%) > rename include/hw/{timer => rtc}/aspeed_rtc.h (92%) > > diff --git a/hw/rtc/Makefile.objs b/hw/rtc/Makefile.objs > index 3d4763fc26..8dc9fcd3a9 100644 > --- a/hw/rtc/Makefile.objs > +++ b/hw/rtc/Makefile.objs > @@ -10,3 +10,4 @@ common-obj-$(CONFIG_XLNX_ZYNQMP) += xlnx-zynqmp-rtc.o > common-obj-$(CONFIG_EXYNOS4) += exynos4210_rtc.o > obj-$(CONFIG_MC146818RTC) += mc146818rtc.o > common-obj-$(CONFIG_SUN4V_RTC) += sun4v-rtc.o > +common-obj-$(CONFIG_ASPEED_SOC) += aspeed_rtc.o > diff --git a/hw/timer/aspeed_rtc.c b/hw/rtc/aspeed_rtc.c > similarity index 99% > rename from hw/timer/aspeed_rtc.c > rename to hw/rtc/aspeed_rtc.c > index 5313017353..3ca1183558 100644 > --- a/hw/timer/aspeed_rtc.c > +++ b/hw/rtc/aspeed_rtc.c > @@ -8,7 +8,7 @@ > > #include "qemu/osdep.h" > #include "qemu-common.h" > -#include "hw/timer/aspeed_rtc.h" > +#include "hw/rtc/aspeed_rtc.h" > #include "migration/vmstate.h" > #include "qemu/log.h" > #include "qemu/timer.h" > diff --git a/hw/rtc/trace-events b/hw/rtc/trace-events > index 7f1945ad4c..d6749f4616 100644 > --- a/hw/rtc/trace-events > +++ b/hw/rtc/trace-events > @@ -13,3 +13,7 @@ pl031_read(uint32_t addr, uint32_t value) "addr 0x%08x value 0x%08x" > pl031_write(uint32_t addr, uint32_t value) "addr 0x%08x value 0x%08x" > pl031_alarm_raised(void) "alarm raised" > pl031_set_alarm(uint32_t ticks) "alarm set for %u ticks" > + > +# aspeed-rtc.c > +aspeed_rtc_read(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 > +aspeed_rtc_write(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 > diff --git a/hw/timer/Makefile.objs b/hw/timer/Makefile.objs > index 33191d74cb..83091770df 100644 > --- a/hw/timer/Makefile.objs > +++ b/hw/timer/Makefile.objs > @@ -29,7 +29,7 @@ common-obj-$(CONFIG_MIPS_CPS) += mips_gictimer.o > common-obj-$(CONFIG_ALLWINNER_A10_PIT) += allwinner-a10-pit.o > > common-obj-$(CONFIG_STM32F2XX_TIMER) += stm32f2xx_timer.o > -common-obj-$(CONFIG_ASPEED_SOC) += aspeed_timer.o aspeed_rtc.o > +common-obj-$(CONFIG_ASPEED_SOC) += aspeed_timer.o > > common-obj-$(CONFIG_CMSDK_APB_TIMER) += cmsdk-apb-timer.o > common-obj-$(CONFIG_CMSDK_APB_DUALTIMER) += cmsdk-apb-dualtimer.o > diff --git a/hw/timer/trace-events b/hw/timer/trace-events > index 1459d07237..e18b87fc96 100644 > --- a/hw/timer/trace-events > +++ b/hw/timer/trace-events > @@ -66,10 +66,6 @@ cmsdk_apb_dualtimer_read(uint64_t offset, uint64_t data, unsigned size) "CMSDK A > cmsdk_apb_dualtimer_write(uint64_t offset, uint64_t data, unsigned size) "CMSDK APB dualtimer write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" > cmsdk_apb_dualtimer_reset(void) "CMSDK APB dualtimer: reset" > > -# hw/timer/aspeed-rtc.c > -aspeed_rtc_read(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 > -aspeed_rtc_write(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 > - > # nrf51_timer.c > nrf51_timer_read(uint64_t addr, uint32_t value, unsigned size) "read addr 0x%" PRIx64 " data 0x%" PRIx32 " size %u" > nrf51_timer_write(uint64_t addr, uint32_t value, unsigned size) "write addr 0x%" PRIx64 " data 0x%" PRIx32 " size %u" > diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h > index ab5052b12c..5a443006ed 100644 > --- a/include/hw/arm/aspeed_soc.h > +++ b/include/hw/arm/aspeed_soc.h > @@ -17,7 +17,7 @@ > #include "hw/misc/aspeed_sdmc.h" > #include "hw/misc/aspeed_xdma.h" > #include "hw/timer/aspeed_timer.h" > -#include "hw/timer/aspeed_rtc.h" > +#include "hw/rtc/aspeed_rtc.h" > #include "hw/i2c/aspeed_i2c.h" > #include "hw/ssi/aspeed_smc.h" > #include "hw/watchdog/wdt_aspeed.h" > diff --git a/include/hw/timer/aspeed_rtc.h b/include/hw/rtc/aspeed_rtc.h > similarity index 92% > rename from include/hw/timer/aspeed_rtc.h > rename to include/hw/rtc/aspeed_rtc.h > index 15ba42912b..156c8faee3 100644 > --- a/include/hw/timer/aspeed_rtc.h > +++ b/include/hw/rtc/aspeed_rtc.h > @@ -8,9 +8,6 @@ > #ifndef ASPEED_RTC_H > #define ASPEED_RTC_H > > -#include <stdint.h> > - > -#include "hw/irq.h" > #include "hw/sysbus.h" > > typedef struct AspeedRtcState { >
On Mon, Sep 16, 2019 at 9:17 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Move RTC devices under the hw/rtc/ subdirectory. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/rtc/Makefile.objs | 1 + > hw/{timer => rtc}/aspeed_rtc.c | 2 +- > hw/rtc/trace-events | 4 ++++ > hw/timer/Makefile.objs | 2 +- > hw/timer/trace-events | 4 ---- > include/hw/arm/aspeed_soc.h | 2 +- > include/hw/{timer => rtc}/aspeed_rtc.h | 3 --- > 7 files changed, 8 insertions(+), 10 deletions(-) > rename hw/{timer => rtc}/aspeed_rtc.c (99%) > rename include/hw/{timer => rtc}/aspeed_rtc.h (92%) > > diff --git a/hw/rtc/Makefile.objs b/hw/rtc/Makefile.objs > index 3d4763fc26..8dc9fcd3a9 100644 > --- a/hw/rtc/Makefile.objs > +++ b/hw/rtc/Makefile.objs > @@ -10,3 +10,4 @@ common-obj-$(CONFIG_XLNX_ZYNQMP) += xlnx-zynqmp-rtc.o > common-obj-$(CONFIG_EXYNOS4) += exynos4210_rtc.o > obj-$(CONFIG_MC146818RTC) += mc146818rtc.o > common-obj-$(CONFIG_SUN4V_RTC) += sun4v-rtc.o > +common-obj-$(CONFIG_ASPEED_SOC) += aspeed_rtc.o > diff --git a/hw/timer/aspeed_rtc.c b/hw/rtc/aspeed_rtc.c > similarity index 99% > rename from hw/timer/aspeed_rtc.c > rename to hw/rtc/aspeed_rtc.c > index 5313017353..3ca1183558 100644 > --- a/hw/timer/aspeed_rtc.c > +++ b/hw/rtc/aspeed_rtc.c > @@ -8,7 +8,7 @@ > > #include "qemu/osdep.h" > #include "qemu-common.h" > -#include "hw/timer/aspeed_rtc.h" > +#include "hw/rtc/aspeed_rtc.h" > #include "migration/vmstate.h" > #include "qemu/log.h" > #include "qemu/timer.h" > diff --git a/hw/rtc/trace-events b/hw/rtc/trace-events > index 7f1945ad4c..d6749f4616 100644 > --- a/hw/rtc/trace-events > +++ b/hw/rtc/trace-events > @@ -13,3 +13,7 @@ pl031_read(uint32_t addr, uint32_t value) "addr 0x%08x value 0x%08x" > pl031_write(uint32_t addr, uint32_t value) "addr 0x%08x value 0x%08x" > pl031_alarm_raised(void) "alarm raised" > pl031_set_alarm(uint32_t ticks) "alarm set for %u ticks" > + > +# aspeed-rtc.c > +aspeed_rtc_read(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 > +aspeed_rtc_write(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 > diff --git a/hw/timer/Makefile.objs b/hw/timer/Makefile.objs > index 33191d74cb..83091770df 100644 > --- a/hw/timer/Makefile.objs > +++ b/hw/timer/Makefile.objs > @@ -29,7 +29,7 @@ common-obj-$(CONFIG_MIPS_CPS) += mips_gictimer.o > common-obj-$(CONFIG_ALLWINNER_A10_PIT) += allwinner-a10-pit.o > > common-obj-$(CONFIG_STM32F2XX_TIMER) += stm32f2xx_timer.o > -common-obj-$(CONFIG_ASPEED_SOC) += aspeed_timer.o aspeed_rtc.o > +common-obj-$(CONFIG_ASPEED_SOC) += aspeed_timer.o > > common-obj-$(CONFIG_CMSDK_APB_TIMER) += cmsdk-apb-timer.o > common-obj-$(CONFIG_CMSDK_APB_DUALTIMER) += cmsdk-apb-dualtimer.o > diff --git a/hw/timer/trace-events b/hw/timer/trace-events > index 1459d07237..e18b87fc96 100644 > --- a/hw/timer/trace-events > +++ b/hw/timer/trace-events > @@ -66,10 +66,6 @@ cmsdk_apb_dualtimer_read(uint64_t offset, uint64_t data, unsigned size) "CMSDK A > cmsdk_apb_dualtimer_write(uint64_t offset, uint64_t data, unsigned size) "CMSDK APB dualtimer write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" > cmsdk_apb_dualtimer_reset(void) "CMSDK APB dualtimer: reset" > > -# hw/timer/aspeed-rtc.c > -aspeed_rtc_read(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 > -aspeed_rtc_write(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 > - > # nrf51_timer.c > nrf51_timer_read(uint64_t addr, uint32_t value, unsigned size) "read addr 0x%" PRIx64 " data 0x%" PRIx32 " size %u" > nrf51_timer_write(uint64_t addr, uint32_t value, unsigned size) "write addr 0x%" PRIx64 " data 0x%" PRIx32 " size %u" > diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h > index ab5052b12c..5a443006ed 100644 > --- a/include/hw/arm/aspeed_soc.h > +++ b/include/hw/arm/aspeed_soc.h > @@ -17,7 +17,7 @@ > #include "hw/misc/aspeed_sdmc.h" > #include "hw/misc/aspeed_xdma.h" > #include "hw/timer/aspeed_timer.h" > -#include "hw/timer/aspeed_rtc.h" > +#include "hw/rtc/aspeed_rtc.h" > #include "hw/i2c/aspeed_i2c.h" > #include "hw/ssi/aspeed_smc.h" > #include "hw/watchdog/wdt_aspeed.h" > diff --git a/include/hw/timer/aspeed_rtc.h b/include/hw/rtc/aspeed_rtc.h > similarity index 92% > rename from include/hw/timer/aspeed_rtc.h > rename to include/hw/rtc/aspeed_rtc.h > index 15ba42912b..156c8faee3 100644 > --- a/include/hw/timer/aspeed_rtc.h > +++ b/include/hw/rtc/aspeed_rtc.h > @@ -8,9 +8,6 @@ > #ifndef ASPEED_RTC_H > #define ASPEED_RTC_H > > -#include <stdint.h> > - > -#include "hw/irq.h" > #include "hw/sysbus.h" > > typedef struct AspeedRtcState { > -- > 2.20.1 > >
On 9/16/19 7:21 PM, Cédric Le Goater wrote: > On 16/09/2019 17:48, Philippe Mathieu-Daudé wrote: >> Move RTC devices under the hw/rtc/ subdirectory. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > I suppose the removal of the header files in "aspeed_rtc.h" is OK. They are not used. It is probably cleaner to do this change in a separate patch. > > Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks! [...] >> diff --git a/include/hw/timer/aspeed_rtc.h b/include/hw/rtc/aspeed_rtc.h >> similarity index 92% >> rename from include/hw/timer/aspeed_rtc.h >> rename to include/hw/rtc/aspeed_rtc.h >> index 15ba42912b..156c8faee3 100644 >> --- a/include/hw/timer/aspeed_rtc.h >> +++ b/include/hw/rtc/aspeed_rtc.h >> @@ -8,9 +8,6 @@ >> #ifndef ASPEED_RTC_H >> #define ASPEED_RTC_H >> >> -#include <stdint.h> >> - >> -#include "hw/irq.h" >> #include "hw/sysbus.h" >> >> typedef struct AspeedRtcState { >>
diff --git a/hw/rtc/Makefile.objs b/hw/rtc/Makefile.objs index 3d4763fc26..8dc9fcd3a9 100644 --- a/hw/rtc/Makefile.objs +++ b/hw/rtc/Makefile.objs @@ -10,3 +10,4 @@ common-obj-$(CONFIG_XLNX_ZYNQMP) += xlnx-zynqmp-rtc.o common-obj-$(CONFIG_EXYNOS4) += exynos4210_rtc.o obj-$(CONFIG_MC146818RTC) += mc146818rtc.o common-obj-$(CONFIG_SUN4V_RTC) += sun4v-rtc.o +common-obj-$(CONFIG_ASPEED_SOC) += aspeed_rtc.o diff --git a/hw/timer/aspeed_rtc.c b/hw/rtc/aspeed_rtc.c similarity index 99% rename from hw/timer/aspeed_rtc.c rename to hw/rtc/aspeed_rtc.c index 5313017353..3ca1183558 100644 --- a/hw/timer/aspeed_rtc.c +++ b/hw/rtc/aspeed_rtc.c @@ -8,7 +8,7 @@ #include "qemu/osdep.h" #include "qemu-common.h" -#include "hw/timer/aspeed_rtc.h" +#include "hw/rtc/aspeed_rtc.h" #include "migration/vmstate.h" #include "qemu/log.h" #include "qemu/timer.h" diff --git a/hw/rtc/trace-events b/hw/rtc/trace-events index 7f1945ad4c..d6749f4616 100644 --- a/hw/rtc/trace-events +++ b/hw/rtc/trace-events @@ -13,3 +13,7 @@ pl031_read(uint32_t addr, uint32_t value) "addr 0x%08x value 0x%08x" pl031_write(uint32_t addr, uint32_t value) "addr 0x%08x value 0x%08x" pl031_alarm_raised(void) "alarm raised" pl031_set_alarm(uint32_t ticks) "alarm set for %u ticks" + +# aspeed-rtc.c +aspeed_rtc_read(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 +aspeed_rtc_write(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 diff --git a/hw/timer/Makefile.objs b/hw/timer/Makefile.objs index 33191d74cb..83091770df 100644 --- a/hw/timer/Makefile.objs +++ b/hw/timer/Makefile.objs @@ -29,7 +29,7 @@ common-obj-$(CONFIG_MIPS_CPS) += mips_gictimer.o common-obj-$(CONFIG_ALLWINNER_A10_PIT) += allwinner-a10-pit.o common-obj-$(CONFIG_STM32F2XX_TIMER) += stm32f2xx_timer.o -common-obj-$(CONFIG_ASPEED_SOC) += aspeed_timer.o aspeed_rtc.o +common-obj-$(CONFIG_ASPEED_SOC) += aspeed_timer.o common-obj-$(CONFIG_CMSDK_APB_TIMER) += cmsdk-apb-timer.o common-obj-$(CONFIG_CMSDK_APB_DUALTIMER) += cmsdk-apb-dualtimer.o diff --git a/hw/timer/trace-events b/hw/timer/trace-events index 1459d07237..e18b87fc96 100644 --- a/hw/timer/trace-events +++ b/hw/timer/trace-events @@ -66,10 +66,6 @@ cmsdk_apb_dualtimer_read(uint64_t offset, uint64_t data, unsigned size) "CMSDK A cmsdk_apb_dualtimer_write(uint64_t offset, uint64_t data, unsigned size) "CMSDK APB dualtimer write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" cmsdk_apb_dualtimer_reset(void) "CMSDK APB dualtimer: reset" -# hw/timer/aspeed-rtc.c -aspeed_rtc_read(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 -aspeed_rtc_write(uint64_t addr, uint64_t value) "addr 0x%02" PRIx64 " value 0x%08" PRIx64 - # nrf51_timer.c nrf51_timer_read(uint64_t addr, uint32_t value, unsigned size) "read addr 0x%" PRIx64 " data 0x%" PRIx32 " size %u" nrf51_timer_write(uint64_t addr, uint32_t value, unsigned size) "write addr 0x%" PRIx64 " data 0x%" PRIx32 " size %u" diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index ab5052b12c..5a443006ed 100644 --- a/include/hw/arm/aspeed_soc.h +++ b/include/hw/arm/aspeed_soc.h @@ -17,7 +17,7 @@ #include "hw/misc/aspeed_sdmc.h" #include "hw/misc/aspeed_xdma.h" #include "hw/timer/aspeed_timer.h" -#include "hw/timer/aspeed_rtc.h" +#include "hw/rtc/aspeed_rtc.h" #include "hw/i2c/aspeed_i2c.h" #include "hw/ssi/aspeed_smc.h" #include "hw/watchdog/wdt_aspeed.h" diff --git a/include/hw/timer/aspeed_rtc.h b/include/hw/rtc/aspeed_rtc.h similarity index 92% rename from include/hw/timer/aspeed_rtc.h rename to include/hw/rtc/aspeed_rtc.h index 15ba42912b..156c8faee3 100644 --- a/include/hw/timer/aspeed_rtc.h +++ b/include/hw/rtc/aspeed_rtc.h @@ -8,9 +8,6 @@ #ifndef ASPEED_RTC_H #define ASPEED_RTC_H -#include <stdint.h> - -#include "hw/irq.h" #include "hw/sysbus.h" typedef struct AspeedRtcState {
Move RTC devices under the hw/rtc/ subdirectory. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/rtc/Makefile.objs | 1 + hw/{timer => rtc}/aspeed_rtc.c | 2 +- hw/rtc/trace-events | 4 ++++ hw/timer/Makefile.objs | 2 +- hw/timer/trace-events | 4 ---- include/hw/arm/aspeed_soc.h | 2 +- include/hw/{timer => rtc}/aspeed_rtc.h | 3 --- 7 files changed, 8 insertions(+), 10 deletions(-) rename hw/{timer => rtc}/aspeed_rtc.c (99%) rename include/hw/{timer => rtc}/aspeed_rtc.h (92%)