diff mbox series

[v1,1/9] tests/docker: add sanitizers back to clang build

Message ID 20190917184109.12564-2-alex.bennee@linaro.org (mailing list archive)
State New, archived
Headers show
Series testing/next (docker,podman,float) | expand

Commit Message

Alex Bennée Sept. 17, 2019, 6:41 p.m. UTC
From: John Snow <jsnow@redhat.com>

Fedora23 is but a distant twinkle.
The sanitizer works again, and even if not,
we have --enable-sanitizers now.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20190912014442.5757-1-jsnow@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/docker/test-clang | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

John Snow Sept. 17, 2019, 6:43 p.m. UTC | #1
On 9/17/19 2:41 PM, Alex Bennée wrote:
> From: John Snow <jsnow@redhat.com>
> 
> Fedora23 is but a distant twinkle.
> The sanitizer works again, and even if not,
> we have --enable-sanitizers now.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> Message-Id: <20190912014442.5757-1-jsnow@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Hi Alex:

As a warning, I do believe this *does* produce some sanitizer errors for
this build which I have not had the time to investigate.

We might be treated to some patchew complaints in response to this
patch, if it runs clang builds.

--js

> ---
>  tests/docker/test-clang | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/tests/docker/test-clang b/tests/docker/test-clang
> index 324e341cea9..db9e6970b78 100755
> --- a/tests/docker/test-clang
> +++ b/tests/docker/test-clang
> @@ -17,11 +17,7 @@ requires clang
>  
>  cd "$BUILD_DIR"
>  
> -OPTS="--cxx=clang++ --cc=clang --host-cc=clang"
> -# -fsanitize=undefined is broken on Fedora 23, skip it for now
> -# See also: https://bugzilla.redhat.com/show_bug.cgi?id=1263834
> -#OPTS="$OPTS --extra-cflags=-fsanitize=undefined \
> -    #--extra-cflags=-fno-sanitize=float-divide-by-zero"
> +OPTS="--cxx=clang++ --cc=clang --host-cc=clang --enable-sanitizers"
>  build_qemu $OPTS
>  check_qemu
>  install_qemu
>
diff mbox series

Patch

diff --git a/tests/docker/test-clang b/tests/docker/test-clang
index 324e341cea9..db9e6970b78 100755
--- a/tests/docker/test-clang
+++ b/tests/docker/test-clang
@@ -17,11 +17,7 @@  requires clang
 
 cd "$BUILD_DIR"
 
-OPTS="--cxx=clang++ --cc=clang --host-cc=clang"
-# -fsanitize=undefined is broken on Fedora 23, skip it for now
-# See also: https://bugzilla.redhat.com/show_bug.cgi?id=1263834
-#OPTS="$OPTS --extra-cflags=-fsanitize=undefined \
-    #--extra-cflags=-fno-sanitize=float-divide-by-zero"
+OPTS="--cxx=clang++ --cc=clang --host-cc=clang --enable-sanitizers"
 build_qemu $OPTS
 check_qemu
 install_qemu