Message ID | 20190924200902.4703-22-vsementsov@virtuozzo.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=jeqM=XT=nongnu.org=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 39BF91709 for <patchwork-qemu-devel@patchwork.kernel.org>; Tue, 24 Sep 2019 20:25:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18D4420872 for <patchwork-qemu-devel@patchwork.kernel.org>; Tue, 24 Sep 2019 20:25:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18D4420872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:50736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org>) id 1iCrMq-00029W-L7 for patchwork-qemu-devel@patchwork.kernel.org; Tue, 24 Sep 2019 16:25:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44069) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <vsementsov@virtuozzo.com>) id 1iCr8P-0000tu-5p for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <vsementsov@virtuozzo.com>) id 1iCr8N-00031m-Kp for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:04 -0400 Received: from relay.sw.ru ([185.231.240.75]:38158) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <vsementsov@virtuozzo.com>) id 1iCr8N-0002uR-02 for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:03 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from <vsementsov@virtuozzo.com>) id 1iCr8B-0001Mk-Kj; Tue, 24 Sep 2019 23:09:51 +0300 From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> To: qemu-devel@nongnu.org Subject: [PATCH v3 21/25] QOM: Fix error_append_hint usage Date: Tue, 24 Sep 2019 23:08:58 +0300 Message-Id: <20190924200902.4703-22-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190924200902.4703-1-vsementsov@virtuozzo.com> References: <20190924200902.4703-1-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: Paolo Bonzini <pbonzini@redhat.com>, vsementsov@virtuozzo.com, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>, Greg Kurz <groug@kaod.org>, Eduardo Habkost <ehabkost@redhat.com> Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org> |
Series |
error: auto propagated local_err
|
expand
|
diff --git a/qdev-monitor.c b/qdev-monitor.c index 148df9cacf..d0129411fb 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -328,6 +328,7 @@ static Object *qdev_get_peripheral_anon(void) static void qbus_list_bus(DeviceState *dev, Error **errp) { + ERRP_FUNCTION_BEGIN(); BusState *child; const char *sep = " "; @@ -342,6 +343,7 @@ static void qbus_list_bus(DeviceState *dev, Error **errp) static void qbus_list_dev(BusState *bus, Error **errp) { + ERRP_FUNCTION_BEGIN(); BusChild *kid; const char *sep = " ";
If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro. Otherwise hint will not be appended in case of errp == &fatal_err (program will exit before error_append_hint() call). Fix such cases. This commit (together with its neighbors) was generated by git grep -l 'error_append_hint(errp' | while read f; do \ spatch --sp-file scripts/coccinelle/fix-error_append_hint-usage.cocci \ --in-place $f; done and then ./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)" (auto-msg was a file with this commit message) Still, for backporting it may be more comfortable to use only the first command and then do one huge commit. Reported-by: Greg Kurz <groug@kaod.org> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- qdev-monitor.c | 2 ++ 1 file changed, 2 insertions(+)