From patchwork Wed Sep 25 06:45:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Gibson X-Patchwork-Id: 11160063 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F2C021599 for ; Wed, 25 Sep 2019 06:49:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE33F217F4 for ; Wed, 25 Sep 2019 06:49:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="OmTOq1hG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE33F217F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD17W-0002Fh-4z for patchwork-qemu-devel@patchwork.kernel.org; Wed, 25 Sep 2019 02:49:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38528) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD13g-0008H0-PH for qemu-devel@nongnu.org; Wed, 25 Sep 2019 02:45:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iD13f-0003Rg-El for qemu-devel@nongnu.org; Wed, 25 Sep 2019 02:45:52 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:60149 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iD13e-0003Ox-W0; Wed, 25 Sep 2019 02:45:51 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 46dT8m58Lsz9sPc; Wed, 25 Sep 2019 16:45:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1569393944; bh=YoZ6nDBhhOntdGlFmN4sT1V55L3hT1F130IYLZSQyK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OmTOq1hGfCdnWA/LtKZHz9ejWuZ5UxQQRETwGrOHEdS7RHmc53aA4dGNEPTD9bUsC Me0ErMku2l/SOrBwdXpXjCizhWphn8w/envuDL81ANGnyyRYGMm86jhvcwGuobifO6 VKlzdnar4qi7LVJzRJLy8M7FunLzVRG7E/KMuS3o= From: David Gibson To: qemu-ppc@nongnu.org, clg@kaod.org, qemu-devel@nongnu.org Subject: [PATCH 01/20] xics: Use incomplete type for XICSFabric Date: Wed, 25 Sep 2019 16:45:15 +1000 Message-Id: <20190925064534.19155-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190925064534.19155-1-david@gibson.dropbear.id.au> References: <20190925064534.19155-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Riku Voipio , groug@kaod.org, Laurent Vivier , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Paolo Bonzini , philmd@redhat.com, David Gibson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Interface instances should never be directly dereferenced. So, the common practice is to make them incomplete types to make sure no-one does that. XICSFrabric, however, had a dummy type which is less safe. Signed-off-by: David Gibson Reviewed-by: Greg Kurz --- include/hw/ppc/xics.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h index 64a2c8862a..1ae34ce9cd 100644 --- a/include/hw/ppc/xics.h +++ b/include/hw/ppc/xics.h @@ -147,9 +147,7 @@ struct ICSIRQState { uint8_t flags; }; -struct XICSFabric { - Object parent; -}; +typedef struct XICSFabric XICSFabric; #define TYPE_XICS_FABRIC "xics-fabric" #define XICS_FABRIC(obj) \