| Message ID | 20191008105259.5378-3-lersek@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/i386: pass "MachineState.smp.max_cpus" to OVMF | expand |
On 10/8/19 12:52 PM, Laszlo Ersek wrote: > The enable_compat_apic_id_mode() function definition was removed earlier; "in 457cfcccdd1" > there are no callers left. Remove the function declaration too. > > Cc: Eduardo Habkost <ehabkost@redhat.com> > Cc: Igor Mammedov <imammedo@redhat.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> > Cc: Richard Henderson <rth@twiddle.net> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515 > Signed-off-by: Laszlo Ersek <lersek@redhat.com> > --- > target/i386/cpu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target/i386/cpu.h b/target/i386/cpu.h > index eaa5395aa539..c9ab1a367939 100644 > --- a/target/i386/cpu.h > +++ b/target/i386/cpu.h > @@ -2126,8 +2126,6 @@ void x86_cpu_set_default_version(X86CPUVersion version); > /* Return name of 32-bit register, from a R_* constant */ > const char *get_register_name_32(unsigned int reg); > > -void enable_compat_apic_id_mode(void); > - > #define APIC_DEFAULT_ADDRESS 0xfee00000 > #define APIC_SPACE_SIZE 0x100000 > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On 10/08/19 15:35, Philippe Mathieu-Daudé wrote: > On 10/8/19 12:52 PM, Laszlo Ersek wrote: >> The enable_compat_apic_id_mode() function definition was removed earlier; > > "in 457cfcccdd1" Thanks. I'll add that to the commit message if I need to post a v2. > >> there are no callers left. Remove the function declaration too. >> >> Cc: Eduardo Habkost <ehabkost@redhat.com> >> Cc: Igor Mammedov <imammedo@redhat.com> >> Cc: Paolo Bonzini <pbonzini@redhat.com> >> Cc: Richard Henderson <rth@twiddle.net> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515 >> Signed-off-by: Laszlo Ersek <lersek@redhat.com> >> --- >> target/i386/cpu.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/target/i386/cpu.h b/target/i386/cpu.h >> index eaa5395aa539..c9ab1a367939 100644 >> --- a/target/i386/cpu.h >> +++ b/target/i386/cpu.h >> @@ -2126,8 +2126,6 @@ void x86_cpu_set_default_version(X86CPUVersion >> version); >> /* Return name of 32-bit register, from a R_* constant */ >> const char *get_register_name_32(unsigned int reg); >> -void enable_compat_apic_id_mode(void); >> - >> #define APIC_DEFAULT_ADDRESS 0xfee00000 >> #define APIC_SPACE_SIZE 0x100000 >> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Cheers! Laszlo
diff --git a/target/i386/cpu.h b/target/i386/cpu.h index eaa5395aa539..c9ab1a367939 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -2126,8 +2126,6 @@ void x86_cpu_set_default_version(X86CPUVersion version); /* Return name of 32-bit register, from a R_* constant */ const char *get_register_name_32(unsigned int reg); -void enable_compat_apic_id_mode(void); - #define APIC_DEFAULT_ADDRESS 0xfee00000 #define APIC_SPACE_SIZE 0x100000
The enable_compat_apic_id_mode() function definition was removed earlier; there are no callers left. Remove the function declaration too. Cc: Eduardo Habkost <ehabkost@redhat.com> Cc: Igor Mammedov <imammedo@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Richard Henderson <rth@twiddle.net> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515 Signed-off-by: Laszlo Ersek <lersek@redhat.com> --- target/i386/cpu.h | 2 -- 1 file changed, 2 deletions(-)