| Message ID | 20191105091056.9541-3-guoheyi@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add SDEI support for arm64 | expand |
On Tue, 5 Nov 2019 17:10:44 +0800 Heyi Guo <guoheyi@huawei.com> wrote: > Import Linux header file include/uapi/linux/arm_sdei.h from kernel v5.4-rc5. > > This is to prepare for qemu SDEI emulation. > > Signed-off-by: Heyi Guo <guoheyi@huawei.com> > Cc: Peter Maydell <peter.maydell@linaro.org> > Cc: Dave Martin <Dave.Martin@arm.com> > Cc: Marc Zyngier <marc.zyngier@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: James Morse <james.morse@arm.com> > Cc: "Michael S. Tsirkin" <mst@redhat.com> > Cc: Cornelia Huck <cohuck@redhat.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> > --- > > Notes: > v2: > - Import arm_sdei.h by running update-linux-headers.sh > > include/standard-headers/linux/arm_sdei.h | 73 +++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 include/standard-headers/linux/arm_sdei.h Just a remark that I find it a bit odd that that a header that looks arm-specific is in the generic linux/ directory (already in the kernel, I know.) Is this for sharing between arm and arm64, maybe?
On 2019/11/7 1:52, Cornelia Huck wrote: > On Tue, 5 Nov 2019 17:10:44 +0800 > Heyi Guo <guoheyi@huawei.com> wrote: > >> Import Linux header file include/uapi/linux/arm_sdei.h from kernel v5.4-rc5. >> >> This is to prepare for qemu SDEI emulation. >> >> Signed-off-by: Heyi Guo <guoheyi@huawei.com> >> Cc: Peter Maydell <peter.maydell@linaro.org> >> Cc: Dave Martin <Dave.Martin@arm.com> >> Cc: Marc Zyngier <marc.zyngier@arm.com> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: James Morse <james.morse@arm.com> >> Cc: "Michael S. Tsirkin" <mst@redhat.com> >> Cc: Cornelia Huck <cohuck@redhat.com> >> Cc: Paolo Bonzini <pbonzini@redhat.com> >> --- >> >> Notes: >> v2: >> - Import arm_sdei.h by running update-linux-headers.sh >> >> include/standard-headers/linux/arm_sdei.h | 73 +++++++++++++++++++++++ >> 1 file changed, 73 insertions(+) >> create mode 100644 include/standard-headers/linux/arm_sdei.h > Just a remark that I find it a bit odd that that a header that looks > arm-specific is in the generic linux/ directory (already in the kernel, > I know.) Is this for sharing between arm and arm64, maybe? I don't think arm platforms will use this header. In section 4.1 of SDEI spec, it says " Both the client and dispatcher of SDEI must execute in AArch64 state." So shall we move it to include/standard-headers/asm-arm64/? Thanks, HG > > > . >
On Thu, 7 Nov 2019 09:40:49 +0800 Guoheyi <guoheyi@huawei.com> wrote: > On 2019/11/7 1:52, Cornelia Huck wrote: > > On Tue, 5 Nov 2019 17:10:44 +0800 > > Heyi Guo <guoheyi@huawei.com> wrote: > > > >> Import Linux header file include/uapi/linux/arm_sdei.h from kernel v5.4-rc5. > >> > >> This is to prepare for qemu SDEI emulation. > >> > >> Signed-off-by: Heyi Guo <guoheyi@huawei.com> > >> Cc: Peter Maydell <peter.maydell@linaro.org> > >> Cc: Dave Martin <Dave.Martin@arm.com> > >> Cc: Marc Zyngier <marc.zyngier@arm.com> > >> Cc: Mark Rutland <mark.rutland@arm.com> > >> Cc: James Morse <james.morse@arm.com> > >> Cc: "Michael S. Tsirkin" <mst@redhat.com> > >> Cc: Cornelia Huck <cohuck@redhat.com> > >> Cc: Paolo Bonzini <pbonzini@redhat.com> > >> --- > >> > >> Notes: > >> v2: > >> - Import arm_sdei.h by running update-linux-headers.sh > >> > >> include/standard-headers/linux/arm_sdei.h | 73 +++++++++++++++++++++++ > >> 1 file changed, 73 insertions(+) > >> create mode 100644 include/standard-headers/linux/arm_sdei.h > > Just a remark that I find it a bit odd that that a header that looks > > arm-specific is in the generic linux/ directory (already in the kernel, > > I know.) Is this for sharing between arm and arm64, maybe? > I don't think arm platforms will use this header. In section 4.1 of SDEI > spec, it says " Both the client and dispatcher of SDEI must execute in > AArch64 state." > So shall we move it to include/standard-headers/asm-arm64/? Well, the kernel already put it into the generic directory... I'd just leave it like that, then; moving it in the kernel is probably too much churn.
On Thu, Nov 07, 2019 at 09:40:49AM +0800, Guoheyi wrote: > > > On 2019/11/7 1:52, Cornelia Huck wrote: > > On Tue, 5 Nov 2019 17:10:44 +0800 > > Heyi Guo <guoheyi@huawei.com> wrote: > > > > > Import Linux header file include/uapi/linux/arm_sdei.h from kernel v5.4-rc5. > > > > > > This is to prepare for qemu SDEI emulation. > > > > > > Signed-off-by: Heyi Guo <guoheyi@huawei.com> > > > Cc: Peter Maydell <peter.maydell@linaro.org> > > > Cc: Dave Martin <Dave.Martin@arm.com> > > > Cc: Marc Zyngier <marc.zyngier@arm.com> > > > Cc: Mark Rutland <mark.rutland@arm.com> > > > Cc: James Morse <james.morse@arm.com> > > > Cc: "Michael S. Tsirkin" <mst@redhat.com> > > > Cc: Cornelia Huck <cohuck@redhat.com> > > > Cc: Paolo Bonzini <pbonzini@redhat.com> > > > --- > > > > > > Notes: > > > v2: > > > - Import arm_sdei.h by running update-linux-headers.sh > > > > > > include/standard-headers/linux/arm_sdei.h | 73 +++++++++++++++++++++++ > > > 1 file changed, 73 insertions(+) > > > create mode 100644 include/standard-headers/linux/arm_sdei.h > > Just a remark that I find it a bit odd that that a header that looks > > arm-specific is in the generic linux/ directory (already in the kernel, > > I know.) Is this for sharing between arm and arm64, maybe? > I don't think arm platforms will use this header. In section 4.1 of SDEI > spec, it says " Both the client and dispatcher of SDEI must execute in > AArch64 state." > So shall we move it to include/standard-headers/asm-arm64/? > > Thanks, > HG Yea, that's because it's used by drivers/firmware/arm_sdei.c, also flat in the top level hierarchy. It's been like this historically. If you want to do a small kernel project and reorganize drivers/firmware/ according to the architecture, then arm_sdei.h can move too. Until that happens upstream let's just mirror what kernel does. > > > > > > . > > >
diff --git a/include/standard-headers/linux/arm_sdei.h b/include/standard-headers/linux/arm_sdei.h new file mode 100644 index 0000000000..568d971915 --- /dev/null +++ b/include/standard-headers/linux/arm_sdei.h @@ -0,0 +1,73 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* Copyright (C) 2017 Arm Ltd. */ +#ifndef _LINUX_ARM_SDEI_H +#define _LINUX_ARM_SDEI_H + +#define SDEI_1_0_FN_BASE 0xC4000020 +#define SDEI_1_0_MASK 0xFFFFFFE0 +#define SDEI_1_0_FN(n) (SDEI_1_0_FN_BASE + (n)) + +#define SDEI_1_0_FN_SDEI_VERSION SDEI_1_0_FN(0x00) +#define SDEI_1_0_FN_SDEI_EVENT_REGISTER SDEI_1_0_FN(0x01) +#define SDEI_1_0_FN_SDEI_EVENT_ENABLE SDEI_1_0_FN(0x02) +#define SDEI_1_0_FN_SDEI_EVENT_DISABLE SDEI_1_0_FN(0x03) +#define SDEI_1_0_FN_SDEI_EVENT_CONTEXT SDEI_1_0_FN(0x04) +#define SDEI_1_0_FN_SDEI_EVENT_COMPLETE SDEI_1_0_FN(0x05) +#define SDEI_1_0_FN_SDEI_EVENT_COMPLETE_AND_RESUME SDEI_1_0_FN(0x06) +#define SDEI_1_0_FN_SDEI_EVENT_UNREGISTER SDEI_1_0_FN(0x07) +#define SDEI_1_0_FN_SDEI_EVENT_STATUS SDEI_1_0_FN(0x08) +#define SDEI_1_0_FN_SDEI_EVENT_GET_INFO SDEI_1_0_FN(0x09) +#define SDEI_1_0_FN_SDEI_EVENT_ROUTING_SET SDEI_1_0_FN(0x0A) +#define SDEI_1_0_FN_SDEI_PE_MASK SDEI_1_0_FN(0x0B) +#define SDEI_1_0_FN_SDEI_PE_UNMASK SDEI_1_0_FN(0x0C) +#define SDEI_1_0_FN_SDEI_INTERRUPT_BIND SDEI_1_0_FN(0x0D) +#define SDEI_1_0_FN_SDEI_INTERRUPT_RELEASE SDEI_1_0_FN(0x0E) +#define SDEI_1_0_FN_SDEI_PRIVATE_RESET SDEI_1_0_FN(0x11) +#define SDEI_1_0_FN_SDEI_SHARED_RESET SDEI_1_0_FN(0x12) + +#define SDEI_VERSION_MAJOR_SHIFT 48 +#define SDEI_VERSION_MAJOR_MASK 0x7fff +#define SDEI_VERSION_MINOR_SHIFT 32 +#define SDEI_VERSION_MINOR_MASK 0xffff +#define SDEI_VERSION_VENDOR_SHIFT 0 +#define SDEI_VERSION_VENDOR_MASK 0xffffffff + +#define SDEI_VERSION_MAJOR(x) (x>>SDEI_VERSION_MAJOR_SHIFT & SDEI_VERSION_MAJOR_MASK) +#define SDEI_VERSION_MINOR(x) (x>>SDEI_VERSION_MINOR_SHIFT & SDEI_VERSION_MINOR_MASK) +#define SDEI_VERSION_VENDOR(x) (x>>SDEI_VERSION_VENDOR_SHIFT & SDEI_VERSION_VENDOR_MASK) + +/* SDEI return values */ +#define SDEI_SUCCESS 0 +#define SDEI_NOT_SUPPORTED -1 +#define SDEI_INVALID_PARAMETERS -2 +#define SDEI_DENIED -3 +#define SDEI_PENDING -5 +#define SDEI_OUT_OF_RESOURCE -10 + +/* EVENT_REGISTER flags */ +#define SDEI_EVENT_REGISTER_RM_ANY 0 +#define SDEI_EVENT_REGISTER_RM_PE 1 + +/* EVENT_STATUS return value bits */ +#define SDEI_EVENT_STATUS_RUNNING 2 +#define SDEI_EVENT_STATUS_ENABLED 1 +#define SDEI_EVENT_STATUS_REGISTERED 0 + +/* EVENT_COMPLETE status values */ +#define SDEI_EV_HANDLED 0 +#define SDEI_EV_FAILED 1 + +/* GET_INFO values */ +#define SDEI_EVENT_INFO_EV_TYPE 0 +#define SDEI_EVENT_INFO_EV_SIGNALED 1 +#define SDEI_EVENT_INFO_EV_PRIORITY 2 +#define SDEI_EVENT_INFO_EV_ROUTING_MODE 3 +#define SDEI_EVENT_INFO_EV_ROUTING_AFF 4 + +/* and their results */ +#define SDEI_EVENT_TYPE_PRIVATE 0 +#define SDEI_EVENT_TYPE_SHARED 1 +#define SDEI_EVENT_PRIORITY_NORMAL 0 +#define SDEI_EVENT_PRIORITY_CRITICAL 1 + +#endif /* _LINUX_ARM_SDEI_H */
Import Linux header file include/uapi/linux/arm_sdei.h from kernel v5.4-rc5. This is to prepare for qemu SDEI emulation. Signed-off-by: Heyi Guo <guoheyi@huawei.com> Cc: Peter Maydell <peter.maydell@linaro.org> Cc: Dave Martin <Dave.Martin@arm.com> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: James Morse <james.morse@arm.com> Cc: "Michael S. Tsirkin" <mst@redhat.com> Cc: Cornelia Huck <cohuck@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> --- Notes: v2: - Import arm_sdei.h by running update-linux-headers.sh include/standard-headers/linux/arm_sdei.h | 73 +++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 include/standard-headers/linux/arm_sdei.h