| Message ID | 20191108101655.10611-2-vsementsov@virtuozzo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Deprecate implicit filters | expand |
On Fri, Nov 08, 2019 at 13:16:54 +0300, Vladimir Sementsov-Ogievskiy wrote: > To correspond to blockdev-mirror command and make it possible to > deprecate implicit filters in the next commit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > --- > qapi/block-core.json | 7 +++++++ > blockdev.c | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index aa97ee2641..93530d3a13 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -1992,6 +1992,12 @@ > # @on-target-error: the action to take on an error on the target, > # default 'report' (no limitations, since this applies to > # a different block device than @device). > +# > +# @filter-node-name: the node name that should be assigned to the > +# filter driver that the mirror job inserts into the graph > +# above @device. If this option is not given, a node name is > +# autogenerated. (Since: 4.2) > +# Speaking for libvirt and based on what I've responded to patch 2 there's no value in adding this parameter for libvirt's use. This also kind of means that drive-mirror can be deprecated together with deprecating -drive.
diff --git a/qapi/block-core.json b/qapi/block-core.json index aa97ee2641..93530d3a13 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1992,6 +1992,12 @@ # @on-target-error: the action to take on an error on the target, # default 'report' (no limitations, since this applies to # a different block device than @device). +# +# @filter-node-name: the node name that should be assigned to the +# filter driver that the mirror job inserts into the graph +# above @device. If this option is not given, a node name is +# autogenerated. (Since: 4.2) +# # @unmap: Whether to try to unmap target sectors where source has # only zero. If true, and target unallocated sectors will read as zero, # target image sectors will be unmapped; otherwise, zeroes will be @@ -2022,6 +2028,7 @@ '*speed': 'int', '*granularity': 'uint32', '*buf-size': 'int', '*on-source-error': 'BlockdevOnError', '*on-target-error': 'BlockdevOnError', + '*filter-node-name': 'str', '*unmap': 'bool', '*copy-mode': 'MirrorCopyMode', '*auto-finalize': 'bool', '*auto-dismiss': 'bool' } } diff --git a/blockdev.c b/blockdev.c index 8e029e9c01..2ca614c77f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -4008,7 +4008,7 @@ void qmp_drive_mirror(DriveMirror *arg, Error **errp) arg->has_on_source_error, arg->on_source_error, arg->has_on_target_error, arg->on_target_error, arg->has_unmap, arg->unmap, - false, NULL, + arg->has_filter_node_name, arg->filter_node_name, arg->has_copy_mode, arg->copy_mode, arg->has_auto_finalize, arg->auto_finalize, arg->has_auto_dismiss, arg->auto_dismiss,
To correspond to blockdev-mirror command and make it possible to deprecate implicit filters in the next commit. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- qapi/block-core.json | 7 +++++++ blockdev.c | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-)