| Message ID | 20191124050225.30351-18-mrolnik@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | QEMU AVR 8 bit cores | expand |
On Sunday, November 24, 2019, Michael Rolnik <mrolnik@gmail.com> wrote: > Include AVR maintaners in MAINTAINERS file > > Signed-off-by: Michael Rolnik <mrolnik@gmail.com> > --- > MAINTAINERS | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5e5e3e52d6..ad2d9dd04a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -163,6 +163,15 @@ S: Maintained > F: hw/arm/smmu* > F: include/hw/arm/smmu* > > +AVR TCG CPUs > +M: Michael Rolnik <mrolnik@gmail.com> > +S: Maintained > +F: target/avr/ > +F: hw/misc/avr_mask.c > +F: hw/char/avr_usart.c > +F: hw/timer/avr_timer16.c > +F: hw/avr/ > + If Cleber and Eduardo don't object, please add file: tests/acceptance/machine_avr6.py to the list. This means that the file would have a sort of "dual" maintainrship: Cleber and Eduardo would take care of Python/Avocado/test harness aspects, while you and Sarah would take care of AVR aspects. Cleber and Eduardo, please note that AVR target will be significantly different than others, since these CPUs are not meant to work with Linux kernel, and there are other idiosyncracies where AVR folks would be really needed. There is also a case of MIPS-specific Avocado test where, at least from my point of view, dual maintainership worked well, so I think this one would work well too. With or without that file addition: Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com> > CRIS TCG CPUs > M: Edgar E. Iglesias <edgar.iglesias@gmail.com> > S: Maintained > -- > 2.17.2 (Apple Git-113) > >
----- Original Message ----- > From: "Aleksandar Markovic" <aleksandar.m.mail@gmail.com> > To: "Michael Rolnik" <mrolnik@gmail.com>, "Cleber Rosa" <crosa@redhat.com>, "Eduardo Habkost" <ehabkost@redhat.com> > Cc: qemu-devel@nongnu.org, "richard henderson" <richard.henderson@linaro.org>, philmd@redhat.com, thuth@redhat.com, > dovgaluk@ispras.ru, imammedo@redhat.com > Sent: Monday, November 25, 2019 6:49:40 PM > Subject: Re: [PATCH v36 17/17] target/avr: Update MAINTAINERS file > > On Sunday, November 24, 2019, Michael Rolnik <mrolnik@gmail.com> wrote: > > > Include AVR maintaners in MAINTAINERS file > > > > Signed-off-by: Michael Rolnik <mrolnik@gmail.com> > > --- > > MAINTAINERS | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 5e5e3e52d6..ad2d9dd04a 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -163,6 +163,15 @@ S: Maintained > > F: hw/arm/smmu* > > F: include/hw/arm/smmu* > > > > +AVR TCG CPUs > > +M: Michael Rolnik <mrolnik@gmail.com> > > +S: Maintained > > +F: target/avr/ > > +F: hw/misc/avr_mask.c > > +F: hw/char/avr_usart.c > > +F: hw/timer/avr_timer16.c > > +F: hw/avr/ > > + > > > If Cleber and Eduardo don't object, please add file: > > tests/acceptance/machine_avr6.py > > to the list. This means that the file would have a sort of "dual" > maintainrship: Cleber and Eduardo would take care of Python/Avocado/test > harness aspects, while you and Sarah would take care of AVR aspects. > No objections, quite the contrary, I'd happy to be CC'd when such code changes. Thanks, - Cleber. > Cleber and Eduardo, please note that AVR target will be significantly > different than others, since these CPUs are not meant to work with Linux > kernel, and there are other idiosyncracies where AVR folks would be really > needed. There is also a case of MIPS-specific Avocado test where, at least > from my point of view, dual maintainership worked well, so I think this one > would work well too. > > With or without that file addition: > > Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com> > > > > > CRIS TCG CPUs > > M: Edgar E. Iglesias <edgar.iglesias@gmail.com> > > S: Maintained > > -- > > 2.17.2 (Apple Git-113) > > > > >
On Sunday, November 24, 2019, Michael Rolnik <mrolnik@gmail.com> wrote: > Include AVR maintaners in MAINTAINERS file > > Signed-off-by: Michael Rolnik <mrolnik@gmail.com> > --- > MAINTAINERS | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5e5e3e52d6..ad2d9dd04a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -163,6 +163,15 @@ S: Maintained > F: hw/arm/smmu* > F: include/hw/arm/smmu* > > +AVR TCG CPUs > +M: Michael Rolnik <mrolnik@gmail.com> > +S: Maintained > +F: target/avr/ > +F: hw/misc/avr_mask.c > +F: hw/char/avr_usart.c > +F: hw/timer/avr_timer16.c > +F: hw/avr/ > + I had a strange feeling that something is missing here, and I finally realized what that was: R: Sarah Harris <S.E.Harris@kent.ac.uk> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04225.html CRIS TCG CPUs > M: Edgar E. Iglesias <edgar.iglesias@gmail.com> > S: Maintained > -- > 2.17.2 (Apple Git-113) > >
Aleksandar, there was an email from Sarah, stating that she does not want to be a maintainer. On Tue, Nov 26, 2019 at 5:17 AM Aleksandar Markovic < aleksandar.m.mail@gmail.com> wrote: > > > On Sunday, November 24, 2019, Michael Rolnik <mrolnik@gmail.com> wrote: > >> Include AVR maintaners in MAINTAINERS file >> >> Signed-off-by: Michael Rolnik <mrolnik@gmail.com> >> --- >> MAINTAINERS | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 5e5e3e52d6..ad2d9dd04a 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -163,6 +163,15 @@ S: Maintained >> F: hw/arm/smmu* >> F: include/hw/arm/smmu* >> >> +AVR TCG CPUs >> +M: Michael Rolnik <mrolnik@gmail.com> >> +S: Maintained >> +F: target/avr/ >> +F: hw/misc/avr_mask.c >> +F: hw/char/avr_usart.c >> +F: hw/timer/avr_timer16.c >> +F: hw/avr/ >> + > > > I had a strange feeling that something is missing here, and I finally > realized what that was: > > R: Sarah Harris <S.E.Harris@kent.ac.uk> > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04225.html > > > > CRIS TCG CPUs >> M: Edgar E. Iglesias <edgar.iglesias@gmail.com> >> S: Maintained >> -- >> 2.17.2 (Apple Git-113) >> >>
On Tue, Nov 26, 2019 at 8:06 PM Michael Rolnik <mrolnik@gmail.com> wrote: > > Aleksandar, > > there was an email from Sarah, stating that she does not want to be a maintainer. > But this is for "reviewer" role, not "maintainer". Sarah? > On Tue, Nov 26, 2019 at 5:17 AM Aleksandar Markovic <aleksandar.m.mail@gmail.com> wrote: >> >> >> >> On Sunday, November 24, 2019, Michael Rolnik <mrolnik@gmail.com> wrote: >>> >>> Include AVR maintaners in MAINTAINERS file >>> >>> Signed-off-by: Michael Rolnik <mrolnik@gmail.com> >>> --- >>> MAINTAINERS | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 5e5e3e52d6..ad2d9dd04a 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -163,6 +163,15 @@ S: Maintained >>> F: hw/arm/smmu* >>> F: include/hw/arm/smmu* >>> >>> +AVR TCG CPUs >>> +M: Michael Rolnik <mrolnik@gmail.com> >>> +S: Maintained >>> +F: target/avr/ >>> +F: hw/misc/avr_mask.c >>> +F: hw/char/avr_usart.c >>> +F: hw/timer/avr_timer16.c >>> +F: hw/avr/ >>> + >> >> >> I had a strange feeling that something is missing here, and I finally realized what that was: >> >> R: Sarah Harris <S.E.Harris@kent.ac.uk> >> >> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04225.html >> >> >> >>> CRIS TCG CPUs >>> M: Edgar E. Iglesias <edgar.iglesias@gmail.com> >>> S: Maintained >>> -- >>> 2.17.2 (Apple Git-113) >>> > > > -- > Best Regards, > Michael Rolnik
Ah. I think Sarah was ok with reviewer role. On Tue, Nov 26, 2019 at 9:39 PM Aleksandar Markovic < aleksandar.m.mail@gmail.com> wrote: > On Tue, Nov 26, 2019 at 8:06 PM Michael Rolnik <mrolnik@gmail.com> wrote: > > > > Aleksandar, > > > > there was an email from Sarah, stating that she does not want to be a > maintainer. > > > > But this is for "reviewer" role, not "maintainer". > > Sarah? > > > On Tue, Nov 26, 2019 at 5:17 AM Aleksandar Markovic < > aleksandar.m.mail@gmail.com> wrote: > >> > >> > >> > >> On Sunday, November 24, 2019, Michael Rolnik <mrolnik@gmail.com> wrote: > >>> > >>> Include AVR maintaners in MAINTAINERS file > >>> > >>> Signed-off-by: Michael Rolnik <mrolnik@gmail.com> > >>> --- > >>> MAINTAINERS | 9 +++++++++ > >>> 1 file changed, 9 insertions(+) > >>> > >>> diff --git a/MAINTAINERS b/MAINTAINERS > >>> index 5e5e3e52d6..ad2d9dd04a 100644 > >>> --- a/MAINTAINERS > >>> +++ b/MAINTAINERS > >>> @@ -163,6 +163,15 @@ S: Maintained > >>> F: hw/arm/smmu* > >>> F: include/hw/arm/smmu* > >>> > >>> +AVR TCG CPUs > >>> +M: Michael Rolnik <mrolnik@gmail.com> > >>> +S: Maintained > >>> +F: target/avr/ > >>> +F: hw/misc/avr_mask.c > >>> +F: hw/char/avr_usart.c > >>> +F: hw/timer/avr_timer16.c > >>> +F: hw/avr/ > >>> + > >> > >> > >> I had a strange feeling that something is missing here, and I finally > realized what that was: > >> > >> R: Sarah Harris <S.E.Harris@kent.ac.uk> > >> > >> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04225.html > >> > >> > >> > >>> CRIS TCG CPUs > >>> M: Edgar E. Iglesias <edgar.iglesias@gmail.com> > >>> S: Maintained > >>> -- > >>> 2.17.2 (Apple Git-113) > >>> > > > > > > -- > > Best Regards, > > Michael Rolnik >
On Tue, Nov 26, 2019 at 12:49:40AM +0100, Aleksandar Markovic wrote: > On Sunday, November 24, 2019, Michael Rolnik <mrolnik@gmail.com> wrote: > > > Include AVR maintaners in MAINTAINERS file > > > > Signed-off-by: Michael Rolnik <mrolnik@gmail.com> > > --- > > MAINTAINERS | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 5e5e3e52d6..ad2d9dd04a 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -163,6 +163,15 @@ S: Maintained > > F: hw/arm/smmu* > > F: include/hw/arm/smmu* > > > > +AVR TCG CPUs > > +M: Michael Rolnik <mrolnik@gmail.com> > > +S: Maintained > > +F: target/avr/ > > +F: hw/misc/avr_mask.c > > +F: hw/char/avr_usart.c > > +F: hw/timer/avr_timer16.c > > +F: hw/avr/ > > + > > > If Cleber and Eduardo don't object, please add file: > > tests/acceptance/machine_avr6.py > > to the list. This means that the file would have a sort of "dual" > maintainrship: Cleber and Eduardo would take care of Python/Avocado/test > harness aspects, while you and Sarah would take care of AVR aspects. No objections. Thanks! > > Cleber and Eduardo, please note that AVR target will be significantly > different than others, since these CPUs are not meant to work with Linux > kernel, and there are other idiosyncracies where AVR folks would be really > needed. There is also a case of MIPS-specific Avocado test where, at least > from my point of view, dual maintainership worked well, so I think this one > would work well too. > > With or without that file addition: > > Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Yes, I don't have time to do maintenance, but I can manage reviewing. Kind regards, Sarah Harris On Tue, 26 Nov 2019 22:41:32 +0200 Michael Rolnik <mrolnik@gmail.com> wrote: > Ah. I think Sarah was ok with reviewer role. > > On Tue, Nov 26, 2019 at 9:39 PM Aleksandar Markovic < > aleksandar.m.mail@gmail.com> wrote: > > > On Tue, Nov 26, 2019 at 8:06 PM Michael Rolnik <mrolnik@gmail.com> wrote: > > > > > > Aleksandar, > > > > > > there was an email from Sarah, stating that she does not want to be a > > maintainer. > > > > > > > But this is for "reviewer" role, not "maintainer". > > > > Sarah? > > > > > On Tue, Nov 26, 2019 at 5:17 AM Aleksandar Markovic < > > aleksandar.m.mail@gmail.com> wrote: > > >> > > >> > > >> > > >> On Sunday, November 24, 2019, Michael Rolnik <mrolnik@gmail.com> wrote: > > >>> > > >>> Include AVR maintaners in MAINTAINERS file > > >>> > > >>> Signed-off-by: Michael Rolnik <mrolnik@gmail.com> > > >>> --- > > >>> MAINTAINERS | 9 +++++++++ > > >>> 1 file changed, 9 insertions(+) > > >>> > > >>> diff --git a/MAINTAINERS b/MAINTAINERS > > >>> index 5e5e3e52d6..ad2d9dd04a 100644 > > >>> --- a/MAINTAINERS > > >>> +++ b/MAINTAINERS > > >>> @@ -163,6 +163,15 @@ S: Maintained > > >>> F: hw/arm/smmu* > > >>> F: include/hw/arm/smmu* > > >>> > > >>> +AVR TCG CPUs > > >>> +M: Michael Rolnik <mrolnik@gmail.com> > > >>> +S: Maintained > > >>> +F: target/avr/ > > >>> +F: hw/misc/avr_mask.c > > >>> +F: hw/char/avr_usart.c > > >>> +F: hw/timer/avr_timer16.c > > >>> +F: hw/avr/ > > >>> + > > >> > > >> > > >> I had a strange feeling that something is missing here, and I finally > > realized what that was: > > >> > > >> R: Sarah Harris <S.E.Harris@kent.ac.uk> > > >> > > >> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04225.html > > >> > > >> > > >> > > >>> CRIS TCG CPUs > > >>> M: Edgar E. Iglesias <edgar.iglesias@gmail.com> > > >>> S: Maintained > > >>> -- > > >>> 2.17.2 (Apple Git-113) > > >>> > > > > > > > > > -- > > > Best Regards, > > > Michael Rolnik > > > > > -- > Best Regards, > Michael Rolnik
diff --git a/MAINTAINERS b/MAINTAINERS index 5e5e3e52d6..ad2d9dd04a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -163,6 +163,15 @@ S: Maintained F: hw/arm/smmu* F: include/hw/arm/smmu* +AVR TCG CPUs +M: Michael Rolnik <mrolnik@gmail.com> +S: Maintained +F: target/avr/ +F: hw/misc/avr_mask.c +F: hw/char/avr_usart.c +F: hw/timer/avr_timer16.c +F: hw/avr/ + CRIS TCG CPUs M: Edgar E. Iglesias <edgar.iglesias@gmail.com> S: Maintained
Include AVR maintaners in MAINTAINERS file Signed-off-by: Michael Rolnik <mrolnik@gmail.com> --- MAINTAINERS | 9 +++++++++ 1 file changed, 9 insertions(+)