From patchwork Wed Dec 11 17:05:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 11285791 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 034E46C1 for ; Wed, 11 Dec 2019 17:17:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDDD121556 for ; Wed, 11 Dec 2019 17:17:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ORQaYPXD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDDD121556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:46598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if5cJ-0001iT-90 for patchwork-qemu-devel@patchwork.kernel.org; Wed, 11 Dec 2019 12:17:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38608) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if5QZ-00050E-P9 for qemu-devel@nongnu.org; Wed, 11 Dec 2019 12:05:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1if5QY-0003AH-8G for qemu-devel@nongnu.org; Wed, 11 Dec 2019 12:05:31 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:36615) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1if5QY-00038z-1Q for qemu-devel@nongnu.org; Wed, 11 Dec 2019 12:05:30 -0500 Received: by mail-wr1-x444.google.com with SMTP id z3so24896955wru.3 for ; Wed, 11 Dec 2019 09:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lyIoUe/ZVUEe7f58GiHMN33OAajnqHTLc8UAK5dR3Hs=; b=ORQaYPXDUmapxEgYA4QmzGPpVypfJbsTXyYnvi+cpghEHkOg+SWGhyzNiT0pJbJ/IH nBStOt8fawHG7oQ5Gp4t0ZD1NTXyc/8dqIyeLOgKn1H5lOUWVlSbxsuXVKbjG5GBab1A DWEtVEtlUcYDe35OY2fx4JGqUJjO9vT64MBuB3QFrywc21ZYUeWVXecjQSUp/2OP+RA4 xw+OD2/nYSWJoYZAxSOnB+p6lve3FhBHBaFFmDYKoFYOcZ0Ofj6Ar8cqATePhFo5SKxl Ozr6Lf4GFjRdP8/g68QN/FuziInwLniGAtKmc6e7To4ajmagfmsH8u8Fub+eQEnqEKtW 7YPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lyIoUe/ZVUEe7f58GiHMN33OAajnqHTLc8UAK5dR3Hs=; b=g1IkmgTJpGlWYBS1FXg6NGJMq1ZI/iYBkFX6iAawZJYugi/OEIlsMlqfIcNOoqrqsB QYaV29Tcc0ykTZEmvLdIAi8V2scv5ZGeDswgGY+ThOEA5mt4O6M6/pIeRhjAtcXu5k4l XsLmQviOc2z7Oizxo2GDBJGxzYx+RmaSyVXi7z8aSFTUebSi+WXNzDXEfx5hVnkXm0xc dHH9hDrIiI3TIfbO7BqJHcO0YJKHUKifPv0NGq3vBL+sryTEfR+hE+2K6ZiRDQD5xa6x RsXo07hN4p12+mTsbAMnitZKubk6UikqQoDYq8l2fS1eIYvd3bc1jc+UzYTh8AOPb9O4 A4TA== X-Gm-Message-State: APjAAAWPi0X37ped7fmZdzy+v+3iOhZNfZCLb+GsdPrCCdmhxfi0fv5r oaUb11uZDqNsAIzbbWwjEICutA== X-Google-Smtp-Source: APXvYqxBBLNCVL4ujlJpoOfQ4xuIHdOvTJjpvp/5kT5y6mNziWpAWtIZ6IPyEVqxxKqnxYLX9cUoIw== X-Received: by 2002:a05:6000:11c6:: with SMTP id i6mr912446wrx.178.1576083928928; Wed, 11 Dec 2019 09:05:28 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id i127sm2918724wma.35.2019.12.11.09.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 09:05:24 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id F3F2C1FF93; Wed, 11 Dec 2019 17:05:21 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v3 06/20] target/arm: use gdb_get_reg helpers Date: Wed, 11 Dec 2019 17:05:06 +0000 Message-Id: <20191211170520.7747-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191211170520.7747-1-alex.bennee@linaro.org> References: <20191211170520.7747-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: damien.hedde@greensocs.com, Peter Maydell , luis.machado@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , richard.henderson@linaro.org, "open list:ARM TCG CPUs" , alan.hayward@arm.com, =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" This is cleaner than poking memory directly and will make later clean-ups easier. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v2 - make sure we pass hi/lo correctly as quads are stored in LE order --- target/arm/helper.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 0bf8f53d4b8..0ac950d6c71 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -105,21 +105,17 @@ static int aarch64_fpu_gdb_get_reg(CPUARMState *env, uint8_t *buf, int reg) { switch (reg) { case 0 ... 31: - /* 128 bit FP register */ - { - uint64_t *q = aa64_vfp_qreg(env, reg); - stq_le_p(buf, q[0]); - stq_le_p(buf + 8, q[1]); - return 16; - } + { + /* 128 bit FP register - quads are in LE order */ + uint64_t *q = aa64_vfp_qreg(env, reg); + return gdb_get_reg128(buf, q[1], q[0]); + } case 32: /* FPSR */ - stl_p(buf, vfp_get_fpsr(env)); - return 4; + return gdb_get_reg32(buf, vfp_get_fpsr(env)); case 33: /* FPCR */ - stl_p(buf, vfp_get_fpcr(env)); - return 4; + return gdb_get_reg32(buf,vfp_get_fpcr(env)); default: return 0; }