From patchwork Tue Dec 17 04:42:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Gibson X-Patchwork-Id: 11296701 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1AE2A14E3 for ; Tue, 17 Dec 2019 05:33:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E15692072B for ; Tue, 17 Dec 2019 05:33:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="CmaxjR9z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E15692072B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:35914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ih5U4-0003Gb-IX for patchwork-qemu-devel@patchwork.kernel.org; Tue, 17 Dec 2019 00:33:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34768) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ih4jL-0001cf-BG for qemu-devel@nongnu.org; Mon, 16 Dec 2019 23:45:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ih4jK-00071l-9O for qemu-devel@nongnu.org; Mon, 16 Dec 2019 23:45:07 -0500 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:57659 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ih4jJ-0006Vo-VK; Mon, 16 Dec 2019 23:45:06 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 47cQWb3HC8z9sTJ; Tue, 17 Dec 2019 15:43:38 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1576557819; bh=gKTXY6PIFlGqQkjlQe3AzKVDyV+OH7Fw3zyDvKgJzpc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CmaxjR9z/I8fsymqZJUtk2RrfDSOX/x063IEx0/+7Ta5uozXmvsOp5CxQfiyZx9lw 6ksP4jWO12wctUXaJbmQMGP5Ys9n0bSOzMzLMewLdcW33cH6IpgJokvl5UH5Q0VLrO XgfXO3folmt49nVH53F8gpOJ5R1q1SKRPTXzGR7s= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 57/88] xics: Don't deassert outputs Date: Tue, 17 Dec 2019 15:42:51 +1100 Message-Id: <20191217044322.351838-58-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191217044322.351838-1-david@gibson.dropbear.id.au> References: <20191217044322.351838-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Greg Kurz The correct way to do this is to deassert the input pins on the CPU side. This is the case since a previous change. Signed-off-by: Greg Kurz Message-Id: <157548862298.3650476.1228720391270249433.stgit@bahia.lan> Signed-off-by: David Gibson --- hw/intc/xics.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index 0b259a09c5..1952009e6d 100644 --- a/hw/intc/xics.c +++ b/hw/intc/xics.c @@ -289,9 +289,6 @@ void icp_reset(ICPState *icp) icp->pending_priority = 0xff; icp->mfrr = 0xff; - /* Make all outputs are deasserted */ - qemu_set_irq(icp->output, 0); - if (kvm_irqchip_in_kernel()) { Error *local_err = NULL;