[RFC,04/14] virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler

Commit Message

Philippe Mathieu-Daudé Dec. 17, 2019, 4:37 p.m. UTC

The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit when frontends ignore some events, to silent GCC the
following warnings:

    CC      hw/char/virtio-console.o
  hw/char/virtio-console.c: In function ‘chr_event’:
  hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_BREAK’ not handled in switch [-Werror=switch]
    154 |     switch (event) {
        |     ^~~~~~
  hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ not handled in switch [-Werror=switch]
  hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’ not handled in switch [-Werror=switch]
  cc1: all warnings being treated as errors

Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
---
Cc: "Michael S. Tsirkin" <[e-mail]>
Cc: Laurent Vivier <[e-mail]>
Cc: Amit Shah <[e-mail]>
Cc: "Marc-André Lureau" <[e-mail]>
Cc: Paolo Bonzini <[e-mail]>
---
 hw/char/virtio-console.c | 3 +++
 1 file changed, 3 insertions(+)

Patch

diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c
index c13649f1ef..d3f7ba36fe 100644
--- a/hw/char/virtio-console.c
+++ b/hw/char/virtio-console.c
@@ -162,6 +162,9 @@  static void chr_event(void *opaque, int event)
         }
         virtio_serial_close(port);
         break;
+    default:
+        /* Ignore */
+        break;
     }
 }