| Message ID | 20191217173425.5082-5-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix more GCC9 -O3 warnings | expand |
On 17/12/2019 18:34, Philippe Mathieu-Daudé wrote: > Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: > > hw/timer/aspeed_timer.c: In function ‘aspeed_timer_set_value’: > hw/timer/aspeed_timer.c:283:24: error: this statement may fall through [-Werror=implicit-fallthrough=] > 283 | if (old_reload || !t->reload) { > | ~~~~~~~~~~~^~~~~~~~~~~~~ > hw/timer/aspeed_timer.c:287:5: note: here > 287 | case TIMER_REG_STATUS: > | ^~~~ > cc1: all warnings being treated as errors > > Add the missing fall through comment. > > Fixes: 1403f364472 > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> > --- > Cc: "Cédric Le Goater" <clg@kaod.org> > Cc: Peter Maydell <peter.maydell@linaro.org> > Cc: Andrew Jeffery <andrew@aj.id.au> > Cc: Joel Stanley <joel@jms.id.au> > Cc: qemu-arm@nongnu.org > --- > hw/timer/aspeed_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c > index a8c38cc118..c91f18415c 100644 > --- a/hw/timer/aspeed_timer.c > +++ b/hw/timer/aspeed_timer.c > @@ -283,7 +283,7 @@ static void aspeed_timer_set_value(AspeedTimerCtrlState *s, int timer, int reg, > if (old_reload || !t->reload) { > break; > } > - > + /* fall through to re-enable */ > case TIMER_REG_STATUS: > if (timer_enabled(t)) { > uint64_t now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); >
On Tue, Dec 17, 2019 at 6:37 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: > > hw/timer/aspeed_timer.c: In function ‘aspeed_timer_set_value’: > hw/timer/aspeed_timer.c:283:24: error: this statement may fall through [-Werror=implicit-fallthrough=] > 283 | if (old_reload || !t->reload) { > | ~~~~~~~~~~~^~~~~~~~~~~~~ > hw/timer/aspeed_timer.c:287:5: note: here > 287 | case TIMER_REG_STATUS: > | ^~~~ > cc1: all warnings being treated as errors > > Add the missing fall through comment. > > Fixes: 1403f364472 > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com> > Cc: "Cédric Le Goater" <clg@kaod.org> > Cc: Peter Maydell <peter.maydell@linaro.org> > Cc: Andrew Jeffery <andrew@aj.id.au> > Cc: Joel Stanley <joel@jms.id.au> > Cc: qemu-arm@nongnu.org > --- > hw/timer/aspeed_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c > index a8c38cc118..c91f18415c 100644 > --- a/hw/timer/aspeed_timer.c > +++ b/hw/timer/aspeed_timer.c > @@ -283,7 +283,7 @@ static void aspeed_timer_set_value(AspeedTimerCtrlState *s, int timer, int reg, > if (old_reload || !t->reload) { > break; > } > - > + /* fall through to re-enable */ > case TIMER_REG_STATUS: > if (timer_enabled(t)) { > uint64_t now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); > -- > 2.21.0 > >
diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c index a8c38cc118..c91f18415c 100644 --- a/hw/timer/aspeed_timer.c +++ b/hw/timer/aspeed_timer.c @@ -283,7 +283,7 @@ static void aspeed_timer_set_value(AspeedTimerCtrlState *s, int timer, int reg, if (old_reload || !t->reload) { break; } - + /* fall through to re-enable */ case TIMER_REG_STATUS: if (timer_enabled(t)) { uint64_t now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: hw/timer/aspeed_timer.c: In function ‘aspeed_timer_set_value’: hw/timer/aspeed_timer.c:283:24: error: this statement may fall through [-Werror=implicit-fallthrough=] 283 | if (old_reload || !t->reload) { | ~~~~~~~~~~~^~~~~~~~~~~~~ hw/timer/aspeed_timer.c:287:5: note: here 287 | case TIMER_REG_STATUS: | ^~~~ cc1: all warnings being treated as errors Add the missing fall through comment. Fixes: 1403f364472 Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- Cc: "Cédric Le Goater" <clg@kaod.org> Cc: Peter Maydell <peter.maydell@linaro.org> Cc: Andrew Jeffery <andrew@aj.id.au> Cc: Joel Stanley <joel@jms.id.au> Cc: qemu-arm@nongnu.org --- hw/timer/aspeed_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)