From patchwork Fri Jan 10 09:17:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pan Nengyuan X-Patchwork-Id: 11326907 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 09B7392A for ; Fri, 10 Jan 2020 09:19:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85E412072E for ; Fri, 10 Jan 2020 09:19:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85E412072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:42848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipqSC-0003Zl-Fk for patchwork-qemu-devel@patchwork.kernel.org; Fri, 10 Jan 2020 04:19:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33435) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipqR5-00029P-Kl for qemu-devel@nongnu.org; Fri, 10 Jan 2020 04:18:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipqR4-0004uE-J9 for qemu-devel@nongnu.org; Fri, 10 Jan 2020 04:18:31 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:58486 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ipqR4-0004dX-8F; Fri, 10 Jan 2020 04:18:30 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 1AE58F276BC218B7B793; Fri, 10 Jan 2020 17:18:26 +0800 (CST) Received: from DESKTOP-9NTIQGG.china.huawei.com (10.173.221.136) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Fri, 10 Jan 2020 17:18:16 +0800 From: To: , Subject: [PATCH v2 2/2] qga/main: Don't mismatch g_strsplit/g_free in split_list() Date: Fri, 10 Jan 2020 17:17:10 +0800 Message-ID: <20200110091710.53424-3-pannengyuan@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200110091710.53424-1-pannengyuan@huawei.com> References: <20200110091710.53424-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.173.221.136] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Laurent Vivier , Pan Nengyuan , qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Pan Nengyuan fix a mismatch between g_strsplit and g_free Reported-by: Laurent Vivier Signed-off-by: Pan Nengyuan --- Changes v2 to v1: - fix a mismatch in qga/main.c --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index c35c2a2120..a72ae074f4 100644 --- a/qga/main.c +++ b/qga/main.c @@ -933,7 +933,7 @@ static GList *split_list(const gchar *str, const gchar *delim) for (i = 0; strv[i]; i++) { list = g_list_prepend(list, strv[i]); } - g_free(strv); + g_strfreev(strv); return list; }