From patchwork Wed Jan 22 06:50:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 11345095 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6AE4F92A for ; Wed, 22 Jan 2020 07:01:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F21052465B for ; Wed, 22 Jan 2020 07:01:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JFIRUMLu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F21052465B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:37704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuA1E-0002r1-G0 for patchwork-qemu-devel@patchwork.kernel.org; Wed, 22 Jan 2020 02:01:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36246) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iu9qh-00058d-Rd for qemu-devel@nongnu.org; Wed, 22 Jan 2020 01:50:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iu9qg-0008HW-6W for qemu-devel@nongnu.org; Wed, 22 Jan 2020 01:50:47 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:32816 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iu9qg-0008HB-1j for qemu-devel@nongnu.org; Wed, 22 Jan 2020 01:50:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579675845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ggBqUw/TkyscUgLTaAI+ToeLG/4Kdqwt2Kyfz0gAqcA=; b=JFIRUMLuHgXQjNQqi2RLP+wqqAtCbPuwY3sMZvv4iPbj7SE1JWOlVMWY29Hz7JU61jxNJ2 W0Wb/AXc/dAfJNfR75EDvK/+ay0jNu1GyLn+Aergfy8rQb+Onc79LyfHZnKc3goItK1IJO tMCw5oJvBNKT/X+N/sT1t5SYdZvdttE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-i5u61N1JOLGpp2LO0UPt9g-1; Wed, 22 Jan 2020 01:50:41 -0500 Received: by mail-wr1-f71.google.com with SMTP id b13so2570027wrx.22 for ; Tue, 21 Jan 2020 22:50:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cGSuN6h1x+S1blKGljaTMghfpV/GT8UXotLBiV9qbUk=; b=fhztdxq54s1jH3IlUlcyd2yP4wFcBmmJnxujJuEzrJqmS9LFXKUcyC6ilH9Rh1DpvH hCy83pGEUM6IIYFU11gjr3X0PuIjzgVxaUV1WhZKNle5xjKE3FfaXXW3Lr2A1f49CBQl 2VFpFqCoeI7jm3OoVwHp7SHmGltFvoiJsZFE8lO3NzJ8myE8EEEdyvuZ15LqMz8Q+0+w imp2XFBr5nxjxN8n/VJDrtPKn6JPxxoxXJMDiodTd/gFBZeuVYT90yWV9LpoEGXYTo4H XKYEjhcTKHNl6AMtSQ3cy+Jfu4OX5hNrm4J+MjAjoHi3kOZosKNC1ml0ycmb0EjyNEL0 OeaA== X-Gm-Message-State: APjAAAU2dggv0z/yq85I0ltLP+Ujw1la2CmWkKSuKpE4ZDPgT8qz8gl2 6xQ57k5T+sZ2WxySlCdpBHE2eXEx6tvblC0jUterQ6cbbDlsY3/3ndnx7dIDY9l3Q4slDv2iFoh RcWAytxCoXynfHOw= X-Received: by 2002:a1c:1b15:: with SMTP id b21mr1151390wmb.17.1579675840075; Tue, 21 Jan 2020 22:50:40 -0800 (PST) X-Google-Smtp-Source: APXvYqxds0R5O4f5SzRAs4/PJ10l/GHzq4vo2bxr459ykGSQ9MyvA6HtCqK0xyB1yCYJQmo3cFpkPA== X-Received: by 2002:a1c:1b15:: with SMTP id b21mr1151363wmb.17.1579675839842; Tue, 21 Jan 2020 22:50:39 -0800 (PST) Received: from redhat.com (bzq-79-176-0-156.red.bezeqint.net. [79.176.0.156]) by smtp.gmail.com with ESMTPSA id w17sm55807017wrt.89.2020.01.21.22.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 22:50:39 -0800 (PST) Date: Wed, 22 Jan 2020 01:50:37 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v2 17/17] i386:acpi: Remove _HID from the SMBus ACPI entry Message-ID: <20200122064907.512501-18-mst@redhat.com> References: <20200122064907.512501-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200122064907.512501-1-mst@redhat.com> X-Mailer: git-send-email 2.24.1.751.gd10ce2899c X-Mutt-Fcc: =sent X-MC-Unique: i5u61N1JOLGpp2LO0UPt9g-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Corey Minyard , Paolo Bonzini , Igor Mammedov , Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard Per the ACPI spec (version 6.1, section 6.1.5 _HID) it is not required on enumerated buses (like PCI in this case), _ADR is required (and is already there). And the _HID value is wrong. Linux appears to ignore the _HID entry, but Windows 10 detects it as 'Unknown Device' and there is no driver available. See https://bugs.launchpad.net/qemu/+bug/1856724 Signed-off-by: Corey Minyard Cc: Michael S. Tsirkin Cc: Igor Mammedov Reviewed-by: Igor Mammedov Message-Id: <20200120170725.24935-6-minyard@acm.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 1 - tests/data/acpi/q35/DSDT | Bin 7879 -> 7869 bytes tests/data/acpi/q35/DSDT.acpihmat | Bin 9203 -> 9193 bytes tests/data/acpi/q35/DSDT.bridge | Bin 7896 -> 7886 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8342 -> 8332 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9532 -> 9522 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 7954 -> 7944 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9238 -> 9228 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 9009 -> 8999 bytes tests/data/acpi/q35/DSDT.numamem | Bin 7885 -> 7875 bytes 10 files changed, 1 deletion(-) diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT index 77ea60ffed421c566138fe6341421f579129a582..1f91888d7a485850cf27f152e247a90b208003dc 100644 GIT binary patch delta 42 xcmX?ZyVsV>CDe&h`+ diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm index 23fdf5e60a5069f60d6c680ac9c68c4a8a81318e..02ccdd5f38d5b2356dcca89398c41dcf2595dfff 100644 GIT binary patch delta 42 xcmdnvwaJUiCDv8151UVN}qe1Nm3L39&;u&FFx2QKET=2Ai9Y^*w@Km^J2+-Rsi7S3kU!J delta 52 zcmeCMn`Fo366_KpB+tOWxOgL1ouss?UVN}qe1Nm3L3ER3u&>&QD-BUv81%BUVN}qe1Nm3L3ER3u&