diff mbox series

[1/5] bios-tables-test: tell people how to update

Message ID 20200122080538.591734-2-mst@redhat.com (mailing list archive)
State New, archived
Headers show
Series bios-tables-test: more documentation | expand

Commit Message

Michael S. Tsirkin Jan. 22, 2020, 8:05 a.m. UTC
For now just a pointer to the source file.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 tests/qtest/bios-tables-test.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Laurent Vivier Jan. 22, 2020, 8:25 a.m. UTC | #1
On 22/01/2020 09:05, Michael S. Tsirkin wrote:
> For now just a pointer to the source file.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  tests/qtest/bios-tables-test.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 3ab4872bd7..6b5f24bf62 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -426,7 +426,9 @@ static void test_acpi_asl(test_data *data)
>  
>          fprintf(stderr,
>                  "acpi-test: Warning! %.4s binary file mismatch. "
> -                "Actual [aml:%s], Expected [aml:%s].\n",
> +                "Actual [aml:%s], Expected [aml:%s].\n"
> +                "See source file tests/qtest/bios-tables-test.c "
> +                "for instructions on how to update expected files.\n",
>                  exp_sdt->aml, sdt->aml_file, exp_sdt->aml_file);
>  
>          all_tables_match = all_tables_match &&
> 

Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Thomas Huth Jan. 22, 2020, 9:17 a.m. UTC | #2
On 22/01/2020 09.05, Michael S. Tsirkin wrote:
> For now just a pointer to the source file.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  tests/qtest/bios-tables-test.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 3ab4872bd7..6b5f24bf62 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -426,7 +426,9 @@ static void test_acpi_asl(test_data *data)
>  
>          fprintf(stderr,
>                  "acpi-test: Warning! %.4s binary file mismatch. "
> -                "Actual [aml:%s], Expected [aml:%s].\n",
> +                "Actual [aml:%s], Expected [aml:%s].\n"
> +                "See source file tests/qtest/bios-tables-test.c "
> +                "for instructions on how to update expected files.\n",
>                  exp_sdt->aml, sdt->aml_file, exp_sdt->aml_file);
>  
>          all_tables_match = all_tables_match &&
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 3ab4872bd7..6b5f24bf62 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -426,7 +426,9 @@  static void test_acpi_asl(test_data *data)
 
         fprintf(stderr,
                 "acpi-test: Warning! %.4s binary file mismatch. "
-                "Actual [aml:%s], Expected [aml:%s].\n",
+                "Actual [aml:%s], Expected [aml:%s].\n"
+                "See source file tests/qtest/bios-tables-test.c "
+                "for instructions on how to update expected files.\n",
                 exp_sdt->aml, sdt->aml_file, exp_sdt->aml_file);
 
         all_tables_match = all_tables_match &&