Message ID | 20200123070913.626488-1-mst@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Patchew URL: https://patchew.org/QEMU/20200123070913.626488-1-mst@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200123070913.626488-1-mst@redhat.com Subject: [PULL v3 00/18] virtio, pc: fixes, features === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 2b8191c vhost: coding style fix 7bb1f74 i386:acpi: Remove _HID from the SMBus ACPI entry 5d5ae0b vhost: Only align sections for vhost-user 2fe690d vhost: Add names to section rounded warning 85f2aa9 vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks ae724d7 virtio-scsi: convert to new virtio_delete_queue 32a8d7a virtio-scsi: delete vqs in unrealize to avoid memleaks ce15ad4 virtio-9p-device: convert to new virtio_delete_queue 3bdf076 virtio-9p-device: fix memleak in virtio_9p_device_unrealize 01fb3bc bios-tables-test: document expected file update 021497c acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command 8df7461 acpi: cpuhp: spec: add typical usecases f37ff6b acpi: cpuhp: introduce 'Command data 2' field 9c2e2a3 acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0 31632fb acpi: cpuhp: spec: fix 'Command data' description 8833b70 acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness 59529c2 tests: q35: MCH: add default SMBASE SMRAM lock test ab4ab8f q35: implement 128K SMRAM at default SMBASE address === OUTPUT BEGIN === 1/18 Checking commit ab4ab8fed8c2 (q35: implement 128K SMRAM at default SMBASE address) 2/18 Checking commit 59529c21dc20 (tests: q35: MCH: add default SMBASE SMRAM lock test) 3/18 Checking commit 8833b70f38a3 (acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness) 4/18 Checking commit 31632fb04976 (acpi: cpuhp: spec: fix 'Command data' description) 5/18 Checking commit 9c2e2a3c55cf (acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0) 6/18 Checking commit f37ff6b0328f (acpi: cpuhp: introduce 'Command data 2' field) 7/18 Checking commit 8df7461f8e9c (acpi: cpuhp: spec: add typical usecases) 8/18 Checking commit 021497cfae81 (acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command) 9/18 Checking commit 01fb3bc40a44 (bios-tables-test: document expected file update) WARNING: line over 80 characters #23: FILE: tests/qtest/bios-tables-test.c:20: + * Contributor or ACPI Maintainer (steps 4-7 need to be redone to resolve conflicts total: 0 errors, 1 warnings, 38 lines checked Patch 9/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/18 Checking commit 3bdf076c6da1 (virtio-9p-device: fix memleak in virtio_9p_device_unrealize) 11/18 Checking commit ce15ad428cde (virtio-9p-device: convert to new virtio_delete_queue) 12/18 Checking commit 32a8d7a0b553 (virtio-scsi: delete vqs in unrealize to avoid memleaks) 13/18 Checking commit ae724d76b8ed (virtio-scsi: convert to new virtio_delete_queue) 14/18 Checking commit 85f2aa9f8aa0 (vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks) 15/18 Checking commit 2fe690da39c7 (vhost: Add names to section rounded warning) 16/18 Checking commit 5d5ae0b9e061 (vhost: Only align sections for vhost-user) ERROR: trailing whitespace #49: FILE: hw/virtio/vhost.c:554: + if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) { $ WARNING: line over 80 characters #64: FILE: hw/virtio/vhost.c:569: + trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size, total: 1 errors, 1 warnings, 43 lines checked Patch 16/18 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/18 Checking commit 7bb1f74b40e9 (i386:acpi: Remove _HID from the SMBus ACPI entry) 18/18 Checking commit 2b8191c490a6 (vhost: coding style fix) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200123070913.626488-1-mst@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Wed, Jan 22, 2020 at 11:45:33PM -0800, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20200123070913.626488-1-mst@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. yes but they are fixed by a follow up patch :) > See output below for > more information: > > Type: series > Message-id: 20200123070913.626488-1-mst@redhat.com > Subject: [PULL v3 00/18] virtio, pc: fixes, features > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Switched to a new branch 'test' > 2b8191c vhost: coding style fix > 7bb1f74 i386:acpi: Remove _HID from the SMBus ACPI entry > 5d5ae0b vhost: Only align sections for vhost-user > 2fe690d vhost: Add names to section rounded warning > 85f2aa9 vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks > ae724d7 virtio-scsi: convert to new virtio_delete_queue > 32a8d7a virtio-scsi: delete vqs in unrealize to avoid memleaks > ce15ad4 virtio-9p-device: convert to new virtio_delete_queue > 3bdf076 virtio-9p-device: fix memleak in virtio_9p_device_unrealize > 01fb3bc bios-tables-test: document expected file update > 021497c acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command > 8df7461 acpi: cpuhp: spec: add typical usecases > f37ff6b acpi: cpuhp: introduce 'Command data 2' field > 9c2e2a3 acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0 > 31632fb acpi: cpuhp: spec: fix 'Command data' description > 8833b70 acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness > 59529c2 tests: q35: MCH: add default SMBASE SMRAM lock test > ab4ab8f q35: implement 128K SMRAM at default SMBASE address > > === OUTPUT BEGIN === > 1/18 Checking commit ab4ab8fed8c2 (q35: implement 128K SMRAM at default SMBASE address) > 2/18 Checking commit 59529c21dc20 (tests: q35: MCH: add default SMBASE SMRAM lock test) > 3/18 Checking commit 8833b70f38a3 (acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness) > 4/18 Checking commit 31632fb04976 (acpi: cpuhp: spec: fix 'Command data' description) > 5/18 Checking commit 9c2e2a3c55cf (acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0) > 6/18 Checking commit f37ff6b0328f (acpi: cpuhp: introduce 'Command data 2' field) > 7/18 Checking commit 8df7461f8e9c (acpi: cpuhp: spec: add typical usecases) > 8/18 Checking commit 021497cfae81 (acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command) > 9/18 Checking commit 01fb3bc40a44 (bios-tables-test: document expected file update) > WARNING: line over 80 characters > #23: FILE: tests/qtest/bios-tables-test.c:20: > + * Contributor or ACPI Maintainer (steps 4-7 need to be redone to resolve conflicts > > total: 0 errors, 1 warnings, 38 lines checked > > Patch 9/18 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 10/18 Checking commit 3bdf076c6da1 (virtio-9p-device: fix memleak in virtio_9p_device_unrealize) > 11/18 Checking commit ce15ad428cde (virtio-9p-device: convert to new virtio_delete_queue) > 12/18 Checking commit 32a8d7a0b553 (virtio-scsi: delete vqs in unrealize to avoid memleaks) > 13/18 Checking commit ae724d76b8ed (virtio-scsi: convert to new virtio_delete_queue) > 14/18 Checking commit 85f2aa9f8aa0 (vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks) > 15/18 Checking commit 2fe690da39c7 (vhost: Add names to section rounded warning) > 16/18 Checking commit 5d5ae0b9e061 (vhost: Only align sections for vhost-user) > ERROR: trailing whitespace > #49: FILE: hw/virtio/vhost.c:554: > + if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) { $ > > WARNING: line over 80 characters > #64: FILE: hw/virtio/vhost.c:569: > + trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, mrs_size, > > total: 1 errors, 1 warnings, 43 lines checked > > Patch 16/18 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 17/18 Checking commit 7bb1f74b40e9 (i386:acpi: Remove _HID from the SMBus ACPI entry) > 18/18 Checking commit 2b8191c490a6 (vhost: coding style fix) > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/20200123070913.626488-1-mst@redhat.com/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com
On Thu, 23 Jan 2020 at 07:10, Michael S. Tsirkin <mst@redhat.com> wrote: > > Changes from v2: > - add a coding style fix > Changes from v1: > - add a missing expected file > > > The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: > > Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +0000) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > for you to fetch changes up to 8347505640238d3b80f9bb7510fdc1bb574bad19: > > vhost: coding style fix (2020-01-23 02:08:15 -0500) > > ---------------------------------------------------------------- > virtio, pc: fixes, features > > Bugfixes all over the place. > CPU hotplug with secureboot. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Judging by the commit hash I think what actually got applied was this v3. thanks -- PMM
Changes from v2: - add a coding style fix Changes from v1: - add a missing expected file The following changes since commit 3e08b2b9cb64bff2b73fa9128c0e49bfcde0dd40: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/edk2-next-20200121' into staging (2020-01-21 15:29:25 +0000) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 8347505640238d3b80f9bb7510fdc1bb574bad19: vhost: coding style fix (2020-01-23 02:08:15 -0500) ---------------------------------------------------------------- virtio, pc: fixes, features Bugfixes all over the place. CPU hotplug with secureboot. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> ---------------------------------------------------------------- Corey Minyard (1): i386:acpi: Remove _HID from the SMBus ACPI entry Dr. David Alan Gilbert (2): vhost: Add names to section rounded warning vhost: Only align sections for vhost-user Igor Mammedov (8): q35: implement 128K SMRAM at default SMBASE address tests: q35: MCH: add default SMBASE SMRAM lock test acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness acpi: cpuhp: spec: fix 'Command data' description acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0 acpi: cpuhp: introduce 'Command data 2' field acpi: cpuhp: spec: add typical usecases acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command Michael S. Tsirkin (2): bios-tables-test: document expected file update vhost: coding style fix Pan Nengyuan (5): virtio-9p-device: fix memleak in virtio_9p_device_unrealize virtio-9p-device: convert to new virtio_delete_queue virtio-scsi: delete vqs in unrealize to avoid memleaks virtio-scsi: convert to new virtio_delete_queue vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks docs/specs/acpi_cpu_hotplug.txt | 89 ++++++++++++++++++++++++++------ include/hw/pci-host/q35.h | 10 ++++ include/hw/virtio/vhost-vsock.h | 2 + hw/9pfs/virtio-9p-device.c | 1 + hw/acpi/cpu.c | 18 +++++++ hw/i386/acpi-build.c | 1 - hw/i386/pc.c | 4 +- hw/pci-host/q35.c | 84 +++++++++++++++++++++++++++--- hw/scsi/virtio-scsi.c | 6 +++ hw/virtio/vhost-vsock.c | 12 ++++- hw/virtio/vhost.c | 39 +++++++------- tests/qtest/bios-tables-test.c | 23 +++++++-- tests/qtest/q35-test.c | 105 ++++++++++++++++++++++++++++++++++++++ hw/acpi/trace-events | 1 + tests/data/acpi/q35/DSDT | Bin 7879 -> 7869 bytes tests/data/acpi/q35/DSDT.acpihmat | Bin 9203 -> 9193 bytes tests/data/acpi/q35/DSDT.bridge | Bin 7896 -> 7886 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8342 -> 8332 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9532 -> 9522 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 7954 -> 7944 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9238 -> 9228 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 9009 -> 8999 bytes tests/data/acpi/q35/DSDT.numamem | Bin 7885 -> 7875 bytes 23 files changed, 344 insertions(+), 51 deletions(-)