| Message ID | 20200129115655.10414-3-quintela@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Multifd Migration Compression | expand |
* Juan Quintela (quintela@redhat.com) wrote: > So we don't have to compile everything in, or have ifdefs > > Signed-off-by: Juan Quintela <quintela@redhat.com> As far as I can tell this matches the way all the rest of the module stuff works, so: Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> (Although I wish it was documented somewhere). Dave > --- > include/qemu/module.h | 2 ++ > vl.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/include/qemu/module.h b/include/qemu/module.h > index 65ba596e46..907cb5c0a5 100644 > --- a/include/qemu/module.h > +++ b/include/qemu/module.h > @@ -40,6 +40,7 @@ static void __attribute__((constructor)) do_qemu_init_ ## function(void) \ > #endif > > typedef enum { > + MODULE_INIT_MIGRATION, > MODULE_INIT_BLOCK, > MODULE_INIT_OPTS, > MODULE_INIT_QOM, > @@ -56,6 +57,7 @@ typedef enum { > #define xen_backend_init(function) module_init(function, \ > MODULE_INIT_XEN_BACKEND) > #define libqos_init(function) module_init(function, MODULE_INIT_LIBQOS) > +#define migration_init(function) module_init(function, MODULE_INIT_MIGRATION) > > #define block_module_load_one(lib) module_load_one("block-", lib) > #define ui_module_load_one(lib) module_load_one("ui-", lib) > diff --git a/vl.c b/vl.c > index b0f52c4d6e..9f8577955a 100644 > --- a/vl.c > +++ b/vl.c > @@ -2890,6 +2890,7 @@ int main(int argc, char **argv, char **envp) > qemu_init_exec_dir(argv[0]); > > module_call_init(MODULE_INIT_QOM); > + module_call_init(MODULE_INIT_MIGRATION); > > qemu_add_opts(&qemu_drive_opts); > qemu_add_drive_opts(&qemu_legacy_drive_opts); > -- > 2.24.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote: > * Juan Quintela (quintela@redhat.com) wrote: >> So we don't have to compile everything in, or have ifdefs >> >> Signed-off-by: Juan Quintela <quintela@redhat.com> > > As far as I can tell this matches the way all the rest of the module > stuff works, so: > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Thanks > (Although I wish it was documented somewhere). I had to learn to use it with grep :-p
diff --git a/include/qemu/module.h b/include/qemu/module.h index 65ba596e46..907cb5c0a5 100644 --- a/include/qemu/module.h +++ b/include/qemu/module.h @@ -40,6 +40,7 @@ static void __attribute__((constructor)) do_qemu_init_ ## function(void) \ #endif typedef enum { + MODULE_INIT_MIGRATION, MODULE_INIT_BLOCK, MODULE_INIT_OPTS, MODULE_INIT_QOM, @@ -56,6 +57,7 @@ typedef enum { #define xen_backend_init(function) module_init(function, \ MODULE_INIT_XEN_BACKEND) #define libqos_init(function) module_init(function, MODULE_INIT_LIBQOS) +#define migration_init(function) module_init(function, MODULE_INIT_MIGRATION) #define block_module_load_one(lib) module_load_one("block-", lib) #define ui_module_load_one(lib) module_load_one("ui-", lib) diff --git a/vl.c b/vl.c index b0f52c4d6e..9f8577955a 100644 --- a/vl.c +++ b/vl.c @@ -2890,6 +2890,7 @@ int main(int argc, char **argv, char **envp) qemu_init_exec_dir(argv[0]); module_call_init(MODULE_INIT_QOM); + module_call_init(MODULE_INIT_MIGRATION); qemu_add_opts(&qemu_drive_opts); qemu_add_drive_opts(&qemu_legacy_drive_opts);
So we don't have to compile everything in, or have ifdefs Signed-off-by: Juan Quintela <quintela@redhat.com> --- include/qemu/module.h | 2 ++ vl.c | 1 + 2 files changed, 3 insertions(+)