From patchwork Fri Jan 31 06:09:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Gibson X-Patchwork-Id: 11359401 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1C964188B for ; Fri, 31 Jan 2020 06:27:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E71BA20663 for ; Fri, 31 Jan 2020 06:27:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="hzgRbvxF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E71BA20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:49004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixPlv-0004c6-4E for patchwork-qemu-devel@patchwork.kernel.org; Fri, 31 Jan 2020 01:27:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59933) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixPVc-0008QH-L4 for qemu-devel@nongnu.org; Fri, 31 Jan 2020 01:10:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixPVb-0001XT-LP for qemu-devel@nongnu.org; Fri, 31 Jan 2020 01:10:28 -0500 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:56307 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ixPVb-00010G-A6; Fri, 31 Jan 2020 01:10:27 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4886Hx6ySwz9sT2; Fri, 31 Jan 2020 17:09:33 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1580450973; bh=GTRX/VXafls1IkkTyR5sNPeyfSuUBHNUp5JrIKViYwc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hzgRbvxFsbfjGWOiTo7gVKZoMla1TyqOsl6qlzrjzMRkglgMbBkcJRDw1K7hxMy6C e82wodFDQBLwKWdgV9k9fLfoTTZ8PIxNKliB9Uucenr5dPdwzWJFS5KSpJJSGDVe7n BzBEHDS2jTT94pZaHoDfCr3AgoH5qpXip4mgejTA= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 33/34] target/ppc: Remove redundant mask in DCBZ Date: Fri, 31 Jan 2020 17:09:23 +1100 Message-Id: <20200131060924.147449-34-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200131060924.147449-1-david@gibson.dropbear.id.au> References: <20200131060924.147449-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, Richard Henderson , qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, Howard Spoelstra , David Gibson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson The value of addr has already been masked, just above. Signed-off-by: Richard Henderson Message-Id: <20200129235040.24022-4-richard.henderson@linaro.org> Tested-by: Howard Spoelstra Signed-off-by: David Gibson --- target/ppc/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index e7d3a79d96..0cb78777e7 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -293,7 +293,7 @@ static void dcbz_common(CPUPPCState *env, target_ulong addr, addr &= mask; /* Check reservation */ - if ((env->reserve_addr & mask) == (addr & mask)) { + if ((env->reserve_addr & mask) == addr) { env->reserve_addr = (target_ulong)-1ULL; }