| Message ID | 20200206225148.23923-1-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] docs/arm-cpu-features: Make kvm-no-adjvtime comment clearer | expand |
On Thu, Feb 06, 2020 at 11:51:48PM +0100, Philippe Mathieu-Daudé wrote: > The bold text sounds like 'knock knock'. Only bolding the Who's there? > second 'not' makes it easier to read. > > Fixes: dea101a1ae > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > v2: Removed unrelated hunk > --- > docs/arm-cpu-features.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/arm-cpu-features.rst b/docs/arm-cpu-features.rst > index dbf3b7cf42..fc1623aeca 100644 > --- a/docs/arm-cpu-features.rst > +++ b/docs/arm-cpu-features.rst > @@ -185,7 +185,7 @@ the list of KVM VCPU features and their descriptions. > > kvm-no-adjvtime By default kvm-no-adjvtime is disabled. This > means that by default the virtual time > - adjustment is enabled (vtime is *not not* > + adjustment is enabled (vtime is not *not* > adjusted). > > When virtual time adjustment is enabled each > -- > 2.21.1 > > Not-Not-Reviewed-by: Andrew Jones <drjones@redhat.com>
On Fri, 7 Feb 2020 at 08:26, Andrew Jones <drjones@redhat.com> wrote: > > On Thu, Feb 06, 2020 at 11:51:48PM +0100, Philippe Mathieu-Daudé wrote: > > The bold text sounds like 'knock knock'. Only bolding the > > Who's there? > > > second 'not' makes it easier to read. > > > > Fixes: dea101a1ae > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > --- > > v2: Removed unrelated hunk > > --- > > docs/arm-cpu-features.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/docs/arm-cpu-features.rst b/docs/arm-cpu-features.rst > > index dbf3b7cf42..fc1623aeca 100644 > > --- a/docs/arm-cpu-features.rst > > +++ b/docs/arm-cpu-features.rst > > @@ -185,7 +185,7 @@ the list of KVM VCPU features and their descriptions. > > > > kvm-no-adjvtime By default kvm-no-adjvtime is disabled. This > > means that by default the virtual time > > - adjustment is enabled (vtime is *not not* > > + adjustment is enabled (vtime is not *not* > > adjusted). > > > > When virtual time adjustment is enabled each > > -- > > 2.21.1 > > Applied to target-arm.next. > Not-Not-Reviewed-by: Andrew Jones <drjones@redhat.com> :-) but for the purpose of the commit message I've dropped the 'Not-Not-' prefix, since we want to have a standard set of tags in commit message rather than a random accumulation. (We really should make checkpatch warn about nonstandard tags.) thanks -- PMM
diff --git a/docs/arm-cpu-features.rst b/docs/arm-cpu-features.rst index dbf3b7cf42..fc1623aeca 100644 --- a/docs/arm-cpu-features.rst +++ b/docs/arm-cpu-features.rst @@ -185,7 +185,7 @@ the list of KVM VCPU features and their descriptions. kvm-no-adjvtime By default kvm-no-adjvtime is disabled. This means that by default the virtual time - adjustment is enabled (vtime is *not not* + adjustment is enabled (vtime is not *not* adjusted). When virtual time adjustment is enabled each
The bold text sounds like 'knock knock'. Only bolding the second 'not' makes it easier to read. Fixes: dea101a1ae Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- v2: Removed unrelated hunk --- docs/arm-cpu-features.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)