| Message ID | 20200218094402.26625-2-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | trivial: Detect and remove superfluous semicolons in C code | expand |
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote: > Display error when a commit contains superfluous semicolon: > > $ git show 6663a0a3376 | scripts/checkpatch.pl -q - > ERROR: superfluous trailing semicolon > #276: FILE: block/io_uring.c:186: > + ret = -ENOSPC;; > total: 1 errors, 1 warnings, 485 lines checked > > Reported-by: Luc Michel <luc.michel@greensocs.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- > Cc: Paolo Bonzini <pbonzini@redhat.com> > --- > scripts/checkpatch.pl | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index ce43a306f8..11512a8a09 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1830,6 +1830,11 @@ sub process { > ERROR("suspicious ; after while (0)\n" . $herecurr); > } > > +# Check superfluous trailing ';' > + if ($line =~ /;;$/) { > + ERROR("superfluous trailing semicolon\n" . $herecurr); > + } > + > # Check relative indent for conditionals and blocks. > if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) { > my ($s, $c) = ($stat, $cond); > -- > 2.21.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > Display error when a commit contains superfluous semicolon: > > $ git show 6663a0a3376 | scripts/checkpatch.pl -q - > ERROR: superfluous trailing semicolon > #276: FILE: block/io_uring.c:186: > + ret = -ENOSPC;; > total: 1 errors, 1 warnings, 485 lines checked > > Reported-by: Luc Michel <luc.michel@greensocs.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com>
On 2/18/20 10:43 AM, Philippe Mathieu-Daudé wrote: > Display error when a commit contains superfluous semicolon: > > $ git show 6663a0a3376 | scripts/checkpatch.pl -q - > ERROR: superfluous trailing semicolon > #276: FILE: block/io_uring.c:186: > + ret = -ENOSPC;; > total: 1 errors, 1 warnings, 485 lines checked > > Reported-by: Luc Michel <luc.michel@greensocs.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Luc Michel <luc.michel@greensocs.com> > --- > Cc: Paolo Bonzini <pbonzini@redhat.com> > --- > scripts/checkpatch.pl | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index ce43a306f8..11512a8a09 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1830,6 +1830,11 @@ sub process { > ERROR("suspicious ; after while (0)\n" . $herecurr); > } > > +# Check superfluous trailing ';' > + if ($line =~ /;;$/) { > + ERROR("superfluous trailing semicolon\n" . $herecurr); > + } > + > # Check relative indent for conditionals and blocks. > if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) { > my ($s, $c) = ($stat, $cond); >
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index ce43a306f8..11512a8a09 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1830,6 +1830,11 @@ sub process { ERROR("suspicious ; after while (0)\n" . $herecurr); } +# Check superfluous trailing ';' + if ($line =~ /;;$/) { + ERROR("superfluous trailing semicolon\n" . $herecurr); + } + # Check relative indent for conditionals and blocks. if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) { my ($s, $c) = ($stat, $cond);
Display error when a commit contains superfluous semicolon: $ git show 6663a0a3376 | scripts/checkpatch.pl -q - ERROR: superfluous trailing semicolon #276: FILE: block/io_uring.c:186: + ret = -ENOSPC;; total: 1 errors, 1 warnings, 485 lines checked Reported-by: Luc Michel <luc.michel@greensocs.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- Cc: Paolo Bonzini <pbonzini@redhat.com> --- scripts/checkpatch.pl | 5 +++++ 1 file changed, 5 insertions(+)