diff mbox series

[1/2] fuzz: fix typos in linker-script comments

Message ID 20200227024856.23777-2-alxndr@bu.edu (mailing list archive)
State New, archived
Headers show
Series Fix spelling/formatting in fuzzing patches | expand

Commit Message

Alexander Bulekov Feb. 27, 2020, 2:48 a.m. UTC
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
 tests/qtest/fuzz/fork_fuzz.ld | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Eric Blake Feb. 27, 2020, 2:55 a.m. UTC | #1
On 2/26/20 8:48 PM, Alexander Bulekov wrote:
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
>   tests/qtest/fuzz/fork_fuzz.ld | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/qtest/fuzz/fork_fuzz.ld b/tests/qtest/fuzz/fork_fuzz.ld
> index b23a59f194..b5aad06f20 100644
> --- a/tests/qtest/fuzz/fork_fuzz.ld
> +++ b/tests/qtest/fuzz/fork_fuzz.ld
> @@ -1,5 +1,5 @@
>   /* We adjust linker script modification to place all of the stuff that needs to
> - * persist across fuzzing runs into a contiguous seciton of memory. Then, it is
> + * persist across fuzzing runs into a contiguous section of memory. Then, it is
>    * easy to re-map the counter-related memory as shared.
>   */
>   
> @@ -32,6 +32,6 @@ SECTIONS
>         __FUZZ_COUNTERS_END = .;
>     }
>   }
> -/* Dont overwrite the SECTIONS in the default linker script. Instead insert the
> +/* Don't overwrite the SECTIONS in the default linker script. Instead insert the
>    * above into the default script */

As long as you're touching these two comments, checkpatch is going to 
complain that they don't follow the usual style of:

/*
  * Text starts here...
  * through here.
  */

If you fix that as well for these two comments,
Reviewed-by: Eric Blake <eblake@redhat.com>
Alexander Bulekov Feb. 27, 2020, 3:09 a.m. UTC | #2
On 200226 2055, Eric Blake wrote:
> On 2/26/20 8:48 PM, Alexander Bulekov wrote:
> > Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> > ---
> >   tests/qtest/fuzz/fork_fuzz.ld | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/qtest/fuzz/fork_fuzz.ld b/tests/qtest/fuzz/fork_fuzz.ld
> > index b23a59f194..b5aad06f20 100644
> > --- a/tests/qtest/fuzz/fork_fuzz.ld
> > +++ b/tests/qtest/fuzz/fork_fuzz.ld
> > @@ -1,5 +1,5 @@
> >   /* We adjust linker script modification to place all of the stuff that needs to
> > - * persist across fuzzing runs into a contiguous seciton of memory. Then, it is
> > + * persist across fuzzing runs into a contiguous section of memory. Then, it is
> >    * easy to re-map the counter-related memory as shared.
> >   */
> > @@ -32,6 +32,6 @@ SECTIONS
> >         __FUZZ_COUNTERS_END = .;
> >     }
> >   }
> > -/* Dont overwrite the SECTIONS in the default linker script. Instead insert the
> > +/* Don't overwrite the SECTIONS in the default linker script. Instead insert the
> >    * above into the default script */
> 
> As long as you're touching these two comments, checkpatch is going to
> complain that they don't follow the usual style of:
> 
> /*
>  * Text starts here...
>  * through here.
>  */
> 
> If you fix that as well for these two comments,
> Reviewed-by: Eric Blake <eblake@redhat.com> 

Must have missed it since the file has a .ld extension.
Thanks!
-Alex

> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
>
diff mbox series

Patch

diff --git a/tests/qtest/fuzz/fork_fuzz.ld b/tests/qtest/fuzz/fork_fuzz.ld
index b23a59f194..b5aad06f20 100644
--- a/tests/qtest/fuzz/fork_fuzz.ld
+++ b/tests/qtest/fuzz/fork_fuzz.ld
@@ -1,5 +1,5 @@ 
 /* We adjust linker script modification to place all of the stuff that needs to
- * persist across fuzzing runs into a contiguous seciton of memory. Then, it is
+ * persist across fuzzing runs into a contiguous section of memory. Then, it is
  * easy to re-map the counter-related memory as shared.
 */
 
@@ -32,6 +32,6 @@  SECTIONS
       __FUZZ_COUNTERS_END = .;
   }
 }
-/* Dont overwrite the SECTIONS in the default linker script. Instead insert the
+/* Don't overwrite the SECTIONS in the default linker script. Instead insert the
  * above into the default script */
 INSERT AFTER .data;