From patchwork Thu Feb 27 10:06:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11408213 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AB9CB13A4 for ; Thu, 27 Feb 2020 10:08:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 825F824670 for ; Thu, 27 Feb 2020 10:08:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H4z1iUtc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 825F824670 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:56500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7G6C-0007ph-PJ for patchwork-qemu-devel@patchwork.kernel.org; Thu, 27 Feb 2020 05:08:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36818) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7G3s-0006FW-Vv for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:06:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7G3r-0002Oo-Sc for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:06:32 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:57295 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7G3r-0002OS-Om for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:06:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582797991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RnfOC7xcAjw65er0wBfO7g8gW20zUjV4ojYZ17BV+64=; b=H4z1iUtce2EwaQG9W1/9ZvFLkrswJQX9CMLw56ulZ18eMj5DznmDIRJOtlGacLXhscDjCb C9J/j/dINS+s8mA/drl4v6ELBpIPgvubfiybvIVx9YNLSRPsT2oGTzbSGtLV4sqyOlKhHK O70xn08KLtmledvD8P1UjzAekKXrMnU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-F789DM6_PDWklkwrG9Oz8Q-1; Thu, 27 Feb 2020 05:06:29 -0500 X-MC-Unique: F789DM6_PDWklkwrG9Oz8Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A8656800D48; Thu, 27 Feb 2020 10:06:28 +0000 (UTC) Received: from x1w.redhat.com (ovpn-205-195.brq.redhat.com [10.40.205.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 312BB1001B09; Thu, 27 Feb 2020 10:06:23 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH] linux-user/syscall: Use g_file_open_tmp() Date: Thu, 27 Feb 2020 11:06:21 +0100 Message-Id: <20200227100621.21844-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Riku Voipio , "Daniel P . Berrange" , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Use GLib g_file_open_tmp() instead of getenv + snprintf + mkstemp. Signed-off-by: Philippe Mathieu-Daudé --- RFC because I'm not sure g_autoptr(GError) works this way. linux-user/syscall.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 8d27d10807..0e44969e16 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -7282,17 +7282,14 @@ static int do_openat(void *cpu_env, int dirfd, const char *pathname, int flags, } if (fake_open->filename) { - const char *tmpdir; - char filename[PATH_MAX]; + g_autoptr(GError) gerr = NULL; + g_autofree gchar *filename = NULL; int fd, r; /* create temporary file to map stat to */ - tmpdir = getenv("TMPDIR"); - if (!tmpdir) - tmpdir = "/tmp"; - snprintf(filename, sizeof(filename), "%s/qemu-open.XXXXXX", tmpdir); - fd = mkstemp(filename); + fd = g_file_open_tmp("qemu-open.XXXXXX", &filename, &gerr); if (fd < 0) { + fprintf(stderr, "Error opening %s: %s\n", filename, gerr->message); return fd; } unlink(filename);