From patchwork Thu Feb 27 16:30:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11408877 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 392CD930 for ; Thu, 27 Feb 2020 16:33:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1012E246A1 for ; Thu, 27 Feb 2020 16:32:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QQ6WzJ8V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1012E246A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:34230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7M5q-00060n-Q5 for patchwork-qemu-devel@patchwork.kernel.org; Thu, 27 Feb 2020 11:32:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40894) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7M4u-0004GP-Fv for qemu-devel@nongnu.org; Thu, 27 Feb 2020 11:32:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7M4s-00030J-KB for qemu-devel@nongnu.org; Thu, 27 Feb 2020 11:32:00 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:36824 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7M4s-0002zB-FH for qemu-devel@nongnu.org; Thu, 27 Feb 2020 11:31:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582821116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+5BpXWc4ttockMxOyu9HMTF9T2jhqzT1UhQN9j5Aqo0=; b=QQ6WzJ8VZXf9Mz1TC5I++vLIKlMhjbwBqb2IsOncZ9Sz/isjHM0SvNS5QPOfTnm/y8XIdr NjbpklGo0nIKqsO0zIUj2KJML5ru2TyMqxvILB+O3JbEeMC6ac/SSrDoJAYS8TQeeql1xt 1rHVhZ+FLeDhVnQxQTTM7au2AGaps7w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-avFKXIEUPsC5Gl6NXD6uOg-1; Thu, 27 Feb 2020 11:31:53 -0500 X-MC-Unique: avFKXIEUPsC5Gl6NXD6uOg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33DAB190D342; Thu, 27 Feb 2020 16:31:52 +0000 (UTC) Received: from x1w.redhat.com (ovpn-205-195.brq.redhat.com [10.40.205.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4489990CD5; Thu, 27 Feb 2020 16:31:46 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 3/6] util/oslib-win32: Improve error report by calling error_setg_win32() Date: Thu, 27 Feb 2020 17:30:58 +0100 Message-Id: <20200227163101.414-4-philmd@redhat.com> In-Reply-To: <20200227163101.414-1-philmd@redhat.com> References: <20200227163101.414-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , Stefan Weil , Markus Armbruster , Michael Roth , =?utf-8?b?VG9tw6HFoSBHb2xlbWJp?= =?utf-8?b?b3Zza8O9?= , Stefan Hajnoczi , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Use error_setg_win32() which adds a hint similar to strerror(errno)). Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- util/oslib-win32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/oslib-win32.c b/util/oslib-win32.c index 84b937865a..6a3e6174f6 100644 --- a/util/oslib-win32.c +++ b/util/oslib-win32.c @@ -47,7 +47,8 @@ void *qemu_oom_check(void *ptr) { if (ptr == NULL) { - error_report("Failed to allocate memory: %lu", GetLastError()); + g_autofree gchar *emsg = g_win32_error_message(GetLastError()); + error_report("Failed to allocate memory: %s", emsg); abort(); } return ptr;