From patchwork Fri Feb 28 11:46:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412083 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8329C1580 for ; Fri, 28 Feb 2020 11:48:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59BD3246AA for ; Fri, 28 Feb 2020 11:48:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="enZGkmMw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59BD3246AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e7l-0000fD-Ac for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:48:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41119) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e6g-0007L8-5s for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e6e-00018V-0C for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:01 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:42861 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e6d-00018L-Tl for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:46:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JwOs2po6nVBrNz+DhsO8Xnl0PhYikRZa4JYienbwBPU=; b=enZGkmMwcthCkeWiHJJV1P3i16eMoKwwNr7UCU4aNwT9T+Xoo6J+fOvpOEdxNLhDL8mDGo IwJVAZ/EkcMaY5+V6adpDIY07gPEYhvXtS/PV/y63ocjj9954WqQTjfFKjp+kUhFaZEOD0 s+7qCJYKVtO8apkB8+hlUPAsr8pKN1M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-cLjOiksVMpS1oKPT7F1fuw-1; Fri, 28 Feb 2020 06:46:57 -0500 X-MC-Unique: cLjOiksVMpS1oKPT7F1fuw-1 Received: by mail-wm1-f71.google.com with SMTP id q20so25316wmg.1 for ; Fri, 28 Feb 2020 03:46:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CpNdsjNPiC6/DnLPjwvW92rGWlXZRi+/lAbWPRuMDaY=; b=i7DcUtnX8LabTOBfrj6io2geYZhagHS4WroRiN9y/yeMu3j9VBveYlhuypExiu8cMo 4Z1fyjRqM0bt6hjzB91h2uZnApAOm1rUdeBUD61+FPv9nrNPDjbdsfrJYbpoOsCIm3YS 0v8ChltaHlnXZwylgHyHu3hUMeoHQKJkSuKaIL7UPTQID5Ue8UsPltGrL7FGzaMgTfPj gafBvuk5FiVb+7JLCj6AyGkCip9EjEkeQwiw/a9QJHWsou450qe8WXRJFQPeAp1PGH7g daVy/A0TkyUs4T0XhHdEBXEFuf/l+n6EkJl8X0vAFg2X6n7EBevBELgMXFdBYZ7ykKCN y2HA== X-Gm-Message-State: APjAAAXhIemmYtQvuTtpafnEIrdcHagsuKgNe/5ATTtKCkD6azNzPN6l rI5p/kNn1fk5yq9bGejNySNJd+kpnCmlkbLuKB7bUQ+w3+jEk5wLd08YqRDCyXIB8szhOVLFSev 1+9ufAgpoellKSVc= X-Received: by 2002:a5d:4b03:: with SMTP id v3mr4785715wrq.81.1582890415985; Fri, 28 Feb 2020 03:46:55 -0800 (PST) X-Google-Smtp-Source: APXvYqxM2/smC26C3TpXbjvfNECRInDeKtZIZJPjM3yZ9lkl22pRKcGsi5IATwr0AxhD1KPwzkMb6w== X-Received: by 2002:a5d:4b03:: with SMTP id v3mr4785695wrq.81.1582890415762; Fri, 28 Feb 2020 03:46:55 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id q138sm1127219wme.41.2020.02.28.03.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:46:55 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 01/18] vl: Add missing "hw/boards.h" include Date: Fri, 28 Feb 2020 12:46:32 +0100 Message-Id: <20200228114649.12818-2-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Paolo Bonzini , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" vl.c calls machine_usb() declared in "hw/boards.h". Include it. This fixes (when modifying unrelated headers): vl.c:1283:10: error: implicit declaration of function 'machine_usb' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (!machine_usb(current_machine)) { ^ vl.c:1283:10: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] vl.c:1283:22: error: use of undeclared identifier 'current_machine' if (!machine_usb(current_machine)) { ^ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- softmmu/vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/softmmu/vl.c b/softmmu/vl.c index 16ff5a16a3..20b7201451 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -25,6 +25,7 @@ #include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/units.h" +#include "hw/boards.h" #include "hw/qdev-properties.h" #include "qapi/error.h" #include "qemu-version.h"