diff mbox series

[PULL,36/38] riscv: virt: Allow PCI address 0

Message ID	20200303004848.136788-37-palmerdabbelt@google.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=+m3j=4U=nongnu.org=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@kernel.org> DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 651F221D56 Subject: [PULL 36/38] riscv: virt: Allow PCI address 0 Date: Mon, 2 Mar 2020 16:48:46 -0800 Message-Id: <20200303004848.136788-37-palmerdabbelt@google.com> In-Reply-To: <20200303004848.136788-1-palmerdabbelt@google.com> References: <20200303004848.136788-1-palmerdabbelt@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Bin Meng <bmeng.cn@gmail.com>, Palmer Dabbelt <palmerdabbelt@google.com> From: Palmer Dabbelt <palmerdabbelt@google.com> To: Peter Maydell <peter.maydell@linaro.org> Precedence: list Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org>
Series	[PULL,01/38] target/riscv: Convert MIP CSR to target_ulong \| expand [PULL,01/38] target/riscv: Convert MIP CSR to target_ulong [PULL,02/38] target/riscv: Add the Hypervisor extension [PULL,03/38] target/riscv: Add the Hypervisor CSRs to CPUState [PULL,04/38] target/riscv: Add support for the new execption numbers [PULL,05/38] target/riscv: Rename the H irqs to VS irqs [PULL,06/38] target/riscv: Add the virtulisation mode [PULL,07/38] target/riscv: Add the force HS exception mode [PULL,08/38] target/riscv: Fix CSR perm checking for HS mode [PULL,09/38] target/riscv: Print priv and virt in disas log [PULL,10/38] target/riscv: Dump Hypervisor registers if enabled [PULL,11/38] target/riscv: Add Hypervisor CSR access functions [PULL,12/38] target/riscv: Add Hypervisor virtual CSRs accesses [PULL,13/38] target/riscv: Add Hypervisor machine CSRs accesses [PULL,14/38] target/riscv: Add virtual register swapping function [PULL,15/38] target/riscv: Set VS bits in mideleg for Hyp extension [PULL,16/38] target/riscv: Extend the MIE CSR to support virtulisation [PULL,17/38] target/riscv: Extend the SIP CSR to support virtulisation [PULL,18/38] target/riscv: Add support for virtual interrupt setting [PULL,19/38] target/ricsv: Flush the TLB on virtulisation mode changes [PULL,20/38] target/riscv: Generate illegal instruction on WFI when V=1 [PULL,21/38] target/riscv: Add hypvervisor trap support [PULL,22/38] target/riscv: Add Hypervisor trap return support [PULL,23/38] target/riscv: Add hfence instructions [PULL,24/38] target/riscv: Remove the hret instruction [PULL,25/38] target/riscv: Only set TB flags with FP status if enabled [PULL,26/38] target/riscv: Disable guest FP support based on virtual status [PULL,27/38] target/riscv: Mark both sstatus and msstatus_hs as dirty [PULL,28/38] target/riscv: Respect MPRV and SPRV for floating point ops [PULL,29/38] target/riscv: Allow specifying MMU stage [PULL,30/38] target/riscv: Implement second stage MMU [PULL,31/38] target/riscv: Raise the new execptions when 2nd stage translation fails [PULL,32/38] target/riscv: Set htval and mtval2 on execptions [PULL,33/38] target/riscv: Add support for the 32-bit MSTATUSH CSR [PULL,34/38] target/riscv: Add the MSTATUS_MPV_ISSET helper macro [PULL,35/38] target/riscv: Allow enabling the Hypervisor extension [PULL,36/38] riscv: virt: Allow PCI address 0 [PULL,37/38] target/riscv: Emulate TIME CSRs for privileged mode [PULL,38/38] hw/riscv: Provide rdtime callback for TCG in CLINT emulation

Commit Message

Palmer Dabbelt March 3, 2020, 12:48 a.m. UTC

From: Bin Meng <bmeng.cn@gmail.com>

When testing e1000 with the virt machine, e1000's I/O space cannot
be accessed. Debugging shows that the I/O BAR (BAR1) is correctly
written with address 0 plus I/O enable bit, but QEMU's "info pci"
shows that:

  Bus  0, device   1, function 0:
    Ethernet controller: PCI device 8086:100e
  ...
      BAR1: I/O at 0xffffffffffffffff [0x003e].
  ...

It turns out we should set pci_allow_0_address to true to allow 0
PCI address, otherwise pci_bar_address() treats such address as
PCI_BAR_UNMAPPED.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
 hw/riscv/virt.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

Patch

diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index 7f9e1e5176..5d175d5c9e 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -641,6 +641,7 @@  static void riscv_virt_machine_class_init(ObjectClass *oc, void *data)
     mc->init = riscv_virt_board_init;
     mc->max_cpus = 8;
     mc->default_cpu_type = VIRT_CPU;
+    mc->pci_allow_0_address = true;
 }
 
 static const TypeInfo riscv_virt_machine_typeinfo = {