From patchwork Tue Mar 3 10:47:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prasad Pandit X-Patchwork-Id: 11417701 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5449614B4 for ; Tue, 3 Mar 2020 10:50:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C51820836 for ; Tue, 3 Mar 2020 10:50:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ddk+dOW4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C51820836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j958O-0005kv-8K for patchwork-qemu-devel@patchwork.kernel.org; Tue, 03 Mar 2020 05:50:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59213) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j957g-0004Ip-D6 for qemu-devel@nongnu.org; Tue, 03 Mar 2020 05:50:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j957f-0004HT-5j for qemu-devel@nongnu.org; Tue, 03 Mar 2020 05:50:00 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:37307 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j957f-0004H9-2Q for qemu-devel@nongnu.org; Tue, 03 Mar 2020 05:49:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583232598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r+TlfrilbRfne+z8GeafTqYFZOfWGvku6sWK+MuQCqo=; b=ddk+dOW4uPA+l8q1C+B/P68evafsMw9UbwSzfDLkGOKEhPxKdKL6efibJlpj/3ytHU2gBu dl9GdYB2uul0K0W0wXlsT12bOEoWJjJRfSspB+6Fx7bQO71jRLInFHeiKnGwkyM6ENjndO bVCSsAgUvfsxrCFAXQ/GEinKgg0MzMs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-Zp1wx_fSNpy8tnh7gZsb7Q-1; Tue, 03 Mar 2020 05:49:56 -0500 X-MC-Unique: Zp1wx_fSNpy8tnh7gZsb7Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9DDD5800053; Tue, 3 Mar 2020 10:49:55 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-177.sin2.redhat.com [10.67.116.177]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99A1B5C1D6; Tue, 3 Mar 2020 10:49:52 +0000 (UTC) From: P J P To: Jason Wang Subject: [PATCH v3 2/2] net: tulip: add .can_recieve routine Date: Tue, 3 Mar 2020 16:17:24 +0530 Message-Id: <20200303104724.233375-3-ppandit@redhat.com> In-Reply-To: <20200303104724.233375-1-ppandit@redhat.com> References: <20200303104724.233375-1-ppandit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , Sven Schnelle , Qemu Developers , Ziming Zhang , Prasad J Pandit Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Prasad J Pandit Define .can_receive routine to do sanity checks before receiving packet data. Signed-off-by: Prasad J Pandit --- hw/net/tulip.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) Update v3: define .can_receive routine -> https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg06275.html diff --git a/hw/net/tulip.c b/hw/net/tulip.c index fbe40095da..757f12c710 100644 --- a/hw/net/tulip.c +++ b/hw/net/tulip.c @@ -229,6 +229,18 @@ static bool tulip_filter_address(TULIPState *s, const uint8_t *addr) return ret; } +static int +tulip_can_receive(NetClientState *nc) +{ + TULIPState *s = qemu_get_nic_opaque(nc); + + if (s->rx_frame_len || tulip_rx_stopped(s)) { + return false; + } + + return true; +} + static ssize_t tulip_receive(TULIPState *s, const uint8_t *buf, size_t size) { struct tulip_descriptor desc; @@ -236,7 +248,7 @@ static ssize_t tulip_receive(TULIPState *s, const uint8_t *buf, size_t size) trace_tulip_receive(buf, size); if (size < 14 || size > sizeof(s->rx_frame) - 4 - || s->rx_frame_len || tulip_rx_stopped(s)) { + || !tulip_can_receive(s->nic->ncs)) { return 0; } @@ -288,6 +300,7 @@ static NetClientInfo net_tulip_info = { .type = NET_CLIENT_DRIVER_NIC, .size = sizeof(NICState), .receive = tulip_receive_nc, + .can_receive = tulip_can_receive, }; static const char *tulip_reg_name(const hwaddr addr)