| Message ID | 20200304174120.11970-1-liran.alon@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | configure: Fix pkg_config --exists parameter | expand |
* Liran Alon (liran.alon@oracle.com) wrote: > pkg_config parameter should be "--exists", not "--exist". > This is probably a typo. > > Fixes: 3a67848134d0 ("configure: Enable test and libs for zstd") > Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com> > Signed-off-by: Liran Alon <liran.alon@oracle.com> That's the same as 20200303124925.28079-1-dplotnikov@virtuozzo.com from Denis yesterday. Dave > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 50c4d96e2a8c..280f3654f786 100755 > --- a/configure > +++ b/configure > @@ -2464,7 +2464,7 @@ fi > # zstd check > > if test "$zstd" != "no" ; then > - if $pkg_config --exist libzstd ; then > + if $pkg_config --exists libzstd ; then > zstd_cflags="$($pkg_config --cflags libzstd)" > zstd_libs="$($pkg_config --libs libzstd)" > LIBS="$zstd_libs $LIBS" > -- > 2.20.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On 3/4/20 6:42 PM, Dr. David Alan Gilbert wrote: > * Liran Alon (liran.alon@oracle.com) wrote: >> pkg_config parameter should be "--exists", not "--exist". >> This is probably a typo. >> >> Fixes: 3a67848134d0 ("configure: Enable test and libs for zstd") >> Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com> >> Signed-off-by: Liran Alon <liran.alon@oracle.com> > > That's the same as 20200303124925.28079-1-dplotnikov@virtuozzo.com from > Denis yesterday. And Alex 2 days ago: https://www.mail-archive.com/qemu-devel@nongnu.org/msg684754.html > > Dave > >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index 50c4d96e2a8c..280f3654f786 100755 >> --- a/configure >> +++ b/configure >> @@ -2464,7 +2464,7 @@ fi >> # zstd check >> >> if test "$zstd" != "no" ; then >> - if $pkg_config --exist libzstd ; then >> + if $pkg_config --exists libzstd ; then >> zstd_cflags="$($pkg_config --cflags libzstd)" >> zstd_libs="$($pkg_config --libs libzstd)" >> LIBS="$zstd_libs $LIBS" >> -- >> 2.20.1 >> > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > >
diff --git a/configure b/configure index 50c4d96e2a8c..280f3654f786 100755 --- a/configure +++ b/configure @@ -2464,7 +2464,7 @@ fi # zstd check if test "$zstd" != "no" ; then - if $pkg_config --exist libzstd ; then + if $pkg_config --exists libzstd ; then zstd_cflags="$($pkg_config --cflags libzstd)" zstd_libs="$($pkg_config --libs libzstd)" LIBS="$zstd_libs $LIBS"
pkg_config parameter should be "--exists", not "--exist". This is probably a typo. Fixes: 3a67848134d0 ("configure: Enable test and libs for zstd") Reviewed-by: Bhavesh Davda <bhavesh.davda@oracle.com> Signed-off-by: Liran Alon <liran.alon@oracle.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)