| Message ID | 20200305175651.4563-2-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/net: Make Net/CanBus can_receive() handlers return a boolean | expand |
On Thu, Mar 5, 2020 at 9:57 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > The e1000e_can_receive() function simply returns a boolean value. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/net/e1000e_core.h | 2 +- > hw/net/e1000e_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/net/e1000e_core.h b/hw/net/e1000e_core.h > index 49abb136dd..aee32f7e48 100644 > --- a/hw/net/e1000e_core.h > +++ b/hw/net/e1000e_core.h > @@ -143,7 +143,7 @@ e1000e_core_set_link_status(E1000ECore *core); > void > e1000e_core_pci_uninit(E1000ECore *core); > > -int > +bool > e1000e_can_receive(E1000ECore *core); > > ssize_t > diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c > index 94ea34dca5..e0bafe975b 100644 > --- a/hw/net/e1000e_core.c > +++ b/hw/net/e1000e_core.c > @@ -967,7 +967,7 @@ e1000e_start_recv(E1000ECore *core) > } > } > > -int > +bool > e1000e_can_receive(E1000ECore *core) > { > int i; > -- > 2.21.1 > >
On 05/03/20 18:56, Philippe Mathieu-Daudé wrote: > The e1000e_can_receive() function simply returns a boolean value. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/net/e1000e_core.h | 2 +- > hw/net/e1000e_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/net/e1000e_core.h b/hw/net/e1000e_core.h > index 49abb136dd..aee32f7e48 100644 > --- a/hw/net/e1000e_core.h > +++ b/hw/net/e1000e_core.h > @@ -143,7 +143,7 @@ e1000e_core_set_link_status(E1000ECore *core); > void > e1000e_core_pci_uninit(E1000ECore *core); > > -int > +bool > e1000e_can_receive(E1000ECore *core); > > ssize_t > diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c > index 94ea34dca5..e0bafe975b 100644 > --- a/hw/net/e1000e_core.c > +++ b/hw/net/e1000e_core.c > @@ -967,7 +967,7 @@ e1000e_start_recv(E1000ECore *core) > } > } > > -int > +bool > e1000e_can_receive(E1000ECore *core) > { > int i; > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
On 3/5/20 6:56 PM, Philippe Mathieu-Daudé wrote: > The e1000e_can_receive() function simply returns a boolean value. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> > --- > hw/net/e1000e_core.h | 2 +- > hw/net/e1000e_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/net/e1000e_core.h b/hw/net/e1000e_core.h > index 49abb136dd..aee32f7e48 100644 > --- a/hw/net/e1000e_core.h > +++ b/hw/net/e1000e_core.h > @@ -143,7 +143,7 @@ e1000e_core_set_link_status(E1000ECore *core); > void > e1000e_core_pci_uninit(E1000ECore *core); > > -int > +bool > e1000e_can_receive(E1000ECore *core); > > ssize_t > diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c > index 94ea34dca5..e0bafe975b 100644 > --- a/hw/net/e1000e_core.c > +++ b/hw/net/e1000e_core.c > @@ -967,7 +967,7 @@ e1000e_start_recv(E1000ECore *core) > } > } > > -int > +bool > e1000e_can_receive(E1000ECore *core) > { > int i; >
diff --git a/hw/net/e1000e_core.h b/hw/net/e1000e_core.h index 49abb136dd..aee32f7e48 100644 --- a/hw/net/e1000e_core.h +++ b/hw/net/e1000e_core.h @@ -143,7 +143,7 @@ e1000e_core_set_link_status(E1000ECore *core); void e1000e_core_pci_uninit(E1000ECore *core); -int +bool e1000e_can_receive(E1000ECore *core); ssize_t diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 94ea34dca5..e0bafe975b 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -967,7 +967,7 @@ e1000e_start_recv(E1000ECore *core) } } -int +bool e1000e_can_receive(E1000ECore *core) { int i;
The e1000e_can_receive() function simply returns a boolean value. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/net/e1000e_core.h | 2 +- hw/net/e1000e_core.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)