mbox

[PULL,00/33] Trivial branch patches

Message ID 20200309150837.3193387-1-laurent@vivier.eu (mailing list archive)
State New, archived
Headers show

Pull-request

git://github.com/vivier/qemu.git tags/trivial-branch-pull-request

Message

Laurent Vivier March 9, 2020, 3:08 p.m. UTC
The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:

  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-03-09 10:32:53 +0000)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/trivial-branch-pull-request

for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:

  monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)

----------------------------------------------------------------
- includes cleanup
- reduce .data footprint
- fix warnings reported by Clang static code analyzer
- fix dp8393x part lost in merge
- update git.orderfile and rules.mak

----------------------------------------------------------------

Chen Qun (7):
  block/stream: Remove redundant statement in stream_run()
  block/file-posix: Remove redundant statement in raw_handle_perm_lock()
  dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
  scsi/scsi-disk: Remove redundant statement in
    scsi_disk_emulate_command()
  display/pxa2xx_lcd: Remove redundant statement in
    pxa2xx_palette_parse()
  display/exynos4210_fimd: Remove redundant statement in
    exynos4210_fimd_update()
  monitor/hmp-cmds: Remove redundant statement in
    hmp_rocker_of_dpa_groups()

Eric Blake (1):
  maint: Include top-level *.rst files early in git diff

Finn Thain (1):
  dp8393x: Mask EOL bit from descriptor addresses, take 2

Pan Nengyuan (1):
  core/qdev: fix memleak in qdev_get_gpio_out_connector()

Philippe Mathieu-Daudé (23):
  build-sys: Move the print-variable rule to rules.mak
  hw/audio/fmopl: Fix a typo twice
  hw/net/e1000: Add readops/writeops typedefs
  hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data
  virtfs-proxy-helper: Make the helper_opts[] array const
  vl: Add missing "hw/boards.h" include
  hw/southbridge/ich9: Removed unused headers
  hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
  hw/timer: Remove unused "ui/console.h" header
  hw/usb/dev-storage: Remove unused "ui/console.h" header
  hw/i386/intel_iommu: Remove unused includes
  hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
  hw/alpha/dp264: Include "net/net.h"
  hw/hppa/machine: Include "net/net.h"
  hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
  hw/timer/hpet: Include "exec/address-spaces.h"
  hw/pci-host/q35: Include "qemu/range.h"
  hw/i2c/smbus_ich9: Include "qemu/range.h"
  hw/pci-host/piix: Include "qemu/range.h"
  hw/acpi: Include "hw/mem/nvdimm.h"
  hw/i386: Include "hw/mem/nvdimm.h"
  hw/pci-host/q35: Remove unused includes
  hw/i386/pc: Clean up includes

 Makefile                          |  3 ---
 block/file-posix.c                |  1 -
 block/stream.c                    |  3 +--
 fsdev/virtfs-proxy-helper.c       |  2 +-
 hw/acpi/cpu_hotplug.c             |  1 +
 hw/acpi/ich9.c                    |  2 +-
 hw/acpi/piix4.c                   |  1 +
 hw/alpha/alpha_sys.h              |  1 -
 hw/alpha/dp264.c                  |  1 +
 hw/audio/fmopl.c                  |  4 ++--
 hw/core/qdev.c                    |  2 +-
 hw/display/exynos4210_fimd.c      |  1 -
 hw/display/pxa2xx_lcd.c           |  1 -
 hw/dma/xlnx-zdma.c                | 10 +++++-----
 hw/hppa/machine.c                 |  1 +
 hw/i2c/smbus_ich9.c               |  1 +
 hw/i386/acpi-build.c              |  1 +
 hw/i386/pc.c                      |  1 +
 hw/i386/pc_piix.c                 |  1 +
 hw/i386/pc_q35.c                  |  1 +
 hw/isa/lpc_ich9.c                 |  1 -
 hw/net/dp8393x.c                  |  4 ++--
 hw/net/e1000.c                    |  6 ++++--
 hw/net/e1000e_core.c              |  6 ++++--
 hw/pci-host/i440fx.c              |  1 +
 hw/pci-host/q35.c                 |  1 +
 hw/rtc/twl92230.c                 |  1 -
 hw/scsi/scsi-disk.c               |  1 -
 hw/timer/hpet.c                   |  2 +-
 hw/usb/dev-storage.c              |  1 -
 include/hw/i386/ich9.h            |  1 -
 include/hw/i386/intel_iommu.h     |  4 ----
 include/hw/i386/ioapic_internal.h |  1 -
 include/hw/i386/pc.h              | 11 +++--------
 include/hw/pci-host/q35.h         |  8 +-------
 monitor/hmp-cmds.c                |  5 +----
 rules.mak                         |  3 +++
 scripts/git.orderfile             |  1 +
 softmmu/vl.c                      |  1 +
 39 files changed, 43 insertions(+), 55 deletions(-)

Comments

no-reply@patchew.org March 9, 2020, 4:31 p.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20200309150837.3193387-1-laurent@vivier.eu/



Hi,

This series failed the docker-clang@ubuntu build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-ubuntu V=1 NETWORK=1
time make docker-test-clang@ubuntu SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  LINK    qemu-bridge-helper
  LINK    virtiofsd
  LINK    vhost-user-input
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  GEN     cris-softmmu/hmp-commands.h
  GEN     lm32-softmmu/hmp-commands.h
  GEN     m68k-softmmu/hmp-commands.h
---
  CC      mips64-softmmu/hw/misc/mips_cmgcr.o
  CC      mips64-softmmu/hw/misc/mips_cpc.o
  CC      mips64-softmmu/hw/misc/mips_itu.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      mips64-softmmu/hw/net/virtio-net.o
  CC      mips64-softmmu/hw/net/rocker/qmp-norocker.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      arm-softmmu/hw/arm/integratorcp.o
  CC      mips64el-softmmu/hw/block/virtio-blk.o
  CC      i386-softmmu/hw/virtio/vhost-user-fs-pci.o
---
  CC      mips64-softmmu/hw/scsi/virtio-scsi-dataplane.o
  CC      i386-softmmu/hw/virtio/virtio-iommu.o
  CC      i386-softmmu/hw/virtio/vhost-vsock.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      aarch64-softmmu/hw/arm/integratorcp.o
  CC      aarch64-softmmu/hw/arm/mainstone.o
  CC      mips64el-softmmu/hw/block/dataplane/virtio-blk.o
---
  CC      i386-softmmu/hw/virtio/vhost-user-scsi-pci.o
  CC      aarch64-softmmu/hw/arm/netduino2.o
  CC      aarch64-softmmu/hw/arm/netduinoplus2.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      aarch64-softmmu/hw/arm/nseries.o
  CC      i386-softmmu/hw/virtio/vhost-scsi-pci.o
  CC      mipsel-softmmu/disas.o
---
  CC      mips64el-softmmu/qapi/qapi-events-machine-target.o
  CC      mips-softmmu/target/mips/dsp_helper.o
  CC      mips-softmmu/target/mips/lmi_helper.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      arm-softmmu/softmmu/vl.o
  CC      nios2-softmmu/tcg/tcg-op-vec.o
  CC      mips64el-softmmu/qapi/qapi-events-misc-target.o
---
  CC      moxie-softmmu/accel/tcg/cpu-exec.o
  CC      mipsel-softmmu/hw/virtio/virtio-balloon-pci.o
  CC      moxie-softmmu/accel/tcg/cpu-exec-common.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      moxie-softmmu/accel/tcg/translate-all.o
  CC      mips64-softmmu/target/mips/dsp_helper.o
  CC      arm-softmmu/target/arm/cpu.o
---
  CC      nios2-softmmu/accel/stubs/whpx-stub.o
  CC      mipsel-softmmu/hw/virtio/virtio-scsi-pci.o
  CC      or1k-softmmu/accel/tcg/cputlb.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      mips64-softmmu/target/mips/mips-semi.o
  CC      ppc-softmmu/accel/qtest.o
  CC      i386-softmmu/hw/i386/vmport.o
---
  CC      or1k-softmmu/softmmu/vl.o
  CC      arm-softmmu/trace/generated-helpers.o
  CC      i386-softmmu/hw/i386/kvm/clock.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      ppc64-softmmu/exec-vary.o
  CC      ppc64-softmmu/tcg/tcg.o
  CC      i386-softmmu/hw/i386/kvm/apic.o
---
  CC      moxie-softmmu/trace/generated-helpers.o
  CC      ppc64-softmmu/balloon.o
  CC      ppc64-softmmu/ioport.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  GEN     or1k-softmmu/target/openrisc/decode.inc.c
  CC      riscv64-softmmu/fpu/softfloat.o
  CC      mipsel-softmmu/target/mips/op_helper.o
---
  CC      ppc64-softmmu/migration/ram.o
  GEN     riscv64-softmmu/gdbstub-xml.c
  LINK    aarch64-softmmu/qemu-system-aarch64
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      riscv32-softmmu/arch_init.o
  CC      nios2-softmmu/target/nios2/op_helper.o
  CC      riscv64-softmmu/arch_init.o
---
  CC      sh4-softmmu/fpu/softfloat.o
  CC      riscv32-softmmu/accel/tcg/tcg-runtime-gvec.o
  CC      ppc64-softmmu/hw/block/vhost-user-blk.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      s390x-softmmu/fpu/softfloat.o
  CC      s390x-softmmu/disas.o
  CC      riscv64-softmmu/accel/tcg/cputlb.o
---
  CC      ppc64-softmmu/hw/block/dataplane/virtio-blk.o
  CC      ppc-softmmu/hw/virtio/virtio-iommu-pci.o
  GEN     s390x-softmmu/gdbstub-xml.c
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      riscv64-softmmu/accel/tcg/tcg-runtime.o
  CC      sh4-softmmu/arch_init.o
  CC      ppc-softmmu/hw/virtio/virtio-9p-pci.o
---
  CC      riscv32-softmmu/hw/9pfs/virtio-9p-device.o
  CC      riscv32-softmmu/hw/block/virtio-blk.o
  CC      ppc64-softmmu/hw/display/virtio-gpu.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      s390x-softmmu/memory.o
  CC      s390x-softmmu/memory_mapping.o
  CC      riscv32-softmmu/hw/block/vhost-user-blk.o
---
  GEN     unicore32-softmmu/hmp-commands.h
  GEN     unicore32-softmmu/hmp-commands-info.h
  GEN     unicore32-softmmu/config-devices.h
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  GEN     unicore32-softmmu/config-target.h
  CC      unicore32-softmmu/exec.o
  CC      tricore-softmmu/qapi/qapi-introspect.o
  CC      ppc64-softmmu/hw/ppc/spapr_rtas_ddw.o
  CC      s390x-softmmu/qapi/qapi-events-misc-target.o
  CC      sparc64-softmmu/hw/block/virtio-blk.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      s390x-softmmu/qapi/qapi-events.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      sparc64-softmmu/hw/block/vhost-user-blk.o
  CC      s390x-softmmu/qapi/qapi-commands-machine-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      tricore-softmmu/qapi/qapi-types-machine-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      ppc64-softmmu/hw/ppc/ppc405_boards.o
  CC      tricore-softmmu/qapi/qapi-types-misc-target.o
  CC      sparc64-softmmu/hw/block/dataplane/virtio-blk.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      unicore32-softmmu/exec-vary.o
  CC      s390x-softmmu/qapi/qapi-commands-misc-target.o
  CC      unicore32-softmmu/tcg/tcg.o
---
  CC      ppc64-softmmu/hw/ppc/prep.o
  CC      sparc64-softmmu/hw/display/virtio-gpu-3d.o
  CC      tricore-softmmu/qapi/qapi-commands-misc-target.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      ppc64-softmmu/hw/ppc/prep_systemio.o
  CC      sh4eb-softmmu/target/sh4/cpu.o
  CC      s390x-softmmu/target/s390x/cpu_models.o
---
  CC      sparc64-softmmu/hw/vfio/spapr.o
  CC      unicore32-softmmu/accel/qtest.o
  CC      tricore-softmmu/target/tricore/translate.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      s390x-softmmu/target/s390x/fpu_helper.o
  CC      xtensa-softmmu/disas.o
  CC      x86_64-softmmu/fpu/softfloat.o
---
  CC      sparc64-softmmu/hw/virtio/virtio-iommu.o
  CC      unicore32-softmmu/qapi/qapi-types.o
  CC      sparc64-softmmu/hw/virtio/vhost-vsock.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      xtensaeb-softmmu/memory_mapping.o
  CC      unicore32-softmmu/qapi/qapi-visit-machine-target.o
  CC      xtensa-softmmu/accel/tcg/tcg-runtime-gvec.o
---
  CC      sparc64-softmmu/qapi/qapi-types-machine-target.o
  CC      alpha-linux-user/accel/tcg/tcg-runtime.o
  CC      aarch64_be-linux-user/accel/stubs/whpx-stub.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      aarch64_be-linux-user/accel/stubs/kvm-stub.o
  CC      x86_64-softmmu/hw/display/virtio-gpu-base.o
  CC      ppc64-softmmu/target/ppc/mmu-book3s-v3.o
---
  CC      x86_64-softmmu/hw/display/virtio-vga.o
  CC      ppc64-softmmu/target/ppc/fpu_helper.o
  CC      xtensa-softmmu/hw/semihosting/config.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      ppc64-softmmu/target/ppc/int_helper.o
  CC      ppc64-softmmu/target/ppc/timebase_helper.o
  CC      xtensaeb-softmmu/hw/scsi/virtio-scsi-dataplane.o
---
  CC      i386-linux-user/accel/tcg/tcg-runtime.o
  CC      armeb-linux-user/linux-user/uaccess.o
  CC      i386-linux-user/accel/tcg/tcg-runtime-gvec.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      hppa-linux-user/linux-user/main.o
  CC      xtensa-softmmu/qapi/qapi-commands-misc-target.o
  CC      cris-linux-user/linux-user/signal.o
---
  CC      i386-linux-user/target/i386/cpu.o
  CC      m68k-linux-user/tcg/tcg-op-vec.o
  CC      x86_64-softmmu/hw/xen/xen_pt_load_rom.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      hppa-linux-user/trace/generated-helpers.o
  CC      aarch64-linux-user/target/arm/translate-sve.o
  CC      m68k-linux-user/tcg/tcg-op-gvec.o
---
  CC      m68k-linux-user/target/m68k/op_helper.o
  CC      mips64el-linux-user/linux-user/elfload.o
  CCAS    microblazeel-linux-user/linux-user/safe-syscall.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      mips64el-linux-user/linux-user/linuxload.o
  CC      microblaze-linux-user/linux-user/uname.o
  CC      microblazeel-linux-user/linux-user/microblaze/signal.o
---
  CC      mips64-linux-user/linux-user/signal.o
  CC      microblaze-linux-user/linux-user/microblaze/cpu_loop.o
  CC      m68k-linux-user/target/m68k/fpu_helper.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      microblazeel-linux-user/linux-user/fd-trans.o
  CC      microblazeel-linux-user/linux-user/flatload.o
  CC      microblazeel-linux-user/target/microblaze/translate.o
---
  CC      tilegx-linux-user/linux-user/tilegx/signal.o
  CC      tilegx-linux-user/linux-user/tilegx/cpu_loop.o
  CC      xtensa-linux-user/accel/tcg/cpu-exec.o
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  CC      xtensa-linux-user/accel/tcg/cpu-exec-common.o
  CC      xtensa-linux-user/accel/tcg/translate-all.o
  CC      xtensaeb-linux-user/thunk.o
---
  LINK    fp-test
  LINK    tests/test-iov
  LINK    tests/test-bitmap
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-aio
  LINK    tests/test-aio-multithread
  LINK    tests/test-throttle
  LINK    tests/test-thread-pool
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-hbitmap
  LINK    tests/test-bdrv-drain
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-bdrv-graph-mod
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-blockjob
  LINK    tests/test-blockjob-txn
  LINK    tests/test-block-backend
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-block-iothread
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-image-locking
  LINK    tests/test-x86-cpuid
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-xbzrle
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-vmstate
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-cutils
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-shift128
  LINK    tests/test-mul64
  LINK    tests/test-int128
---
  LINK    tests/test-write-threshold
  LINK    tests/test-crypto-hash
  LINK    tests/test-crypto-hmac
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  LINK    tests/test-crypto-cipher
  LINK    tests/test-crypto-secret
  LINK    tests/test-crypto-tlscredsx509
---
  FLOAT TEST lt_quiet
  FLOAT TEST add
  FLOAT TEST sub
/usr/bin/ld: /lib/x86_64-linux-gnu/libtirpc.so.3: warning: common of `rpc_createerr@@GLIBC_2.2.5' overridden by definition from /lib/x86_64-linux-gnu/libc.so.6
  FLOAT TEST mul
  FLOAT TEST mulAdd
  FLOAT TEST uint-to-float
---
dbus-daemon[8262]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry

**
ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
Aborted (core dumped)
cleaning up pid 8262
make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-i386] Error 1
make: *** Waiting for unfinished jobs....
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: -accel kvm: failed to initialize kvm: No such file or directory
---
dbus-daemon[9590]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry

**
ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
Aborted (core dumped)
cleaning up pid 9590
ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-x86_64] Error 1
  TEST    check-qtest-arm: tests/qtest/test-hmp
  TEST    check-qtest-arm: tests/qtest/qos-test
  TEST    check-qtest-aarch64: tests/qtest/test-hmp
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=47cb3ce1218347808c17d0936a1a5f53', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-oy1xpz1h/src/docker-src.2020-03-09-12.12.34.28747:/var/tmp/qemu:z,ro', 'qemu:ubuntu', '/var/tmp/qemu/run', 'test-clang']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=47cb3ce1218347808c17d0936a1a5f53
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-oy1xpz1h/src'
make: *** [docker-run-test-clang@ubuntu] Error 2

real    19m16.345s
user    0m9.023s


The full log is available at
http://patchew.org/logs/20200309150837.3193387-1-laurent@vivier.eu/testing.docker-clang@ubuntu/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell March 9, 2020, 4:44 p.m. UTC | #2
On Mon, 9 Mar 2020 at 15:09, Laurent Vivier <laurent@vivier.eu> wrote:
>
> The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>
>   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-03-09 10:32:53 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>
> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>
>   monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
>
> ----------------------------------------------------------------
> - includes cleanup
> - reduce .data footprint
> - fix warnings reported by Clang static code analyzer
> - fix dp8393x part lost in merge
> - update git.orderfile and rules.mak
>
> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.

-- PMM
Michael S. Tsirkin March 9, 2020, 7:17 p.m. UTC | #3
On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
> The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
> 
>   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-03-09 10:32:53 +0000)
> 
> are available in the Git repository at:
> 
>   git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
> 
> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
> 
>   monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)


Could you avoid CC everyone involved on the whole PULL req?
I was involved in a patch or two and don't really need to see
the whole series. Just the cover and the relevant patches
would be enough - if I do want it there's always lore.


> ----------------------------------------------------------------
> - includes cleanup
> - reduce .data footprint
> - fix warnings reported by Clang static code analyzer
> - fix dp8393x part lost in merge
> - update git.orderfile and rules.mak
> 
> ----------------------------------------------------------------
> 
> Chen Qun (7):
>   block/stream: Remove redundant statement in stream_run()
>   block/file-posix: Remove redundant statement in raw_handle_perm_lock()
>   dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
>   scsi/scsi-disk: Remove redundant statement in
>     scsi_disk_emulate_command()
>   display/pxa2xx_lcd: Remove redundant statement in
>     pxa2xx_palette_parse()
>   display/exynos4210_fimd: Remove redundant statement in
>     exynos4210_fimd_update()
>   monitor/hmp-cmds: Remove redundant statement in
>     hmp_rocker_of_dpa_groups()
> 
> Eric Blake (1):
>   maint: Include top-level *.rst files early in git diff
> 
> Finn Thain (1):
>   dp8393x: Mask EOL bit from descriptor addresses, take 2
> 
> Pan Nengyuan (1):
>   core/qdev: fix memleak in qdev_get_gpio_out_connector()
> 
> Philippe Mathieu-Daudé (23):
>   build-sys: Move the print-variable rule to rules.mak
>   hw/audio/fmopl: Fix a typo twice
>   hw/net/e1000: Add readops/writeops typedefs
>   hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data
>   virtfs-proxy-helper: Make the helper_opts[] array const
>   vl: Add missing "hw/boards.h" include
>   hw/southbridge/ich9: Removed unused headers
>   hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
>   hw/timer: Remove unused "ui/console.h" header
>   hw/usb/dev-storage: Remove unused "ui/console.h" header
>   hw/i386/intel_iommu: Remove unused includes
>   hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
>   hw/alpha/dp264: Include "net/net.h"
>   hw/hppa/machine: Include "net/net.h"
>   hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
>   hw/timer/hpet: Include "exec/address-spaces.h"
>   hw/pci-host/q35: Include "qemu/range.h"
>   hw/i2c/smbus_ich9: Include "qemu/range.h"
>   hw/pci-host/piix: Include "qemu/range.h"
>   hw/acpi: Include "hw/mem/nvdimm.h"
>   hw/i386: Include "hw/mem/nvdimm.h"
>   hw/pci-host/q35: Remove unused includes
>   hw/i386/pc: Clean up includes
> 
>  Makefile                          |  3 ---
>  block/file-posix.c                |  1 -
>  block/stream.c                    |  3 +--
>  fsdev/virtfs-proxy-helper.c       |  2 +-
>  hw/acpi/cpu_hotplug.c             |  1 +
>  hw/acpi/ich9.c                    |  2 +-
>  hw/acpi/piix4.c                   |  1 +
>  hw/alpha/alpha_sys.h              |  1 -
>  hw/alpha/dp264.c                  |  1 +
>  hw/audio/fmopl.c                  |  4 ++--
>  hw/core/qdev.c                    |  2 +-
>  hw/display/exynos4210_fimd.c      |  1 -
>  hw/display/pxa2xx_lcd.c           |  1 -
>  hw/dma/xlnx-zdma.c                | 10 +++++-----
>  hw/hppa/machine.c                 |  1 +
>  hw/i2c/smbus_ich9.c               |  1 +
>  hw/i386/acpi-build.c              |  1 +
>  hw/i386/pc.c                      |  1 +
>  hw/i386/pc_piix.c                 |  1 +
>  hw/i386/pc_q35.c                  |  1 +
>  hw/isa/lpc_ich9.c                 |  1 -
>  hw/net/dp8393x.c                  |  4 ++--
>  hw/net/e1000.c                    |  6 ++++--
>  hw/net/e1000e_core.c              |  6 ++++--
>  hw/pci-host/i440fx.c              |  1 +
>  hw/pci-host/q35.c                 |  1 +
>  hw/rtc/twl92230.c                 |  1 -
>  hw/scsi/scsi-disk.c               |  1 -
>  hw/timer/hpet.c                   |  2 +-
>  hw/usb/dev-storage.c              |  1 -
>  include/hw/i386/ich9.h            |  1 -
>  include/hw/i386/intel_iommu.h     |  4 ----
>  include/hw/i386/ioapic_internal.h |  1 -
>  include/hw/i386/pc.h              | 11 +++--------
>  include/hw/pci-host/q35.h         |  8 +-------
>  monitor/hmp-cmds.c                |  5 +----
>  rules.mak                         |  3 +++
>  scripts/git.orderfile             |  1 +
>  softmmu/vl.c                      |  1 +
>  39 files changed, 43 insertions(+), 55 deletions(-)
> 
> -- 
> 2.24.1
Philippe Mathieu-Daudé March 9, 2020, 7:30 p.m. UTC | #4
On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
>> The following changes since commit 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>>
>>    Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-03-09 10:32:53 +0000)
>>
>> are available in the Git repository at:
>>
>>    git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>
>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>>
>>    monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
> 
> 
> Could you avoid CC everyone involved on the whole PULL req?
> I was involved in a patch or two and don't really need to see
> the whole series. Just the cover and the relevant patches
> would be enough - if I do want it there's always lore.

I suppose Laurent used git-publish, which has this limitation.

> 
>> ----------------------------------------------------------------
>> - includes cleanup
>> - reduce .data footprint
>> - fix warnings reported by Clang static code analyzer
>> - fix dp8393x part lost in merge
>> - update git.orderfile and rules.mak
>>
>> ----------------------------------------------------------------
>>
>> Chen Qun (7):
>>    block/stream: Remove redundant statement in stream_run()
>>    block/file-posix: Remove redundant statement in raw_handle_perm_lock()
>>    dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
>>    scsi/scsi-disk: Remove redundant statement in
>>      scsi_disk_emulate_command()
>>    display/pxa2xx_lcd: Remove redundant statement in
>>      pxa2xx_palette_parse()
>>    display/exynos4210_fimd: Remove redundant statement in
>>      exynos4210_fimd_update()
>>    monitor/hmp-cmds: Remove redundant statement in
>>      hmp_rocker_of_dpa_groups()
>>
>> Eric Blake (1):
>>    maint: Include top-level *.rst files early in git diff
>>
>> Finn Thain (1):
>>    dp8393x: Mask EOL bit from descriptor addresses, take 2
>>
>> Pan Nengyuan (1):
>>    core/qdev: fix memleak in qdev_get_gpio_out_connector()
>>
>> Philippe Mathieu-Daudé (23):
>>    build-sys: Move the print-variable rule to rules.mak
>>    hw/audio/fmopl: Fix a typo twice
>>    hw/net/e1000: Add readops/writeops typedefs
>>    hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data
>>    virtfs-proxy-helper: Make the helper_opts[] array const
>>    vl: Add missing "hw/boards.h" include
>>    hw/southbridge/ich9: Removed unused headers
>>    hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
>>    hw/timer: Remove unused "ui/console.h" header
>>    hw/usb/dev-storage: Remove unused "ui/console.h" header
>>    hw/i386/intel_iommu: Remove unused includes
>>    hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
>>    hw/alpha/dp264: Include "net/net.h"
>>    hw/hppa/machine: Include "net/net.h"
>>    hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
>>    hw/timer/hpet: Include "exec/address-spaces.h"
>>    hw/pci-host/q35: Include "qemu/range.h"
>>    hw/i2c/smbus_ich9: Include "qemu/range.h"
>>    hw/pci-host/piix: Include "qemu/range.h"
>>    hw/acpi: Include "hw/mem/nvdimm.h"
>>    hw/i386: Include "hw/mem/nvdimm.h"
>>    hw/pci-host/q35: Remove unused includes
>>    hw/i386/pc: Clean up includes
>>
>>   Makefile                          |  3 ---
>>   block/file-posix.c                |  1 -
>>   block/stream.c                    |  3 +--
>>   fsdev/virtfs-proxy-helper.c       |  2 +-
>>   hw/acpi/cpu_hotplug.c             |  1 +
>>   hw/acpi/ich9.c                    |  2 +-
>>   hw/acpi/piix4.c                   |  1 +
>>   hw/alpha/alpha_sys.h              |  1 -
>>   hw/alpha/dp264.c                  |  1 +
>>   hw/audio/fmopl.c                  |  4 ++--
>>   hw/core/qdev.c                    |  2 +-
>>   hw/display/exynos4210_fimd.c      |  1 -
>>   hw/display/pxa2xx_lcd.c           |  1 -
>>   hw/dma/xlnx-zdma.c                | 10 +++++-----
>>   hw/hppa/machine.c                 |  1 +
>>   hw/i2c/smbus_ich9.c               |  1 +
>>   hw/i386/acpi-build.c              |  1 +
>>   hw/i386/pc.c                      |  1 +
>>   hw/i386/pc_piix.c                 |  1 +
>>   hw/i386/pc_q35.c                  |  1 +
>>   hw/isa/lpc_ich9.c                 |  1 -
>>   hw/net/dp8393x.c                  |  4 ++--
>>   hw/net/e1000.c                    |  6 ++++--
>>   hw/net/e1000e_core.c              |  6 ++++--
>>   hw/pci-host/i440fx.c              |  1 +
>>   hw/pci-host/q35.c                 |  1 +
>>   hw/rtc/twl92230.c                 |  1 -
>>   hw/scsi/scsi-disk.c               |  1 -
>>   hw/timer/hpet.c                   |  2 +-
>>   hw/usb/dev-storage.c              |  1 -
>>   include/hw/i386/ich9.h            |  1 -
>>   include/hw/i386/intel_iommu.h     |  4 ----
>>   include/hw/i386/ioapic_internal.h |  1 -
>>   include/hw/i386/pc.h              | 11 +++--------
>>   include/hw/pci-host/q35.h         |  8 +-------
>>   monitor/hmp-cmds.c                |  5 +----
>>   rules.mak                         |  3 +++
>>   scripts/git.orderfile             |  1 +
>>   softmmu/vl.c                      |  1 +
>>   39 files changed, 43 insertions(+), 55 deletions(-)
>>
>> -- 
>> 2.24.1
>
Laurent Vivier March 10, 2020, 8:02 a.m. UTC | #5
Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
> On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
>> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
>>> The following changes since commit
>>> 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>>>
>>>    Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
>>> staging (2020-03-09 10:32:53 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>>    git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>
>>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>>>
>>>    monitor/hmp-cmds: Remove redundant statement in
>>> hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
>>
>>
>> Could you avoid CC everyone involved on the whole PULL req?
>> I was involved in a patch or two and don't really need to see
>> the whole series. Just the cover and the relevant patches
>> would be enough - if I do want it there's always lore.
> 
> I suppose Laurent used git-publish, which has this limitation.
> 

Yes, I use git publish and CC are automatically added.

Philippe, you told me some time ago you have a patch to fix this
behaviour and only CC people on a patch base. Is it available?

Thanks,
Laurent
Kevin Wolf March 10, 2020, 11:45 a.m. UTC | #6
Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
> Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
> > On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
> >> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
> >>> The following changes since commit
> >>> 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
> >>>
> >>>    Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
> >>> staging (2020-03-09 10:32:53 +0000)
> >>>
> >>> are available in the Git repository at:
> >>>
> >>>    git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
> >>>
> >>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
> >>>
> >>>    monitor/hmp-cmds: Remove redundant statement in
> >>> hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
> >>
> >>
> >> Could you avoid CC everyone involved on the whole PULL req?
> >> I was involved in a patch or two and don't really need to see
> >> the whole series. Just the cover and the relevant patches
> >> would be enough - if I do want it there's always lore.
> > 
> > I suppose Laurent used git-publish, which has this limitation.
> > 
> 
> Yes, I use git publish and CC are automatically added.
> 
> Philippe, you told me some time ago you have a patch to fix this
> behaviour and only CC people on a patch base. Is it available?

Actually, I don't think it's even necessary to CC anyone at all (except
the relevant lists) for pull requests. These patches were already
reviewed.

Kevin
Philippe Mathieu-Daudé March 10, 2020, noon UTC | #7
On 3/10/20 12:45 PM, Kevin Wolf wrote:
> Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
>> Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
>>> On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
>>>> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
>>>>> The following changes since commit
>>>>> 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>>>>>
>>>>>     Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
>>>>> staging (2020-03-09 10:32:53 +0000)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>>     git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>>>
>>>>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>>>>>
>>>>>     monitor/hmp-cmds: Remove redundant statement in
>>>>> hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
>>>>
>>>>
>>>> Could you avoid CC everyone involved on the whole PULL req?
>>>> I was involved in a patch or two and don't really need to see
>>>> the whole series. Just the cover and the relevant patches
>>>> would be enough - if I do want it there's always lore.
>>>
>>> I suppose Laurent used git-publish, which has this limitation.
>>>
>>
>> Yes, I use git publish and CC are automatically added.
>>
>> Philippe, you told me some time ago you have a patch to fix this
>> behaviour and only CC people on a patch base. Is it available?

I guess you mean 
https://github.com/philmd/git-publish/commit/5bab6e2cc77, I haven't 
improved it but plan to spend time on it during my next holidays.

> Actually, I don't think it's even necessary to CC anyone at all (except
> the relevant lists) for pull requests. These patches were already
> reviewed.

Well as a contributor I find useful to get notified when patches are merged.

I guess remember some time ago patchew (or another bot?) was sending a 
notification on pull request merged, this was even more useful than 
Cc'ing ppl on pull-req. It is also helpful when you track someone else 
patch on the list.
Since most of the maintainers now include the patch RFC822 Message-Id, 
it is now easy for a bot to reply to patch taken from the last.

> 
> Kevin
>
Daniel P. Berrangé March 10, 2020, 12:11 p.m. UTC | #8
On Tue, Mar 10, 2020 at 01:00:12PM +0100, Philippe Mathieu-Daudé wrote:
> On 3/10/20 12:45 PM, Kevin Wolf wrote:
> > Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
> > > Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
> > > > On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
> > > > > On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
> > > > > > The following changes since commit
> > > > > > 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
> > > > > > 
> > > > > >     Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
> > > > > > staging (2020-03-09 10:32:53 +0000)
> > > > > > 
> > > > > > are available in the Git repository at:
> > > > > > 
> > > > > >     git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
> > > > > > 
> > > > > > for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
> > > > > > 
> > > > > >     monitor/hmp-cmds: Remove redundant statement in
> > > > > > hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
> > > > > 
> > > > > 
> > > > > Could you avoid CC everyone involved on the whole PULL req?
> > > > > I was involved in a patch or two and don't really need to see
> > > > > the whole series. Just the cover and the relevant patches
> > > > > would be enough - if I do want it there's always lore.
> > > > 
> > > > I suppose Laurent used git-publish, which has this limitation.
> > > > 
> > > 
> > > Yes, I use git publish and CC are automatically added.
> > > 
> > > Philippe, you told me some time ago you have a patch to fix this
> > > behaviour and only CC people on a patch base. Is it available?
> 
> I guess you mean https://github.com/philmd/git-publish/commit/5bab6e2cc77, I
> haven't improved it but plan to spend time on it during my next holidays.
> 
> > Actually, I don't think it's even necessary to CC anyone at all (except
> > the relevant lists) for pull requests. These patches were already
> > reviewed.
> 
> Well as a contributor I find useful to get notified when patches are merged.

Yeah, I tend to agree with that - it is good to know when something is
merged, more so if you are an infrequent contributor to an area of code
or QEMU in general.

Regards,
Daniel
Kevin Wolf March 10, 2020, 12:13 p.m. UTC | #9
Am 10.03.2020 um 13:00 hat Philippe Mathieu-Daudé geschrieben:
> On 3/10/20 12:45 PM, Kevin Wolf wrote:
> > Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
> > > Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
> > > > On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
> > > > > On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
> > > > > > The following changes since commit
> > > > > > 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
> > > > > > 
> > > > > >     Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
> > > > > > staging (2020-03-09 10:32:53 +0000)
> > > > > > 
> > > > > > are available in the Git repository at:
> > > > > > 
> > > > > >     git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
> > > > > > 
> > > > > > for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
> > > > > > 
> > > > > >     monitor/hmp-cmds: Remove redundant statement in
> > > > > > hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
> > > > > 
> > > > > 
> > > > > Could you avoid CC everyone involved on the whole PULL req?
> > > > > I was involved in a patch or two and don't really need to see
> > > > > the whole series. Just the cover and the relevant patches
> > > > > would be enough - if I do want it there's always lore.
> > > > 
> > > > I suppose Laurent used git-publish, which has this limitation.
> > > > 
> > > 
> > > Yes, I use git publish and CC are automatically added.
> > > 
> > > Philippe, you told me some time ago you have a patch to fix this
> > > behaviour and only CC people on a patch base. Is it available?
> 
> I guess you mean https://github.com/philmd/git-publish/commit/5bab6e2cc77, I
> haven't improved it but plan to spend time on it during my next holidays.
> 
> > Actually, I don't think it's even necessary to CC anyone at all (except
> > the relevant lists) for pull requests. These patches were already
> > reviewed.
> 
> Well as a contributor I find useful to get notified when patches are merged.

Hm, I guess a matter of different preferences then.

> I guess remember some time ago patchew (or another bot?) was sending a
> notification on pull request merged, this was even more useful than Cc'ing
> ppl on pull-req. It is also helpful when you track someone else patch on the
> list.
> Since most of the maintainers now include the patch RFC822 Message-Id, it is
> now easy for a bot to reply to patch taken from the last.

I don't remember anything like this, but having an automatic reply to
the email thread of each merged patch series might be a good idea.

Kevin
Philippe Mathieu-Daudé March 10, 2020, 12:31 p.m. UTC | #10
On 3/10/20 1:13 PM, Kevin Wolf wrote:
> Am 10.03.2020 um 13:00 hat Philippe Mathieu-Daudé geschrieben:
>> On 3/10/20 12:45 PM, Kevin Wolf wrote:
>>> Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
>>>> Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
>>>>> On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
>>>>>> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
>>>>>>> The following changes since commit
>>>>>>> 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>>>>>>>
>>>>>>>      Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
>>>>>>> staging (2020-03-09 10:32:53 +0000)
>>>>>>>
>>>>>>> are available in the Git repository at:
>>>>>>>
>>>>>>>      git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>>>>>
>>>>>>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>>>>>>>
>>>>>>>      monitor/hmp-cmds: Remove redundant statement in
>>>>>>> hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
>>>>>>
>>>>>>
>>>>>> Could you avoid CC everyone involved on the whole PULL req?
>>>>>> I was involved in a patch or two and don't really need to see
>>>>>> the whole series. Just the cover and the relevant patches
>>>>>> would be enough - if I do want it there's always lore.
>>>>>
>>>>> I suppose Laurent used git-publish, which has this limitation.
>>>>>
>>>>
>>>> Yes, I use git publish and CC are automatically added.
>>>>
>>>> Philippe, you told me some time ago you have a patch to fix this
>>>> behaviour and only CC people on a patch base. Is it available?
>>
>> I guess you mean https://github.com/philmd/git-publish/commit/5bab6e2cc77, I
>> haven't improved it but plan to spend time on it during my next holidays.
>>
>>> Actually, I don't think it's even necessary to CC anyone at all (except
>>> the relevant lists) for pull requests. These patches were already
>>> reviewed.
>>
>> Well as a contributor I find useful to get notified when patches are merged.
> 
> Hm, I guess a matter of different preferences then.
> 
>> I guess remember some time ago patchew (or another bot?) was sending a
>> notification on pull request merged, this was even more useful than Cc'ing
>> ppl on pull-req. It is also helpful when you track someone else patch on the
>> list.
>> Since most of the maintainers now include the patch RFC822 Message-Id, it is
>> now easy for a bot to reply to patch taken from the last.
> 
> I don't remember anything like this, but having an automatic reply to
> the email thread of each merged patch series might be a good idea.

It was patchew: 
https://www.mail-archive.com/qemu-devel@nongnu.org/msg623861.html

   From: no-reply@patchew.org

   Subject: A patch has been merged in QEMU: $PatchSubject

   Congratulations, $PatchSubject was merged by the QEMU maintainers.

> 
> Kevin
> 
>
Laurent Vivier March 10, 2020, 12:34 p.m. UTC | #11
Le 10/03/2020 à 13:13, Kevin Wolf a écrit :
> Am 10.03.2020 um 13:00 hat Philippe Mathieu-Daudé geschrieben:
>> On 3/10/20 12:45 PM, Kevin Wolf wrote:
>>> Am 10.03.2020 um 09:02 hat Laurent Vivier geschrieben:
>>>> Le 09/03/2020 à 20:30, Philippe Mathieu-Daudé a écrit :
>>>>> On 3/9/20 8:17 PM, Michael S. Tsirkin wrote:
>>>>>> On Mon, Mar 09, 2020 at 04:08:04PM +0100, Laurent Vivier wrote:
>>>>>>> The following changes since commit
>>>>>>> 7a5853cec479a448edae0fb2aaf4e2f78c9c774d:
>>>>>>>
>>>>>>>     Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
>>>>>>> staging (2020-03-09 10:32:53 +0000)
>>>>>>>
>>>>>>> are available in the Git repository at:
>>>>>>>
>>>>>>>     git://github.com/vivier/qemu.git tags/trivial-branch-pull-request
>>>>>>>
>>>>>>> for you to fetch changes up to 916c92503bd5348a33e561db600d8894bde636bb:
>>>>>>>
>>>>>>>     monitor/hmp-cmds: Remove redundant statement in
>>>>>>> hmp_rocker_of_dpa_groups() (2020-03-09 15:59:31 +0100)
>>>>>>
>>>>>>
>>>>>> Could you avoid CC everyone involved on the whole PULL req?
>>>>>> I was involved in a patch or two and don't really need to see
>>>>>> the whole series. Just the cover and the relevant patches
>>>>>> would be enough - if I do want it there's always lore.
>>>>>
>>>>> I suppose Laurent used git-publish, which has this limitation.
>>>>>
>>>>
>>>> Yes, I use git publish and CC are automatically added.
>>>>
>>>> Philippe, you told me some time ago you have a patch to fix this
>>>> behaviour and only CC people on a patch base. Is it available?
>>
>> I guess you mean https://github.com/philmd/git-publish/commit/5bab6e2cc77, I
>> haven't improved it but plan to spend time on it during my next holidays.
>>
>>> Actually, I don't think it's even necessary to CC anyone at all (except
>>> the relevant lists) for pull requests. These patches were already
>>> reviewed.
>>
>> Well as a contributor I find useful to get notified when patches are merged.
> 
> Hm, I guess a matter of different preferences then.
> 
>> I guess remember some time ago patchew (or another bot?) was sending a
>> notification on pull request merged, this was even more useful than Cc'ing
>> ppl on pull-req. It is also helpful when you track someone else patch on the
>> list.
>> Since most of the maintainers now include the patch RFC822 Message-Id, it is
>> now easy for a bot to reply to patch taken from the last.
> 
> I don't remember anything like this, but having an automatic reply to
> the email thread of each merged patch series might be a good idea.

I receive an email for each merge [1]

There is a mailing list for that:

https://lists.nongnu.org/mailman/listinfo/qemu-commits

Thanks,
Laurent

[1] https://lists.nongnu.org/archive/html/qemu-commits/2020-03/index.html