| Message ID | 20200318071620.59748-1-pannengyuan@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hmp-cmd: fix a missing_break warning | expand |
Correcting zhang hailiang's email. On 3/18/2020 3:16 PM, Pan Nengyuan wrote: > This fix coverity issues 94417686: > 1260 break; > CID 94417686: (MISSING_BREAK) > 1261. unterminated_case: The case for value "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break' statement. > 1261 case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: > 1262 p->has_throttle_trigger_threshold = true; > 1263 visit_type_int(v, param, &p->throttle_trigger_threshold, &err); > 1264 case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: > > Fixes: dc14a470763c96fd9d360e1028ce38e8c3613a77 > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> > --- > Cc: zhukeqian1@huawei.com > --- > monitor/hmp-cmds.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index 58724031ea..c882c9f3cc 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -1261,6 +1261,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) > case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: > p->has_throttle_trigger_threshold = true; > visit_type_int(v, param, &p->throttle_trigger_threshold, &err); > + break; > case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: > p->has_cpu_throttle_initial = true; > visit_type_int(v, param, &p->cpu_throttle_initial, &err); >
Hi Nengyuan, On 2020/3/18 15:22, Pan Nengyuan wrote: > Correcting zhang hailiang's email. > > On 3/18/2020 3:16 PM, Pan Nengyuan wrote: >> This fix coverity issues 94417686: >> 1260 break; >> CID 94417686: (MISSING_BREAK) >> 1261. unterminated_case: The case for value "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break' statement. >> 1261 case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: >> 1262 p->has_throttle_trigger_threshold = true; >> 1263 visit_type_int(v, param, &p->throttle_trigger_threshold, &err); >> 1264 case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: >> >> Fixes: dc14a470763c96fd9d360e1028ce38e8c3613a77 >> Reported-by: Euler Robot <euler.robot@huawei.com> >> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> >> --- >> Cc: zhukeqian1@huawei.com >> --- >> monitor/hmp-cmds.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c >> index 58724031ea..c882c9f3cc 100644 >> --- a/monitor/hmp-cmds.c >> +++ b/monitor/hmp-cmds.c >> @@ -1261,6 +1261,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) >> case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: >> p->has_throttle_trigger_threshold = true; >> visit_type_int(v, param, &p->throttle_trigger_threshold, &err); >> + break; Good fix :). >> case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: >> p->has_cpu_throttle_initial = true; >> visit_type_int(v, param, &p->cpu_throttle_initial, &err); >> > > . > Reviewed-by: Keqian Zhu <zhukeqian1@huawei.com> Thanks, Keqian
* Pan Nengyuan (pannengyuan@huawei.com) wrote: > This fix coverity issues 94417686: > 1260 break; > CID 94417686: (MISSING_BREAK) > 1261. unterminated_case: The case for value "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break' statement. > 1261 case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: > 1262 p->has_throttle_trigger_threshold = true; > 1263 visit_type_int(v, param, &p->throttle_trigger_threshold, &err); > 1264 case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: > > Fixes: dc14a470763c96fd9d360e1028ce38e8c3613a77 > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> > --- > Cc: zhukeqian1@huawei.com > --- > monitor/hmp-cmds.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index 58724031ea..c882c9f3cc 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -1261,6 +1261,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) > case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: > p->has_throttle_trigger_threshold = true; > visit_type_int(v, param, &p->throttle_trigger_threshold, &err); > + break; Thanks! Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: > p->has_cpu_throttle_initial = true; > visit_type_int(v, param, &p->cpu_throttle_initial, &err); > -- > 2.21.0.windows.1 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On 3/18/20 8:16 AM, Pan Nengyuan wrote: > This fix coverity issues 94417686: > 1260 break; > CID 94417686: (MISSING_BREAK) > 1261. unterminated_case: The case for value "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break' statement. > 1261 case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: > 1262 p->has_throttle_trigger_threshold = true; > 1263 visit_type_int(v, param, &p->throttle_trigger_threshold, &err); > 1264 case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: > > Fixes: dc14a470763c96fd9d360e1028ce38e8c3613a77 > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> > --- > Cc: zhukeqian1@huawei.com > --- > monitor/hmp-cmds.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index 58724031ea..c882c9f3cc 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -1261,6 +1261,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) > case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: > p->has_throttle_trigger_threshold = true; > visit_type_int(v, param, &p->throttle_trigger_threshold, &err); > + break; > case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: > p->has_cpu_throttle_initial = true; > visit_type_int(v, param, &p->cpu_throttle_initial, &err); > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Wed, 18 Mar 2020 at 07:18, Pan Nengyuan <pannengyuan@huawei.com> wrote: > > This fix coverity issues 94417686: > 1260 break; > CID 94417686: (MISSING_BREAK) > 1261. unterminated_case: The case for value "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break' statement. > 1261 case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: > 1262 p->has_throttle_trigger_threshold = true; > 1263 visit_type_int(v, param, &p->throttle_trigger_threshold, &err); > 1264 case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: This is CID 1421950. (I'm not sure where your number comes from.) > Fixes: dc14a470763c96fd9d360e1028ce38e8c3613a77 > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> thanks -- PMM
* Pan Nengyuan (pannengyuan@huawei.com) wrote: > Correcting zhang hailiang's email. Queued > On 3/18/2020 3:16 PM, Pan Nengyuan wrote: > > This fix coverity issues 94417686: > > 1260 break; > > CID 94417686: (MISSING_BREAK) > > 1261. unterminated_case: The case for value "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break' statement. > > 1261 case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: > > 1262 p->has_throttle_trigger_threshold = true; > > 1263 visit_type_int(v, param, &p->throttle_trigger_threshold, &err); > > 1264 case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: > > > > Fixes: dc14a470763c96fd9d360e1028ce38e8c3613a77 > > Reported-by: Euler Robot <euler.robot@huawei.com> > > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> > > --- > > Cc: zhukeqian1@huawei.com > > --- > > monitor/hmp-cmds.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > > index 58724031ea..c882c9f3cc 100644 > > --- a/monitor/hmp-cmds.c > > +++ b/monitor/hmp-cmds.c > > @@ -1261,6 +1261,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) > > case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: > > p->has_throttle_trigger_threshold = true; > > visit_type_int(v, param, &p->throttle_trigger_threshold, &err); > > + break; > > case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: > > p->has_cpu_throttle_initial = true; > > visit_type_int(v, param, &p->cpu_throttle_initial, &err); > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 58724031ea..c882c9f3cc 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -1261,6 +1261,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: p->has_throttle_trigger_threshold = true; visit_type_int(v, param, &p->throttle_trigger_threshold, &err); + break; case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: p->has_cpu_throttle_initial = true; visit_type_int(v, param, &p->cpu_throttle_initial, &err);
This fix coverity issues 94417686: 1260 break; CID 94417686: (MISSING_BREAK) 1261. unterminated_case: The case for value "MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break' statement. 1261 case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD: 1262 p->has_throttle_trigger_threshold = true; 1263 visit_type_int(v, param, &p->throttle_trigger_threshold, &err); 1264 case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL: Fixes: dc14a470763c96fd9d360e1028ce38e8c3613a77 Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> --- Cc: zhukeqian1@huawei.com --- monitor/hmp-cmds.c | 1 + 1 file changed, 1 insertion(+)