| Message ID | 20200319040326.391090-1-leonardo@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/1] device_tree: Add info message when dumping dtb to file | expand |
On Thu, Mar 19, 2020 at 01:03:26AM -0300, Leonardo Bras wrote: > When dumping dtb to a file, qemu exits silently before starting the VM. > > Add info message so user can easily track why the proccess exits. > Add error message if dtb dump failed. > > Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> > --- > device_tree.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/device_tree.c b/device_tree.c > index f8b46b3c73..bba6cc2164 100644 > --- a/device_tree.c > +++ b/device_tree.c > @@ -530,7 +530,12 @@ void qemu_fdt_dumpdtb(void *fdt, int size) > > if (dumpdtb) { > /* Dump the dtb to a file and quit */ > - exit(g_file_set_contents(dumpdtb, fdt, size, NULL) ? 0 : 1); > + if (g_file_set_contents(dumpdtb, fdt, size, NULL)) { > + info_report("dtb dumped to %s. Exiting.", dumpdtb); > + exit(0); > + } > + error_report("%s: Failed dumping dtb to %s", __func__, dumpdtb); > + exit(1); > } > } >
On Wed, Mar 18, 2020 at 9:03 PM Leonardo Bras <leonardo@linux.ibm.com> wrote: > > When dumping dtb to a file, qemu exits silently before starting the VM. > > Add info message so user can easily track why the proccess exits. > Add error message if dtb dump failed. > > Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com> Thanks for the patch Reviewed-by: Alistair Francis <alistair.francis@wdc.com> I have sent a PR with this patch. Alistair > --- > device_tree.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/device_tree.c b/device_tree.c > index f8b46b3c73..bba6cc2164 100644 > --- a/device_tree.c > +++ b/device_tree.c > @@ -530,7 +530,12 @@ void qemu_fdt_dumpdtb(void *fdt, int size) > > if (dumpdtb) { > /* Dump the dtb to a file and quit */ > - exit(g_file_set_contents(dumpdtb, fdt, size, NULL) ? 0 : 1); > + if (g_file_set_contents(dumpdtb, fdt, size, NULL)) { > + info_report("dtb dumped to %s. Exiting.", dumpdtb); > + exit(0); > + } > + error_report("%s: Failed dumping dtb to %s", __func__, dumpdtb); > + exit(1); > } > } > > -- > 2.24.1 > >
diff --git a/device_tree.c b/device_tree.c index f8b46b3c73..bba6cc2164 100644 --- a/device_tree.c +++ b/device_tree.c @@ -530,7 +530,12 @@ void qemu_fdt_dumpdtb(void *fdt, int size) if (dumpdtb) { /* Dump the dtb to a file and quit */ - exit(g_file_set_contents(dumpdtb, fdt, size, NULL) ? 0 : 1); + if (g_file_set_contents(dumpdtb, fdt, size, NULL)) { + info_report("dtb dumped to %s. Exiting.", dumpdtb); + exit(0); + } + error_report("%s: Failed dumping dtb to %s", __func__, dumpdtb); + exit(1); } }
When dumping dtb to a file, qemu exits silently before starting the VM. Add info message so user can easily track why the proccess exits. Add error message if dtb dump failed. Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com> --- device_tree.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)