| Message ID | 20200320190553.9363-3-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/docker: Fixes for 5.0 | expand |
8:06 PM Pet, 20.03.2020. Philippe Mathieu-Daudé <philmd@redhat.com> је написао/ла: > > Apparently Debian Stretch was listing gcrypt as a QEMU dependency, > but this is not the case anymore in Buster, so we need to install > it manually (it it not listed by 'apt-get -s build-dep qemu' in > the common debian10.docker anymore). > > $ ../configure $QEMU_CONFIGURE_OPTS > > ERROR: User requested feature gcrypt > configure was not able to find it. > Install gcrypt devel >= 1.5.0 > > Fixes: 698a71edbed & 6f8bbb374be > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- If the problem is caused by Debian Buster change in behavior, I think you should not enumerate QEMU commits as something that is fixed by this patch. That implies that something was wrong with these commits, while they were, I suppose, fine at the moment of their integration. Very confusing! If you think that these commit ids deserve to be mentioned, you should say: "Related commits are..." or similar. Regards, Aleksandar > tests/docker/dockerfiles/debian-amd64.docker | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker > index d4849f509f..957f0bc2e7 100644 > --- a/tests/docker/dockerfiles/debian-amd64.docker > +++ b/tests/docker/dockerfiles/debian-amd64.docker > @@ -16,6 +16,7 @@ RUN apt update && \ > apt install -y --no-install-recommends \ > libbz2-dev \ > liblzo2-dev \ > + libgcrypt20-dev \ > librdmacm-dev \ > libsasl2-dev \ > libsnappy-dev \ > -- > 2.21.1 > >
diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker index d4849f509f..957f0bc2e7 100644 --- a/tests/docker/dockerfiles/debian-amd64.docker +++ b/tests/docker/dockerfiles/debian-amd64.docker @@ -16,6 +16,7 @@ RUN apt update && \ apt install -y --no-install-recommends \ libbz2-dev \ liblzo2-dev \ + libgcrypt20-dev \ librdmacm-dev \ libsasl2-dev \ libsnappy-dev \
Apparently Debian Stretch was listing gcrypt as a QEMU dependency, but this is not the case anymore in Buster, so we need to install it manually (it it not listed by 'apt-get -s build-dep qemu' in the common debian10.docker anymore). $ ../configure $QEMU_CONFIGURE_OPTS ERROR: User requested feature gcrypt configure was not able to find it. Install gcrypt devel >= 1.5.0 Fixes: 698a71edbed & 6f8bbb374be Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- tests/docker/dockerfiles/debian-amd64.docker | 1 + 1 file changed, 1 insertion(+)