diff mbox series

[for-5.0,1/3] via-ide: don't use PCI level for legacy IRQs

Message ID 20200324210519.2974-2-mark.cave-ayland@ilande.co.uk (mailing list archive)
State New, archived
Headers show
Series ide: fix potential memory leaks (plus one via-ide bugfix) | expand

Commit Message

Mark Cave-Ayland March 24, 2020, 9:05 p.m. UTC 
The PCI level calculation was accidentally left in when rebasing from a
previous patchset. Since both IRQs are driven separately, the value
being passed into the IRQ handler should be used directly.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/ide/via.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox series

Patch

diff --git a/hw/ide/via.c b/hw/ide/via.c
index 8de4945cc1..2a55b7fbc6 100644
--- a/hw/ide/via.c
+++ b/hw/ide/via.c
@@ -112,7 +112,6 @@  static void via_ide_set_irq(void *opaque, int n, int level)
         d->config[0x70 + n * 8] &= ~0x80;
     }
 
-    level = (d->config[0x70] & 0x80) || (d->config[0x78] & 0x80);
     qemu_set_irq(isa_get_irq(NULL, 14 + n), level);
 }