diff mbox series

[5/5] ramfb: drop leftover debug message

Message ID 20200422100211.30614-6-kraxel@redhat.com (mailing list archive)
State New, archived
Headers show
Series ramfb: a bunch of reverts and fixes | expand

Commit Message

Gerd Hoffmann April 22, 2020, 10:02 a.m. UTC 
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/display/ramfb.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Philippe Mathieu-Daudé April 22, 2020, 10:26 a.m. UTC | #1 
On 4/22/20 12:02 PM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   hw/display/ramfb.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c
> index d1b1cb9bb294..be884c9ea837 100644
> --- a/hw/display/ramfb.c
> +++ b/hw/display/ramfb.c
> @@ -88,8 +88,6 @@ static void ramfb_fw_cfg_write(void *dev, off_t offset, size_t len)
>       addr   = be64_to_cpu(s->cfg.addr);
>       format = qemu_drm_format_to_pixman(fourcc);
>   
> -    fprintf(stderr, "%s: %dx%d @ 0x%" PRIx64 "\n", __func__,
> -            s->width, s->height, addr);
>       surface = ramfb_create_display_surface(width, height,
>                                              format, stride, addr);
>       if (!surface)
> 

I'd move this before patch #3/5 "ramfb: don't update RAMFBState on 
errors". Anyway,

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Laszlo Ersek April 22, 2020, 4:54 p.m. UTC | #2 
On 04/22/20 12:02, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/display/ramfb.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c
> index d1b1cb9bb294..be884c9ea837 100644
> --- a/hw/display/ramfb.c
> +++ b/hw/display/ramfb.c
> @@ -88,8 +88,6 @@ static void ramfb_fw_cfg_write(void *dev, off_t offset, size_t len)
>      addr   = be64_to_cpu(s->cfg.addr);
>      format = qemu_drm_format_to_pixman(fourcc);
>  
> -    fprintf(stderr, "%s: %dx%d @ 0x%" PRIx64 "\n", __func__,
> -            s->width, s->height, addr);
>      surface = ramfb_create_display_surface(width, height,
>                                             format, stride, addr);
>      if (!surface)
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
diff mbox series

Patch

diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c
index d1b1cb9bb294..be884c9ea837 100644
--- a/hw/display/ramfb.c
+++ b/hw/display/ramfb.c
@@ -88,8 +88,6 @@  static void ramfb_fw_cfg_write(void *dev, off_t offset, size_t len)
     addr   = be64_to_cpu(s->cfg.addr);
     format = qemu_drm_format_to_pixman(fourcc);
 
-    fprintf(stderr, "%s: %dx%d @ 0x%" PRIx64 "\n", __func__,
-            s->width, s->height, addr);
     surface = ramfb_create_display_surface(width, height,
                                            format, stride, addr);
     if (!surface)