From patchwork Mon May 4 15:59:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 11526631 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4363D15AB for ; Mon, 4 May 2020 16:05:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2427F2075A for ; Mon, 4 May 2020 16:05:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2427F2075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:43244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVdb4-0001Zw-7v for patchwork-qemu-devel@patchwork.kernel.org; Mon, 04 May 2020 12:05:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVdW0-0001Sd-NH; Mon, 04 May 2020 12:00:20 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:52241) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVdVz-0005tc-O2; Mon, 04 May 2020 12:00:20 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MScHp-1jgwCr2R4L-00Ssf8; Mon, 04 May 2020 18:00:12 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 13/19] hw/i2c/pm_smbus: Remove dead assignment Date: Mon, 4 May 2020 17:59:50 +0200 Message-Id: <20200504155956.380695-14-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504155956.380695-1-laurent@vivier.eu> References: <20200504155956.380695-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:IcV9362VkIZBpTgL0+Mugc2QoGskXIha9mZ+/XOQjriZYJzKTZr KXo0iV1TNpqa7CvEg1EEpjnJa1p7v+USa6SUuw/WH+ALG5Uywf3q8jSk3bOXHwi5Pc2XRAI 7/kgREaBr2fE5loNgrBzU1d+6mHa57M57V4qu8GjJG+kQEPW0rHgxYi6mH9qfVS2ZpdeRYl hN2UdSE4D/vaoayjBWjYg== X-UI-Out-Filterresults: notjunk:1;V03:K0:pSVrhZIcdm4=:PiZDsZnNHMtOpHRBwhkzAB vGXoKZ4OLsiAfHmWW+bB/oIFdQKpZMhtdmt/RV87hef3uDXv48ZYDlB0zDHru2PU2cdVYCqHJ EQxk9wm1wtBzn+jJz3HFflDrqFnByFX5n4/mLBb7SvZxagFYUPhPaIVcc3nd+qU47uzK2OKGp Aw7uwsG0EOqLitfICDiOvcWyzphA3L/hjqL1k/zu9KLDBPBoNWst1sXFrZutTP6j4lPxy2UDb 7+VeNybb6QQ8I71B0hLIGPAJADZl2U4X10vEAxW4txZiNtxvFqvwd35suLK2+CZ3S5jCy+AKc cib1aGb+gIMyfl/UHsrOXXQt1EOW8gRnNQrtMny6JZVIAkHX4CFe/YTYFfbFoeu21a2YltX+K 8D7tPj4Lx5CmVk9ExD6LWtpVTi4nLTE8vHB/hMV1jXurezPmStwS82dOR0pcejEFARpR4uP0P qFzWtcq8XyhKWsInX06lk1Ftk05bPp1NdbzP4mBGb9fmfjpozUoX3UeZcbt6pKetMhG90HPO5 CxcqvWqMdvApJ/iLWcMjTZeob4Qsdu+ZRHwg9V5oJX5P8eOn0objHkVI7f9OC0oG5/TM0/Jbm xnnFb4WrSsre6rIoJM9sHxRzZddjGuW3yj/Kg3uMpdqYOTA4zYO+q9PPu1rVe6d+CkwLJOehS k0ErdAuoOup6N7gLcIpJbR4psuNDfoEgkVohDahF2TeKISzLRkeqYMBZQnIM4ihiel9EimCeQ T5MA3Dx7pjMNsVprVkfuylB51FeTnj2WgtAugSuXBxKlXVl3W/9c6jqZPBKws55INzl3+mKSx 9KXXWFRO8xlhCkJccjKD10TIG78YWJrd1hviYa5+a0bDlVJDIi1hklY8codY1jliRH3rX0F Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 12:00:18 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Alistair Francis , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Fix warning reported by Clang static code analyzer: CC hw/i2c/pm_smbus.o hw/i2c/pm_smbus.c:187:17: warning: Value stored to 'ret' is never read ret = 0; ^ ~ Reported-by: Clang Static Analyzer Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200422133152.16770-4-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/i2c/pm_smbus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c index 36994ff5857c..4728540c37e6 100644 --- a/hw/i2c/pm_smbus.c +++ b/hw/i2c/pm_smbus.c @@ -184,7 +184,6 @@ static void smb_transaction(PMSMBus *s) s->smb_stat |= STS_HOST_BUSY | STS_BYTE_DONE; s->smb_data[0] = s->smb_blkdata; s->smb_index = 0; - ret = 0; } goto out; }