| Message ID | 20200507131640.14041-13-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | acpi: i386 tweaks | expand |
On Thu, 7 May 2020 15:16:37 +0200 Gerd Hoffmann <kraxel@redhat.com> wrote: > The _STA methods for COM+LPT used to reference them, > but that isn't the case any more. > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > hw/i386/acpi-build.c | 23 ----------------------- > 1 file changed, 23 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 1922868f3401..765409a90eb6 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1437,15 +1437,6 @@ static void build_q35_isa_bridge(Aml *table) > aml_append(field, aml_named_field("LPTD", 2)); > aml_append(dev, field); > > - aml_append(dev, aml_operation_region("LPCE", AML_PCI_CONFIG, > - aml_int(0x82), 0x02)); > - /* enable bits */ > - field = aml_field("LPCE", AML_ANY_ACC, AML_NOLOCK, AML_PRESERVE); > - aml_append(field, aml_named_field("CAEN", 1)); > - aml_append(field, aml_named_field("CBEN", 1)); > - aml_append(field, aml_named_field("LPEN", 1)); > - aml_append(dev, field); > - > aml_append(scope, dev); > aml_append(table, scope); > } > @@ -1469,7 +1460,6 @@ static void build_piix4_isa_bridge(Aml *table) > { > Aml *dev; > Aml *scope; > - Aml *field; > > scope = aml_scope("_SB.PCI0"); > dev = aml_device("ISA"); > @@ -1478,19 +1468,6 @@ static void build_piix4_isa_bridge(Aml *table) > /* PIIX PCI to ISA irq remapping */ > aml_append(dev, aml_operation_region("P40C", AML_PCI_CONFIG, > aml_int(0x60), 0x04)); > - /* enable bits */ > - field = aml_field("^PX13.P13C", AML_ANY_ACC, AML_NOLOCK, AML_PRESERVE); > - /* Offset(0x5f),, 7, */ > - aml_append(field, aml_reserved_field(0x2f8)); > - aml_append(field, aml_reserved_field(7)); > - aml_append(field, aml_named_field("LPEN", 1)); > - /* Offset(0x67),, 3, */ > - aml_append(field, aml_reserved_field(0x38)); > - aml_append(field, aml_reserved_field(3)); > - aml_append(field, aml_named_field("CAEN", 1)); > - aml_append(field, aml_reserved_field(3)); > - aml_append(field, aml_named_field("CBEN", 1)); > - aml_append(dev, field); > > aml_append(scope, dev); > aml_append(table, scope);
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 1922868f3401..765409a90eb6 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1437,15 +1437,6 @@ static void build_q35_isa_bridge(Aml *table) aml_append(field, aml_named_field("LPTD", 2)); aml_append(dev, field); - aml_append(dev, aml_operation_region("LPCE", AML_PCI_CONFIG, - aml_int(0x82), 0x02)); - /* enable bits */ - field = aml_field("LPCE", AML_ANY_ACC, AML_NOLOCK, AML_PRESERVE); - aml_append(field, aml_named_field("CAEN", 1)); - aml_append(field, aml_named_field("CBEN", 1)); - aml_append(field, aml_named_field("LPEN", 1)); - aml_append(dev, field); - aml_append(scope, dev); aml_append(table, scope); } @@ -1469,7 +1460,6 @@ static void build_piix4_isa_bridge(Aml *table) { Aml *dev; Aml *scope; - Aml *field; scope = aml_scope("_SB.PCI0"); dev = aml_device("ISA"); @@ -1478,19 +1468,6 @@ static void build_piix4_isa_bridge(Aml *table) /* PIIX PCI to ISA irq remapping */ aml_append(dev, aml_operation_region("P40C", AML_PCI_CONFIG, aml_int(0x60), 0x04)); - /* enable bits */ - field = aml_field("^PX13.P13C", AML_ANY_ACC, AML_NOLOCK, AML_PRESERVE); - /* Offset(0x5f),, 7, */ - aml_append(field, aml_reserved_field(0x2f8)); - aml_append(field, aml_reserved_field(7)); - aml_append(field, aml_named_field("LPEN", 1)); - /* Offset(0x67),, 3, */ - aml_append(field, aml_reserved_field(0x38)); - aml_append(field, aml_reserved_field(3)); - aml_append(field, aml_named_field("CAEN", 1)); - aml_append(field, aml_reserved_field(3)); - aml_append(field, aml_named_field("CBEN", 1)); - aml_append(dev, field); aml_append(scope, dev); aml_append(table, scope);
The _STA methods for COM+LPT used to reference them, but that isn't the case any more. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- hw/i386/acpi-build.c | 23 ----------------------- 1 file changed, 23 deletions(-)