| Message ID | 20200507131640.14041-4-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | acpi: i386 tweaks | expand |
On Thu, 7 May 2020 15:16:28 +0200 Gerd Hoffmann <kraxel@redhat.com> wrote: > Use a single io range for _CRS instead of two, > following what real hardware does. > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > hw/rtc/mc146818rtc.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c > index 2104e0aa3b14..ab0cc59973b3 100644 > --- a/hw/rtc/mc146818rtc.c > +++ b/hw/rtc/mc146818rtc.c > @@ -1013,12 +1013,14 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope) > Aml *dev; > Aml *crs; > > + /* > + * Reserving 8 io ports here, following what physical hardware > + * does, even though qemu only responds to the first two ports. > + */ > crs = aml_resource_template(); > aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE, > - 0x10, 0x02)); > + 0x01, 0x08)); > aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ)); > - aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE + 2, RTC_ISA_BASE + 2, > - 0x02, 0x06)); > > dev = aml_device("RTC"); > aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));
Reviewed-by: Cameron Esfahani <dirty@apple.com> Cameron Esfahani dirty@apple.com "Americans are very skilled at creating a custom meaning from something that's mass-produced." Ann Powers > On May 7, 2020, at 6:16 AM, Gerd Hoffmann <kraxel@redhat.com> wrote: > > Use a single io range for _CRS instead of two, > following what real hardware does. > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > hw/rtc/mc146818rtc.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c > index 2104e0aa3b14..ab0cc59973b3 100644 > --- a/hw/rtc/mc146818rtc.c > +++ b/hw/rtc/mc146818rtc.c > @@ -1013,12 +1013,14 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope) > Aml *dev; > Aml *crs; > > + /* > + * Reserving 8 io ports here, following what physical hardware > + * does, even though qemu only responds to the first two ports. > + */ > crs = aml_resource_template(); > aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE, > - 0x10, 0x02)); > + 0x01, 0x08)); > aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ)); > - aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE + 2, RTC_ISA_BASE + 2, > - 0x02, 0x06)); > > dev = aml_device("RTC"); > aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00"))); > -- > 2.18.4 > >
diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c index 2104e0aa3b14..ab0cc59973b3 100644 --- a/hw/rtc/mc146818rtc.c +++ b/hw/rtc/mc146818rtc.c @@ -1013,12 +1013,14 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope) Aml *dev; Aml *crs; + /* + * Reserving 8 io ports here, following what physical hardware + * does, even though qemu only responds to the first two ports. + */ crs = aml_resource_template(); aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE, - 0x10, 0x02)); + 0x01, 0x08)); aml_append(crs, aml_irq_no_flags(RTC_ISA_IRQ)); - aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE + 2, RTC_ISA_BASE + 2, - 0x02, 0x06)); dev = aml_device("RTC"); aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0B00")));
Use a single io range for _CRS instead of two, following what real hardware does. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- hw/rtc/mc146818rtc.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)