diff mbox series

[v6,3/3] qemu-options: updates for abstract unix sockets

Message ID 20200516031327.15305-4-zxq_yx_007@163.com (mailing list archive)
State New, archived
Headers show
Series qemu-sockets: add abstract UNIX domain socket support | expand

Commit Message

zhao xiao qiang May 16, 2020, 3:13 a.m. UTC
add options documents changes for -chardev

Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
 qemu-options.hx | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

zhao xiao qiang May 16, 2020, 3:21 a.m. UTC | #1
在 2020/5/16 上午11:13, xiaoqiang zhao 写道:
> add options documents changes for -chardev
>
> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   qemu-options.hx | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index e2dca8a4e9..4ee7e6c772 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2938,7 +2938,7 @@ DEF("chardev", HAS_ARG, QEMU_OPTION_chardev,
>       "         [,server][,nowait][,telnet][,websocket][,reconnect=seconds][,mux=on|off]\n"
>       "         [,logfile=PATH][,logappend=on|off][,tls-creds=ID][,tls-authz=ID] (tcp)\n"
>       "-chardev socket,id=id,path=path[,server][,nowait][,telnet][,websocket][,reconnect=seconds]\n"
> -    "         [,mux=on|off][,logfile=PATH][,logappend=on|off] (unix)\n"
> +    "         [,mux=on|off][,logfile=PATH][,logappend=on|off][,abstract=on|off][,tight=on|off] (unix)\n"
>       "-chardev udp,id=id[,host=host],port=port[,localaddr=localaddr]\n"
>       "         [,localport=localport][,ipv4][,ipv6][,mux=on|off]\n"
>       "         [,logfile=PATH][,logappend=on|off]\n"
> @@ -3105,9 +3105,13 @@ The available backends are:
>   
>           ``nodelay`` disables the Nagle algorithm.
>   
> -    ``unix options: path=path``
> +    ``unix options: path=path[,abstract=on|off][,tight=on|off]``
>           ``path`` specifies the local path of the unix socket. ``path``
>           is required.
> +	``abstract`` specifies the use of the abstract socket namespace,
> +        rather than the filesystem.  Optional, defaults to false.
> +	``tight`` sets the socket length of abstract sockets to their minimum,
> +        rather than the full sun_path length.  Optional, defaults to true.
>   
>   ``-chardev udp,id=id[,host=host],port=port[,localaddr=localaddr][,localport=localport][,ipv4][,ipv6]``
>       Sends all traffic from the guest to a remote host over UDP.

Daniel,  is this still okay for you ?

I have already include a Reviewed-by tag by mistake  ;-(
diff mbox series

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index e2dca8a4e9..4ee7e6c772 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2938,7 +2938,7 @@  DEF("chardev", HAS_ARG, QEMU_OPTION_chardev,
     "         [,server][,nowait][,telnet][,websocket][,reconnect=seconds][,mux=on|off]\n"
     "         [,logfile=PATH][,logappend=on|off][,tls-creds=ID][,tls-authz=ID] (tcp)\n"
     "-chardev socket,id=id,path=path[,server][,nowait][,telnet][,websocket][,reconnect=seconds]\n"
-    "         [,mux=on|off][,logfile=PATH][,logappend=on|off] (unix)\n"
+    "         [,mux=on|off][,logfile=PATH][,logappend=on|off][,abstract=on|off][,tight=on|off] (unix)\n"
     "-chardev udp,id=id[,host=host],port=port[,localaddr=localaddr]\n"
     "         [,localport=localport][,ipv4][,ipv6][,mux=on|off]\n"
     "         [,logfile=PATH][,logappend=on|off]\n"
@@ -3105,9 +3105,13 @@  The available backends are:
 
         ``nodelay`` disables the Nagle algorithm.
 
-    ``unix options: path=path``
+    ``unix options: path=path[,abstract=on|off][,tight=on|off]``
         ``path`` specifies the local path of the unix socket. ``path``
         is required.
+	``abstract`` specifies the use of the abstract socket namespace,
+        rather than the filesystem.  Optional, defaults to false.
+	``tight`` sets the socket length of abstract sockets to their minimum,
+        rather than the full sun_path length.  Optional, defaults to true.
 
 ``-chardev udp,id=id[,host=host],port=port[,localaddr=localaddr][,localport=localport][,ipv4][,ipv6]``
     Sends all traffic from the guest to a remote host over UDP.