[RESEND,v3,03/58] Revert "hw/versatile: realize the PCI root bus as part of the versatile init"

Commit Message

Markus Armbruster June 10, 2020, 5:31 a.m. UTC

This reverts commit b1af7959a66610669e1a019b9a84f6ed3a7936c6.

Realizing a device automatically realizes its buses, in
device_set_realized().  Realizing them in realize methods is
redundant, unless the methods themselves require them to be realized
early.  pci_vpb_realize() doesn't.  Drop the redundant bus
realization.

Cc: Marcel Apfelbaum <[e-mail]>
Cc: Michael S. Tsirkin <[e-mail]>
Signed-off-by: Markus Armbruster <[e-mail]>
Reviewed-by: Paolo Bonzini <[e-mail]>
---
 hw/pci-host/versatile.c | 1 -
 1 file changed, 1 deletion(-)

Patch

diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c
index cfb9a78ea6..28817dbeec 100644
--- a/hw/pci-host/versatile.c
+++ b/hw/pci-host/versatile.c
@@ -458,7 +458,6 @@  static void pci_vpb_realize(DeviceState *dev, Error **errp)
     }
 
     /* TODO Remove once realize propagates to child devices. */
-    object_property_set_bool(OBJECT(&s->pci_bus), true, "realized", errp);
     object_property_set_bool(OBJECT(&s->pci_dev), true, "realized", errp);
 }