| Message ID | 20200701234344.91843-7-ljp@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add several Power ISA 3.1 32/64-bit vector instructions | expand |
On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote: > Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions. > > Signed-off-by: Lijun Pan <ljp@linux.ibm.com> > --- > v4: add missing changes, and split to 5/11, 6/11, 7/11 > v3: use tcg_gen_gvec_mul() > v2: fix coding style > use Power ISA 3.1 flag > > include/elf.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/elf.h b/include/elf.h > index 8fbfe60e09..1858b95acf 100644 > --- a/include/elf.h > +++ b/include/elf.h > @@ -554,6 +554,7 @@ typedef struct { > #define PPC_FEATURE2_HTM_NOSC 0x01000000 > #define PPC_FEATURE2_ARCH_3_00 0x00800000 > #define PPC_FEATURE2_HAS_IEEE128 0x00400000 > +#define PPC_FEATURE2_ARCH_3_10 0x00200000 > > /* Bits present in AT_HWCAP for Sparc. */ Um.. in the corresponding #defines in the kernel 0x00200000 is given to PPC_FEATURE2_DARN, and several more bits are allocated past that point.
> On Jul 13, 2020, at 12:14 AM, David Gibson <david@gibson.dropbear.id.au> wrote: > > On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote: >> Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions. >> >> Signed-off-by: Lijun Pan <ljp@linux.ibm.com> >> --- >> v4: add missing changes, and split to 5/11, 6/11, 7/11 >> v3: use tcg_gen_gvec_mul() >> v2: fix coding style >> use Power ISA 3.1 flag >> >> include/elf.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/elf.h b/include/elf.h >> index 8fbfe60e09..1858b95acf 100644 >> --- a/include/elf.h >> +++ b/include/elf.h >> @@ -554,6 +554,7 @@ typedef struct { >> #define PPC_FEATURE2_HTM_NOSC 0x01000000 >> #define PPC_FEATURE2_ARCH_3_00 0x00800000 >> #define PPC_FEATURE2_HAS_IEEE128 0x00400000 >> +#define PPC_FEATURE2_ARCH_3_10 0x00200000 >> >> /* Bits present in AT_HWCAP for Sparc. */ > > > Um.. in the corresponding #defines in the kernel 0x00200000 is given > to PPC_FEATURE2_DARN, and several more bits are allocated past that > point. > Then what do you recommend to use? Thanks, Lijun
On Mon, Jul 13, 2020 at 02:20:20PM -0500, Lijun Pan wrote: > > > > On Jul 13, 2020, at 12:14 AM, David Gibson <david@gibson.dropbear.id.au> wrote: > > > > On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote: > >> Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions. > >> > >> Signed-off-by: Lijun Pan <ljp@linux.ibm.com> > >> --- > >> v4: add missing changes, and split to 5/11, 6/11, 7/11 > >> v3: use tcg_gen_gvec_mul() > >> v2: fix coding style > >> use Power ISA 3.1 flag > >> > >> include/elf.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/include/elf.h b/include/elf.h > >> index 8fbfe60e09..1858b95acf 100644 > >> --- a/include/elf.h > >> +++ b/include/elf.h > >> @@ -554,6 +554,7 @@ typedef struct { > >> #define PPC_FEATURE2_HTM_NOSC 0x01000000 > >> #define PPC_FEATURE2_ARCH_3_00 0x00800000 > >> #define PPC_FEATURE2_HAS_IEEE128 0x00400000 > >> +#define PPC_FEATURE2_ARCH_3_10 0x00200000 > >> > >> /* Bits present in AT_HWCAP for Sparc. */ > > > > > > Um.. in the corresponding #defines in the kernel 0x00200000 is given > > to PPC_FEATURE2_DARN, and several more bits are allocated past that > > point. > > Then what do you recommend to use? This is part of exposed userland ABI, so it needs to be standardized at least semi-formally. I'm not actually sure who allocates these in general.
> On Jul 13, 2020, at 6:47 PM, David Gibson <david@gibson.dropbear.id.au> wrote: > > On Mon, Jul 13, 2020 at 02:20:20PM -0500, Lijun Pan wrote: >> >> >>> On Jul 13, 2020, at 12:14 AM, David Gibson <david@gibson.dropbear.id.au> wrote: >>> >>> On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote: >>>> Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions. >>>> >>>> Signed-off-by: Lijun Pan <ljp@linux.ibm.com> >>>> --- >>>> v4: add missing changes, and split to 5/11, 6/11, 7/11 >>>> v3: use tcg_gen_gvec_mul() >>>> v2: fix coding style >>>> use Power ISA 3.1 flag >>>> >>>> include/elf.h | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/include/elf.h b/include/elf.h >>>> index 8fbfe60e09..1858b95acf 100644 >>>> --- a/include/elf.h >>>> +++ b/include/elf.h >>>> @@ -554,6 +554,7 @@ typedef struct { >>>> #define PPC_FEATURE2_HTM_NOSC 0x01000000 >>>> #define PPC_FEATURE2_ARCH_3_00 0x00800000 >>>> #define PPC_FEATURE2_HAS_IEEE128 0x00400000 >>>> +#define PPC_FEATURE2_ARCH_3_10 0x00200000 >>>> >>>> /* Bits present in AT_HWCAP for Sparc. */ >>> >>> >>> Um.. in the corresponding #defines in the kernel 0x00200000 is given >>> to PPC_FEATURE2_DARN, and several more bits are allocated past that >>> point. >> >> Then what do you recommend to use? > > This is part of exposed userland ABI, so it needs to be standardized > at least semi-formally. I'm not actually sure who allocates these in > general. Anton, Do you know the allocation standard since you made the last change into elf.h? Lijun > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au <http://gibson.dropbear.id.au/> | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson <http://www.ozlabs.org/~dgibson>
diff --git a/include/elf.h b/include/elf.h index 8fbfe60e09..1858b95acf 100644 --- a/include/elf.h +++ b/include/elf.h @@ -554,6 +554,7 @@ typedef struct { #define PPC_FEATURE2_HTM_NOSC 0x01000000 #define PPC_FEATURE2_ARCH_3_00 0x00800000 #define PPC_FEATURE2_HAS_IEEE128 0x00400000 +#define PPC_FEATURE2_ARCH_3_10 0x00200000 /* Bits present in AT_HWCAP for Sparc. */
Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions. Signed-off-by: Lijun Pan <ljp@linux.ibm.com> --- v4: add missing changes, and split to 5/11, 6/11, 7/11 v3: use tcg_gen_gvec_mul() v2: fix coding style use Power ISA 3.1 flag include/elf.h | 1 + 1 file changed, 1 insertion(+)