[PULL,10/28] qga: Plug unlikely memory leak in guest-set-memory-blocks

Commit Message

Markus Armbruster July 2, 2020, 11:09 a.m. UTC

transfer_memory_block() leaks an Error object when reading file
/sys/devices/system/memory/memory<INDEX>/state fails with errno other
than ENOENT, and @sys2memblk is false, i.e. when the state file exists
but cannot be read (seems quite unlikely), and this is
guest-set-memory-blocks, not guest-get-memory-blocks.

Plug the leak.

Fixes: bd240fca42d5f072fb758a71720d9de9990ac553
Cc: Michael Roth <[e-mail]>
Cc: Hailiang Zhang <[e-mail]>
Signed-off-by: Markus Armbruster <[e-mail]>
Reviewed-by: zhanghailiang <[e-mail]>
Message-Id: <[e-mail]>
---
 qga/commands-posix.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index ae1348dc8f..cdbeb59dcc 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -2421,6 +2421,7 @@  static void transfer_memory_block(GuestMemoryBlock *mem_blk, bool sys2memblk,
             if (sys2memblk) {
                 error_propagate(errp, local_err);
             } else {
+                error_free(local_err);
                 result->response =
                     GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_FAILED;
             }