diff mbox series

[for-5.1] iotests/030: Reduce job speed to make race less likely

Message ID 20200716132829.20127-1-kwolf@redhat.com
State New, archived
Headers show
Series [for-5.1] iotests/030: Reduce job speed to make race less likely | expand

Commit Message

Kevin Wolf July 16, 2020, 1:28 p.m. UTC
It can happen that the throttling of the stream job doesn't make it slow
enough that we can be sure that it still exists when it is referenced
again. Just use a much smaller speed to make this very unlikely to
happen again.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 tests/qemu-iotests/030 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Max Reitz July 16, 2020, 2:45 p.m. UTC | #1
On 16.07.20 15:28, Kevin Wolf wrote:
> It can happen that the throttling of the stream job doesn't make it slow
> enough that we can be sure that it still exists when it is referenced
> again. Just use a much smaller speed to make this very unlikely to
> happen again.
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/qemu-iotests/030 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>
diff mbox series

Patch

diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
index 256b2bfbc6..31c028306b 100755
--- a/tests/qemu-iotests/030
+++ b/tests/qemu-iotests/030
@@ -243,7 +243,7 @@  class TestParallelOps(iotests.QMPTestCase):
             node_name = 'node%d' % i
             job_id = 'stream-%s' % node_name
             pending_jobs.append(job_id)
-            result = self.vm.qmp('block-stream', device=node_name, job_id=job_id, base=self.imgs[i-2], speed=512*1024)
+            result = self.vm.qmp('block-stream', device=node_name, job_id=job_id, base=self.imgs[i-2], speed=1024)
             self.assert_qmp(result, 'return', {})
 
         for job in pending_jobs: