From patchwork Fri Aug 7 14:37:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11705795 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A808A1392 for ; Fri, 7 Aug 2020 14:37:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CC7A221E2 for ; Fri, 7 Aug 2020 14:37:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VergHMkJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CC7A221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:57656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k43VK-0006qj-He for patchwork-qemu-devel@patchwork.kernel.org; Fri, 07 Aug 2020 10:37:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k43Ud-0005rq-Jw for qemu-devel@nongnu.org; Fri, 07 Aug 2020 10:37:11 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:56162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k43Uc-00069Z-6S for qemu-devel@nongnu.org; Fri, 07 Aug 2020 10:37:11 -0400 Received: by mail-wm1-x343.google.com with SMTP id 9so1927873wmj.5 for ; Fri, 07 Aug 2020 07:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qYJVq9iqYG8FmVwk9pWFnsLfEQSRo4FWwadk2ySPfM0=; b=VergHMkJhw8Q8FRPggxHaPq75DzHjxSNLEjzFopnlBuInZtVVCKB7N4i/8lZrd/MB1 JT6nf70zlx5NMHOEbn4Jo9dyevXghpNMPwThjn2uaFMYR+zuqSjbwgjXJFP0LyCnCdPY rvw2XKjW8htS69WBGXwObo6LWQbhq2yq9SOm5cEX8ZqqFYhKt+jhnDr9iNitQ+at6HTX 6C9gRAfvmaarU00VrOb5iNd48EIGwh6zah16gfyUnSiXkE+2AQlbl3ZwgFq54GfGxilo Os79XOvUKOtQmrahMYTT2sP1jyHv+9zvU2F1IlmnWGUyDEyg1Gbk4Jpto9binCkMfnCX rBMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qYJVq9iqYG8FmVwk9pWFnsLfEQSRo4FWwadk2ySPfM0=; b=DQ4xgrbKMPNI/YDIWeniM20rBJOkeANUWgALC/Q3+otYBhXP8MKzTq+D5xt6ZsjmI7 /I+s2jxK2KTgRhqsEaj/S/iJhEMV5lSt9DpctOGkBA3rRx0YZuIGTuoC/rGT0X6M5JmI F9utgY2HRqx8YalLAkyrEJ7j/0NeFTdiTFhZCzYd8jcHZvemv2MOZeNEwWMoEiyNuPwZ aJ7nfqZj3zDzMsv/DrGmHhqBJI0Kp7VrbGGVwqna/0aYy2eUbAaABlLlWk4H4IUhYkil dkRPT+GCYRsmTHQhTG5ThFZ0ICVPxToHiCU+Sg/QyZvZACDVegmeE0BORN3QVhrFn1l/ WoEA== X-Gm-Message-State: AOAM531M+42lfcEiUTn3IwvybKq0gcFXBRp6knAPYHhS33wS+ZHtAZ5w w9k4MTafJgghWOq0BfkF87EwfGkm X-Google-Smtp-Source: ABdhPJwGdoaDyeHOAz/El3M6oL0XggfntXu3GXkZzmAG9aqUNq7d0Hd89Vay8+/IZCWN1VdIwd11xA== X-Received: by 2002:a1c:6604:: with SMTP id a4mr12694632wmc.81.1596811028284; Fri, 07 Aug 2020 07:37:08 -0700 (PDT) Received: from localhost.localdomain (121.red-81-40-121.staticip.rima-tde.net. [81.40.121.121]) by smtp.gmail.com with ESMTPSA id v8sm11033302wmb.24.2020.08.07.07.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 07:37:07 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.2 1/3] hw/misc/unimp: Display value after offset Date: Fri, 7 Aug 2020 16:37:03 +0200 Message-Id: <20200807143705.30066-2-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200807143705.30066-1-f4bug@amsat.org> References: <20200807143705.30066-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x343.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?utf-8?q?Philippe_Mathieu-Dau?= =?utf-8?q?d=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" To better align the read/write accesses, display the value after the offset (read accesses only display the offset). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/misc/unimp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c index bc4084d344..ee2e536c8b 100644 --- a/hw/misc/unimp.c +++ b/hw/misc/unimp.c @@ -22,7 +22,7 @@ static uint64_t unimp_read(void *opaque, hwaddr offset, unsigned size) { UnimplementedDeviceState *s = UNIMPLEMENTED_DEVICE(opaque); - qemu_log_mask(LOG_UNIMP, "%s: unimplemented device read " + qemu_log_mask(LOG_UNIMP, "%s: unimplemented device read " "(size %d, offset 0x%" HWADDR_PRIx ")\n", s->name, size, offset); return 0; @@ -34,9 +34,9 @@ static void unimp_write(void *opaque, hwaddr offset, UnimplementedDeviceState *s = UNIMPLEMENTED_DEVICE(opaque); qemu_log_mask(LOG_UNIMP, "%s: unimplemented device write " - "(size %d, value 0x%" PRIx64 - ", offset 0x%" HWADDR_PRIx ")\n", - s->name, size, value, offset); + "(size %d, offset 0x%" HWADDR_PRIx + ", value 0x%" PRIx64 ")\n", + s->name, size, offset, value); } static const MemoryRegionOps unimp_ops = {