| Message ID | 20200826105254.28496-20-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | microvm: add acpi support | expand |
On Wed, 26 Aug 2020 12:52:53 +0200 Gerd Hoffmann <kraxel@redhat.com> wrote: > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > tests/qtest/bios-tables-test.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index 058ba3886659..883532e531d6 100644 > --- a/tests/qtest/bios-tables-test.c > +++ b/tests/qtest/bios-tables-test.c > @@ -1008,6 +1008,20 @@ static void test_acpi_virt_tcg_memhp(void) > > } > > +static void test_acpi_microvm_tcg(void) > +{ > + test_data data; > + > + memset(&data, 0, sizeof(data)); > + data.machine = "microvm"; > + data.required_struct_types = NULL; /* no smbios */ > + data.required_struct_types_len = 0; > + data.blkdev = "virtio-blk-device"; > + test_acpi_one(" -machine microvm,acpi=on,rtc=off", I'm just curious, why rtc is off? > + &data); > + free_test_data(&data); > +} > + > static void test_acpi_virt_tcg_numamem(void) > { > test_data data = { > @@ -1119,6 +1133,7 @@ int main(int argc, char *argv[]) > qtest_add_func("acpi/q35/dimmpxm", test_acpi_q35_tcg_dimm_pxm); > qtest_add_func("acpi/piix4/acpihmat", test_acpi_piix4_tcg_acpi_hmat); > qtest_add_func("acpi/q35/acpihmat", test_acpi_q35_tcg_acpi_hmat); > + qtest_add_func("acpi/microvm", test_acpi_microvm_tcg); > } else if (strcmp(arch, "aarch64") == 0) { > qtest_add_func("acpi/virt", test_acpi_virt_tcg); > qtest_add_func("acpi/virt/numamem", test_acpi_virt_tcg_numamem);
Hi, > > + test_acpi_one(" -machine microvm,acpi=on,rtc=off", > I'm just curious, why rtc is off? Just want to have it set explicitly in the testcase instead of depending on the default. The rtc is listed in the dsdt if present so the switch has an effect on the expected dsdt content. take care, Gerd
On Wed, 26 Aug 2020 12:52:53 +0200 Gerd Hoffmann <kraxel@redhat.com> wrote: > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > tests/qtest/bios-tables-test.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index 058ba3886659..883532e531d6 100644 > --- a/tests/qtest/bios-tables-test.c > +++ b/tests/qtest/bios-tables-test.c > @@ -1008,6 +1008,20 @@ static void test_acpi_virt_tcg_memhp(void) > > } > > +static void test_acpi_microvm_tcg(void) > +{ > + test_data data; > + > + memset(&data, 0, sizeof(data)); > + data.machine = "microvm"; > + data.required_struct_types = NULL; /* no smbios */ > + data.required_struct_types_len = 0; > + data.blkdev = "virtio-blk-device"; > + test_acpi_one(" -machine microvm,acpi=on,rtc=off", > + &data); > + free_test_data(&data); > +} > + > static void test_acpi_virt_tcg_numamem(void) > { > test_data data = { > @@ -1119,6 +1133,7 @@ int main(int argc, char *argv[]) > qtest_add_func("acpi/q35/dimmpxm", test_acpi_q35_tcg_dimm_pxm); > qtest_add_func("acpi/piix4/acpihmat", test_acpi_piix4_tcg_acpi_hmat); > qtest_add_func("acpi/q35/acpihmat", test_acpi_q35_tcg_acpi_hmat); > + qtest_add_func("acpi/microvm", test_acpi_microvm_tcg); > } else if (strcmp(arch, "aarch64") == 0) { > qtest_add_func("acpi/virt", test_acpi_virt_tcg); > qtest_add_func("acpi/virt/numamem", test_acpi_virt_tcg_numamem);
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 058ba3886659..883532e531d6 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-test.c @@ -1008,6 +1008,20 @@ static void test_acpi_virt_tcg_memhp(void) } +static void test_acpi_microvm_tcg(void) +{ + test_data data; + + memset(&data, 0, sizeof(data)); + data.machine = "microvm"; + data.required_struct_types = NULL; /* no smbios */ + data.required_struct_types_len = 0; + data.blkdev = "virtio-blk-device"; + test_acpi_one(" -machine microvm,acpi=on,rtc=off", + &data); + free_test_data(&data); +} + static void test_acpi_virt_tcg_numamem(void) { test_data data = { @@ -1119,6 +1133,7 @@ int main(int argc, char *argv[]) qtest_add_func("acpi/q35/dimmpxm", test_acpi_q35_tcg_dimm_pxm); qtest_add_func("acpi/piix4/acpihmat", test_acpi_piix4_tcg_acpi_hmat); qtest_add_func("acpi/q35/acpihmat", test_acpi_q35_tcg_acpi_hmat); + qtest_add_func("acpi/microvm", test_acpi_microvm_tcg); } else if (strcmp(arch, "aarch64") == 0) { qtest_add_func("acpi/virt", test_acpi_virt_tcg); qtest_add_func("acpi/virt/numamem", test_acpi_virt_tcg_numamem);
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- tests/qtest/bios-tables-test.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)