[PULL,v5,12/12] hw/display/artist: Fix invalidation of lines near screen border

Commit Message

Helge Deller Aug. 26, 2020, 9:13 p.m. UTC

From: Sven Schnelle <[e-mail]>

If parts of the invalidated screen lines are outside of the VRAM buffer,
the code skips the whole invalidate. This is incorrect when only parts
of the buffer are invisble - which is the case when the mouse cursor is
located near the screen border.

Signed-off-by: Sven Schnelle <[e-mail]>
Signed-off-by: Helge Deller <[e-mail]>
---
 hw/display/artist.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

--
2.21.3

Patch

diff --git a/hw/display/artist.c b/hw/display/artist.c
index a959b2c158..71982559c6 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -206,7 +206,12 @@  static void artist_invalidate_lines(struct vram_buffer *buf,
                                     int starty, int height)
 {
     int start = starty * buf->width;
-    int size = height * buf->width;
+    int size;
+
+    if (starty + height > buf->height)
+        height = buf->height - starty;
+
+    size = height * buf->width;

     if (start + size <= buf->size) {
         memory_region_set_dirty(&buf->mr, start, size);