[v2,08/10] blockdev: Fix a memleak in drive_backup_prepare()

Commit Message

Pan Nengyuan Aug. 31, 2020, 1:43 p.m. UTC

'local_err' seems forgot to propagate in error path, it'll cause
a memleak. Fix it.

Reported-by: Euler Robot <[e-mail]>
Signed-off-by: Pan Nengyuan <[e-mail]>
Reviewed-by: Kevin Wolf <[e-mail]>
Reviewed-by: Li Qiang <[e-mail]>
---
Cc: Kevin Wolf <[e-mail]>
Cc: Max Reitz <[e-mail]>
Cc: Markus Armbruster <[e-mail]>
Cc: [e-mail]
---
- V2: no changes in v2.
---
 blockdev.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/blockdev.c b/blockdev.c
index 3848a9c8ab..842ac289c1 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1801,6 +1801,7 @@  static void drive_backup_prepare(BlkActionState *common, Error **errp)
     if (set_backing_hd) {
         bdrv_set_backing_hd(target_bs, source, &local_err);
         if (local_err) {
+            error_propagate(errp, local_err);
             goto unref;
         }
     }