| Message ID | 20200910023818.11880-1-pannengyuan@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | test-vmstate: remove unnecessary code in match_interval_mapping_node | expand |
Pan Nengyuan <pannengyuan@huawei.com> 于2020年9月10日周四 上午10:39写道： > > 'str' is not used in match_interval_mapping_node(), remove it. > > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> Reviewed-by: Li Qiang <liq3ea@gmail.com> > --- > tests/test-vmstate.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c > index f8de709a0b..1c763015d0 100644 > --- a/tests/test-vmstate.c > +++ b/tests/test-vmstate.c > @@ -1055,9 +1055,6 @@ static gboolean match_interval_mapping_node(gpointer key, > TestGTreeMapping *map_a, *map_b; > TestGTreeInterval *a, *b; > struct match_node_data *d = (struct match_node_data *)data; > - char *str = g_strdup_printf("dest"); > - > - g_free(str); > a = (TestGTreeInterval *)key; > b = (TestGTreeInterval *)d->key; > > -- > 2.21.0.windows.1 > > >
On 10/09/2020 04.38, Pan Nengyuan wrote: > 'str' is not used in match_interval_mapping_node(), remove it. > > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> > --- > tests/test-vmstate.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c > index f8de709a0b..1c763015d0 100644 > --- a/tests/test-vmstate.c > +++ b/tests/test-vmstate.c > @@ -1055,9 +1055,6 @@ static gboolean match_interval_mapping_node(gpointer key, > TestGTreeMapping *map_a, *map_b; > TestGTreeInterval *a, *b; > struct match_node_data *d = (struct match_node_data *)data; > - char *str = g_strdup_printf("dest"); > - > - g_free(str); > a = (TestGTreeInterval *)key; > b = (TestGTreeInterval *)d->key; > > Reviewed-by: Thomas Huth <thuth@redhat.com>
Le 10/09/2020 à 04:38, Pan Nengyuan a écrit : > 'str' is not used in match_interval_mapping_node(), remove it. > > Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> > --- > tests/test-vmstate.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c > index f8de709a0b..1c763015d0 100644 > --- a/tests/test-vmstate.c > +++ b/tests/test-vmstate.c > @@ -1055,9 +1055,6 @@ static gboolean match_interval_mapping_node(gpointer key, > TestGTreeMapping *map_a, *map_b; > TestGTreeInterval *a, *b; > struct match_node_data *d = (struct match_node_data *)data; > - char *str = g_strdup_printf("dest"); > - > - g_free(str); > a = (TestGTreeInterval *)key; > b = (TestGTreeInterval *)d->key; > > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index f8de709a0b..1c763015d0 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1055,9 +1055,6 @@ static gboolean match_interval_mapping_node(gpointer key, TestGTreeMapping *map_a, *map_b; TestGTreeInterval *a, *b; struct match_node_data *d = (struct match_node_data *)data; - char *str = g_strdup_printf("dest"); - - g_free(str); a = (TestGTreeInterval *)key; b = (TestGTreeInterval *)d->key;
'str' is not used in match_interval_mapping_node(), remove it. Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com> --- tests/test-vmstate.c | 3 --- 1 file changed, 3 deletions(-)